From: "Andreas Färber" <afaerber-l3A5Bk7waGM@public.gmane.org>
To: Julien Chauveau
<chauveau.julien-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Catalin Marinas <catalin.marinas-5wv7dgnIgG8@public.gmane.org>,
Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-rockchip
<linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
LAKML
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH v3 6/8] arm64: dts: rockchip: Add power key to GeekBox
Date: Wed, 16 Mar 2016 14:52:33 +0100 [thread overview]
Message-ID: <56E96521.40304@suse.de> (raw)
In-Reply-To: <56E93C43.1060500-l3A5Bk7waGM@public.gmane.org>
Am 16.03.2016 um 11:58 schrieb Andreas Färber:
> Am 11.03.2016 um 00:04 schrieb Julien Chauveau:
>>> @@ -70,6 +71,19 @@
>>> pinctrl-0 = <&ir_int>;
>>> };
>>>
>>> + keys: gpio-keys {
[...]
>>> + compatible = "gpio-keys";
>>> + pinctrl-names = "default";
>>> + pinctrl-0 = <&pwr_key>;
>>> +
>>> + button@0 {
[...]
>>> + gpios = <&gpio0 2 GPIO_ACTIVE_LOW>;
>>> + label = "GPIO Power";
>>> + linux,code = <KEY_POWER>;
>>
>> According to Documentation/input/event-codes.txt, there’s a special event type for the power button.
>> Should we use it here for that purpose?
>>
>> linux,input-type = <EV_PWR>
>
> The other RK3368 boards don't, so unless you can give a justification to
> convert all boards yet again and test how this makes a difference, I'd
> rather not do experiments here but leave that to someone who knows what
> they're doing and then do it consistently...
For the record here's an evtest log:
geekbox:~ # evtest
No device specified, trying to scan all of /dev/input/event*
Available devices:
/dev/input/event0: gpio_ir_recv
/dev/input/event1: MCE IR Keyboard/Mouse (gpio-rc-recv)
/dev/input/event2: gpio-keys
Select the device event number [0-2]: 2
Input driver version is 1.0.1
Input device ID: bus 0x19 vendor 0x1 product 0x1 version 0x100
Input device name: "gpio-keys"
Supported events:
Event type 0 (EV_SYN)
Event type 1 (EV_KEY)
Event code 116 (KEY_POWER)
Properties:
Testing ... (interrupt to exit)
Event: time 1458136008.850429, type 1 (EV_KEY), code 116 (KEY_POWER),
value 1
Event: time 1458136008.850429, -------------- SYN_REPORT ------------
systemd then goes on to shut down the system cleanly.
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-03-16 13:52 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-06 19:53 [PATCH v3 0/8] arm64: rockchip: Initial GeekBox enablement Andreas Färber
2016-03-06 19:53 ` [PATCH v3 3/8] arm64: dts: rockchip: Add GeekBox config Andreas Färber
2016-03-06 19:53 ` [PATCH v3 6/8] arm64: dts: rockchip: Add power key to GeekBox Andreas Färber
[not found] ` <1457294038-14243-7-git-send-email-afaerber-l3A5Bk7waGM@public.gmane.org>
2016-03-10 23:04 ` Julien Chauveau
2016-03-16 10:58 ` Andreas Färber
[not found] ` <56E93C43.1060500-l3A5Bk7waGM@public.gmane.org>
2016-03-16 13:52 ` Andreas Färber [this message]
2016-03-10 23:09 ` Julien Chauveau
2016-03-06 19:53 ` [PATCH v3 7/8] Documentation: devicetree: rockchip: Document Landingship Andreas Färber
2016-03-17 14:46 ` Rob Herring
[not found] ` <1457294038-14243-1-git-send-email-afaerber-l3A5Bk7waGM@public.gmane.org>
2016-03-06 19:53 ` [PATCH v3 1/8] Documentation: devicetree: Add vendor prefix for GeekBuying.com Andreas Färber
2016-03-06 19:53 ` [PATCH v3 2/8] Documentation: devicetree: rockchip: Document GeekBox Andreas Färber
2016-03-06 19:53 ` [PATCH v3 4/8] Documentation: devicetree: Clean up gpio-keys example Andreas Färber
2016-03-07 18:05 ` Heiko Stübner
2016-03-07 18:27 ` Andreas Färber
2016-03-06 19:53 ` [PATCH v3 5/8] arm64: dts: rockchip: Clean up gpio-keys nodes Andreas Färber
2016-03-06 19:53 ` [PATCH v3 8/8] arm64: dts: rockchip: Add Landingship config Andreas Färber
2016-03-07 12:17 ` [PATCH v3 0/8] arm64: rockchip: Initial GeekBox enablement Andreas Färber
2016-03-07 12:24 ` Heiko Stübner
2016-03-07 12:35 ` Andreas Färber
2016-03-07 13:26 ` Giuseppe CAVALLARO
2016-03-07 14:27 ` Andreas Färber
[not found] ` <56DD8FBE.9010200-l3A5Bk7waGM@public.gmane.org>
2016-03-07 15:09 ` Giuseppe CAVALLARO
2016-03-07 15:46 ` Andreas Färber
[not found] ` <56DDA26C.3050301-l3A5Bk7waGM@public.gmane.org>
2016-03-07 15:52 ` Giuseppe CAVALLARO
2016-03-07 17:15 ` Andreas Färber
[not found] ` <56DDB749.1020808-l3A5Bk7waGM@public.gmane.org>
2016-03-07 23:22 ` Dinh Nguyen
[not found] ` <CADhT+wfO8x4En78g5ixnnwbpaeXJGDo+Q1sOABYsbXzNZy0CPw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-08 7:24 ` Giuseppe CAVALLARO
2016-03-08 15:45 ` Dinh Nguyen
2016-03-09 7:24 ` Giuseppe CAVALLARO
2016-03-09 8:35 ` Tomeu Vizoso
[not found] ` <CAAObsKD9HoEbtV_JMz_R=bcrQseDmhncRAWP9k8djksL-LMQqw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-09 8:56 ` Giuseppe CAVALLARO
[not found] ` <56DFE55B.2090806-qxv4g6HH51o@public.gmane.org>
2016-03-09 9:00 ` Giuseppe CAVALLARO
[not found] ` <56DFE64B.8060606-qxv4g6HH51o@public.gmane.org>
2016-03-09 9:42 ` Tomeu Vizoso
[not found] ` <CAAObsKBr9SXg1-wr9O-ypR8JozdGpeAwfDLMeUKi8ozxkKyTXg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-09 9:52 ` Giuseppe CAVALLARO
2016-03-09 10:27 ` Giuseppe CAVALLARO
2016-03-09 10:53 ` Tomeu Vizoso
2016-03-09 14:31 ` Giuseppe CAVALLARO
[not found] ` <56E033C8.40506@st.c om>
[not found] ` <56E033C8.40506-qxv4g6HH51o@public.gmane.org>
2016-03-09 14:53 ` Giuseppe CAVALLARO
[not found] ` <56E038CE.606-qxv4g6HH51o@public.gmane.org>
2016-03-09 16:31 ` Dinh Nguyen
[not found] ` <CADhT+wcMpzA_Coj8Z5OQZsc3bF3a7yOmsbazQMPtcdUWkJSuCA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-10 9:13 ` Giuseppe CAVALLARO
[not found] ` <56E13AAB.2080900-qxv4g6HH51o@public.gmane.org>
2016-03-10 16:47 ` Dinh Nguyen
[not found] ` <CADhT+wd=vcph2y_OxkGNO5EwHvN=kBy-BrfZHmNjZHww4LxmTg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-11 9:09 ` Giuseppe CAVALLARO
2016-03-14 11:43 ` Tomeu Vizoso
[not found] ` <CAAObsKB-tSCu5KMYk2Zi-oX9zMKEOwwT93sMkiZKiYvtexmHaQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-14 16:20 ` Giuseppe CAVALLARO
[not found] ` <56E6E4B0.8060408-qxv4g6HH51o@public.gmane.org>
2016-03-15 7:23 ` Tomeu Vizoso
[not found] ` <CAAObsKCdk+6HdzFYxRKZbPiaKcfMCLjbpngurat47YvyvSgH-w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-15 12:36 ` Giuseppe CAVALLARO
[not found] ` <56E801EB.6030107-qxv4g6HH51o@public.gmane.org>
2016-03-30 16:44 ` Dinh Nguyen
[not found] ` <CADhT+wdXXp322vmgFmWTUiiRZTsCWeJSSdU=BMEEbSyb_bnrUw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-31 7:53 ` Giuseppe CAVALLARO
2016-03-08 10:03 ` Gabriel Fernandez
[not found] ` <CAG374jBLD5YuBT=r3V98OqdUTXMepvQ_tLz4XMJdQMzzGYi22A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-08 10:24 ` Giuseppe CAVALLARO
[not found] ` <56DEA840.1050305-qxv4g6HH51o@public.gmane.org>
2016-03-08 10:33 ` Gabriel Fernandez
2016-03-11 12:12 ` Michael Trimarchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E96521.40304@suse.de \
--to=afaerber-l3a5bk7wagm@public.gmane.org \
--cc=catalin.marinas-5wv7dgnIgG8@public.gmane.org \
--cc=chauveau.julien-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=will.deacon-5wv7dgnIgG8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).