From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ivaylo Dimitrov Subject: Re: [PATCH v3 2/2] media: et8ek8: Add documentation Date: Wed, 15 Jun 2016 22:24:40 +0300 Message-ID: <5761AB78.2030707@gmail.com> References: <1465659593-16858-1-git-send-email-ivo.g.dimitrov.75@gmail.com> <1465659593-16858-3-git-send-email-ivo.g.dimitrov.75@gmail.com> <20160614220517.GA23504@rob-hp-laptop> <20160615043116.GG26360@valkosipuli.retiisi.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Rob Herring , Sakari Ailus Cc: Sebastian Reichel , =?UTF-8?Q?Pali_Roh=c3=a1r?= , Pavel Machek , "linux-media@vger.kernel.org" , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Mauro Carvalho Chehab , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" List-Id: devicetree@vger.kernel.org On 15.06.2016 21:41, Rob Herring wrote: > On Tue, Jun 14, 2016 at 11:31 PM, Sakari Ailus wrote: >> Hi Rob, >> >> On Tue, Jun 14, 2016 at 05:05:17PM -0500, Rob Herring wrote: >>> On Sat, Jun 11, 2016 at 06:39:53PM +0300, Ivaylo Dimitrov wrote: >>>> Add DT bindings description >>> >>> Not exactly the best commit msg. >>> will elaborate a bit more in the next patch version >>>> >>>> Signed-off-by: Ivaylo Dimitrov >>>> --- >>>> .../bindings/media/i2c/toshiba,et8ek8.txt | 50 ++++++++++++++++++++++ >>>> 1 file changed, 50 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt >>>> >>>> diff --git a/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt >>>> new file mode 100644 >>>> index 0000000..997d268 >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt >>>> @@ -0,0 +1,50 @@ >>>> +Toshiba et8ek8 5MP sensor >>>> + >>>> +Toshiba et8ek8 5MP sensor is an image sensor found in Nokia N900 device >>>> + >>>> +More detailed documentation can be found in >>>> +Documentation/devicetree/bindings/media/video-interfaces.txt . >>>> + >>>> + >>>> +Mandatory properties >>>> +-------------------- >>>> + >>>> +- compatible: "toshiba,et8ek8" >>>> +- reg: I2C address (0x3e, or an alternative address) >>>> +- vana-supply: Analogue voltage supply (VANA), 2.8 volts >>> >>>> +- clocks: External clock to the sensor >>>> +- clock-frequency: Frequency of the external clock to the sensor >>> >>> These should be mutually-exclusive. If you have a clock, then you can >>> get the frequency at runtime. >> >> Yes, you can. But the intention is to set the frequency: the sensor requires >> a particular, pre-determined frequency. Typically this is specific to the >> board. > > Okay, then state that in the description. > ok, will do in the next patch version Thanks, Ivo