From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFF8CC33CAA for ; Tue, 21 Jan 2020 06:53:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7F4E621835 for ; Tue, 21 Jan 2020 06:53:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fqowttiT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725890AbgAUGxz (ORCPT ); Tue, 21 Jan 2020 01:53:55 -0500 Received: from mail-lj1-f175.google.com ([209.85.208.175]:40454 "EHLO mail-lj1-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725789AbgAUGxy (ORCPT ); Tue, 21 Jan 2020 01:53:54 -0500 Received: by mail-lj1-f175.google.com with SMTP id u1so1532754ljk.7; Mon, 20 Jan 2020 22:53:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=kwTWJIUfDKpjGMMD4Mhe6loQ/8Oq0czs+l1SKyyucsw=; b=fqowttiTC2Hm6U3l+a+AixWVGd7B5blu3OrzZ/qyBFgNkXfQiLiT3AlMjxiJNeWkVP IHBePBL5I4PH8GJ5pd1s9vxFqDnHPttopi8t9F/4Iz0UAe/CAsnHoAOJA8B1yJF83gJL P0Xsq6GLx3ObrGEX5hsSVjBBaKjpwKt0UHgho2Ad8VMF332QGsgSUPFfgTH/i+RxNIQL cVgBY5PxYAbrBvA867S3yaw3kHVEyUaA+I1SjI5cVmG/8hMr3P5XItahVbgK8dAU4Uql qjDtAQHSY9dF6TwYEUMK8c3VbeJl2KnwSacxO4aEzJ8aVTktPYmGuAbBuRQuuRun8fr4 R9LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=kwTWJIUfDKpjGMMD4Mhe6loQ/8Oq0czs+l1SKyyucsw=; b=n4/9Hh6gTW5qMlZpzvzTvbZda3sveg9JU8F0b0YnVZeK5X3s2EAYqO45PQczghYfDE LzVZLNmRJWZuZ4p6V5S5GPsHBWdY2b1onbA//knDp+Dy96WJbfLW4S7d0E+oesFwLkfO TAhg28w/QHdB/AeQ/TAFx7qPKvnOPK2e3YZmog4EIaMicsR42/IRhdgqQEP7Wyq7zCYV 6O3VHnvfCq2L7jFjC7Xo9ui+YeSP7F7dZY/Yr2LsjbifMMDMJ4lctIx3VlgOowHTlhw6 CVzjCaYfloP5Xv+z72zbetRg0QkiUjiNikpJHVi0iisg6dNHha6ncURBBtadt4jS6gHa qkWA== X-Gm-Message-State: APjAAAUCe83E0lDFpjH+917umsDeSLKtdEBRJufebP8SW3fiJXWcCPOJ Rholi65Tlt3ILjshJWBI2BdvOnb0 X-Google-Smtp-Source: APXvYqyz5ZlhrVbxipJo8aN13r4pVct0imGRA4ucSlT0nDwR0li3vBDUY85v/fCjWo9ml9XQeUiFpQ== X-Received: by 2002:a2e:a361:: with SMTP id i1mr14607321ljn.29.1579589631436; Mon, 20 Jan 2020 22:53:51 -0800 (PST) Received: from [192.168.2.145] (79-139-233-37.dynamic.spd-mgts.ru. [79.139.233.37]) by smtp.googlemail.com with ESMTPSA id f30sm17937499ljp.31.2020.01.20.22.53.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jan 2020 22:53:50 -0800 (PST) Subject: Re: [RFC 2/2] dt-bindings: firmware: tegra186-bpmp: Document interconnects property To: Thierry Reding , Georgi Djakov Cc: Rob Herring , Jon Hunter , linux-tegra@vger.kernel.org, devicetree@vger.kernel.org References: <20200114181519.3402385-1-thierry.reding@gmail.com> <20200114181519.3402385-2-thierry.reding@gmail.com> <7aefac6c-092c-b5a6-2fa6-e283d2147fc3@linaro.org> <20200120150605.GA712203@ulmo> From: Dmitry Osipenko Message-ID: <57c37b3c-1473-d444-db59-8c6650241188@gmail.com> Date: Tue, 21 Jan 2020 09:53:48 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <20200120150605.GA712203@ulmo> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org 20.01.2020 18:06, Thierry Reding пишет: > On Fri, Jan 17, 2020 at 05:23:43PM +0200, Georgi Djakov wrote: >> Hi Thierry, >> >> Thanks for the patch! >> >> On 1/14/20 20:15, Thierry Reding wrote: >>> From: Thierry Reding >>> >>> Document the interconnects property that is used to describe the paths >>> from and to system memory from and to the BPMP. >>> >>> Signed-off-by: Thierry Reding >>> --- >>> Rob, Georgi, >>> >>> after the initial RFC that I did for adding interconnect properties on >>> Tegra, I realized that the description wasn't complete. This is an >>> attempt at a more accurate description, but unfortunately I'm not sure >>> if it's even correct in terms of the interconnect bindings. >>> >>> The problem here is that on Tegra, each device has multiple paths to >>> system memory, and I have no good idea on what to pick as the default. >>> They are all basically the same path, but each provides extra controls >>> to configure the "interconnect". >> >> Are these multiple paths between a device and system memory used simultaneously >> for load-balancing, or who makes the decision about which path would be used? > > It varies. The vast majority of these paths are read/write pairs, which > can be configured separately. There are also cases where multiple paths > are used for load-balancing and I don't think there's any direct > software control over which path will be used. > > A third class is where you have one device, but two read/write pairs, > one which is tied to a microcontroller that's part of the device, and > another read/write pair that is used for DMA to/from the device. > > Often in the latter case, the microcontroller memory client interfaces > will be used by the microcontroller to read firmware and once the micro- > controller has booted up, the DMA memory client interfaces will be used > to read/write system memory with bulk data (like frame buffers, etc.). > >> Is this based on the client/stream ID that you mentioned previously? > > These are now all what's call memory client IDs, which identify the > corresponding interface to the memory controller. Stream IDs are > slightly higher-level and typically identify the "module" that uses > the SMMU. Generally a stream ID is mapped to one or more memory client > IDs. > >> Looking at the the binding below, it seems to me like there are different >> master/slave pairs between MC and EMC and each link is used for >> unidirectional traffic only. In terms of the interconnect API, both read >> and write paths have the same direction. Yes, that definition should be incorrect. > I'm not sure I understand what you mean by this last sentence. Are you > saying that each path in terms of the interconnect API is a always a > bidirectional link? Please see more below. >> Is the EMC really an interconnect provider or is it just a slave port? Can >> we scale both EMC and MC independently? > > The EMC is the only one where we can scale the frequency, but the MC has > various knobs that can be used to fine-tune arbitration, set maximum > latency, etc. Yes.. EMC controls the total amount of available memory bandwidth, things like DRAM timing and EMC-DRAM channel's performance. EMC is facing MC from one side and DRAM (EMEM) from the other. MC controls allocation of that total bandwidth between the memory clients. It has knobs to prioritize clients, the knobs are per read/write port. MC is facing memory clients from one side and EMC from the other. > I vaguely recall Dmitry mentioning that the EMC in early generations of > Tegra used to have controls for individual memory clients, but I don't > see that in more recent generations. EMC doesn't have direct controls over memory clients on all Tegra SoCs, but it may have some extra knobs for the MC arbitration config. The MC bandwidth allocation logic and hardware programming interface differs among SoC generations, but the basic principle is the same. >>> Any ideas on how to resolve this? Let me know if the DT bindings and >>> example don't make things clear enough. I'm also interested in the answer to this question. A quick thought.. maybe it could be some new ICC DT property which tells that all paths are the "dma-mem": interconnects-all-dma-mem; >>> .../firmware/nvidia,tegra186-bpmp.yaml | 59 +++++++++++++++++++ >>> 1 file changed, 59 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/firmware/nvidia,tegra186-bpmp.yaml b/Documentation/devicetree/bindings/firmware/nvidia,tegra186-bpmp.yaml >>> index dabf1c1aec2f..d40fcd836e90 100644 >>> --- a/Documentation/devicetree/bindings/firmware/nvidia,tegra186-bpmp.yaml >>> +++ b/Documentation/devicetree/bindings/firmware/nvidia,tegra186-bpmp.yaml >>> @@ -43,6 +43,24 @@ properties: >>> - enum: >>> - nvidia,tegra186-bpmp >>> >>> + interconnects: >>> + $ref: /schemas/types.yaml#/definitions/phandle-array >>> + description: A list of phandle and specifier pairs that describe the >>> + interconnect paths to and from the BPMP. >>> + >>> + interconnect-names: >>> + $ref: /schemas/types.yaml#/definitions/non-unique-string-array >>> + description: One string for each pair of phandle and specifier in the >>> + "interconnects" property. >>> + # XXX We need at least one of these to be named dma-mem so that the core >>> + # will set the DMA mask based on the DMA parent, but all of these go to >>> + # system memory eventually. >>> + items: >>> + - const: dma-mem >>> + - const: dma-mem >>> + - const: dma-mem >>> + - const: dma-mem Names should be unique, otherwise it's not possible to retrieve ICC path other than the first one. >>> iommus: >>> $ref: /schemas/types.yaml#/definitions/phandle-array >>> description: | >>> @@ -152,8 +170,43 @@ additionalProperties: false >>> >>> examples: >>> - | >>> + #include >>> #include >>> #include >>> + #include >>> + >>> + mc: memory-controller@2c00000 { >>> + compatible = "nvidia,tegra186-mc"; >>> + reg = <0x02c00000 0xb0000>; >>> + interrupts = ; >>> + status = "disabled"; >>> + >>> + #interconnect-cells = <1>; >>> + #address-cells = <2>; >>> + #size-cells = <2>; >>> + >>> + ranges = <0x02c00000 0x0 0x02c00000 0x0 0xb0000>; >>> + >>> + /* >>> + * Memory clients have access to all 40 bits that the memory >>> + * controller can address. >>> + */ >>> + dma-ranges = <0x0 0x0 0x0 0x100 0x0>; >>> + >>> + #memory-controller-cells = <0>; >>> + >>> + emc: external-memory-controller@2c60000 { >>> + compatible = "nvidia,tegra186-emc"; >>> + reg = <0x0 0x02c60000 0x0 0x50000>; >>> + interrupts = ; >>> + clocks = <&bpmp TEGRA186_CLK_EMC>; >>> + clock-names = "emc"; >>> + >>> + #interconnect-cells = <0>; >>> + >>> + nvidia,bpmp = <&bpmp>; >>> + }; >>> + }; >>> >>> hsp_top0: hsp@3c00000 { >>> compatible = "nvidia,tegra186-hsp"; >>> @@ -187,6 +240,12 @@ examples: >>> >>> bpmp { >>> compatible = "nvidia,tegra186-bpmp"; >>> + interconnects = <&emc &mc TEGRA186_MEMORY_CLIENT_BPMPR>, >>> + <&mc TEGRA186_MEMORY_CLIENT_BPMPW &emc>, >>> + <&emc &mc TEGRA186_MEMORY_CLIENT_BPMPDMAR>, >>> + <&mc TEGRA186_MEMORY_CLIENT_BPMPDMAW &emc>; I don't think this is a correct definition of the ICC paths because the first node-MC_ID pair should define the source, second pair is the final destination. Then the interconnect core builds (by itself) the path from MC client to MC and finally to EMC based on the given source / destination. Please see my v1 patchset for the example. It should look somewhat like this: interconnects = <&mc TEGRA186_MEMORY_CLIENT_BPMPR &emc TEGRA_ICC_EMEM>, <&mc TEGRA186_MEMORY_CLIENT_BPMPW &emc TEGRA_ICC_EMEM>, <&mc TEGRA186_MEMORY_CLIENT_BPMPDMAR &emc TEGRA_ICC_EMEM>, <&mc TEGRA186_MEMORY_CLIENT_BPMPDMAW &emc TEGRA_ICC_EMEM>; interconnect-names = "bpmpr", "bpmpw", "bpmpdmar", "bpmpdmaw"; >>> + interconnect-names = "dma-mem", "dma-mem", "dma-mem", "dma-mem"; >>> + >>> iommus = <&smmu TEGRA186_SID_BPMP>; >>> mboxes = <&hsp_top0 TEGRA_HSP_MBOX_TYPE_DB TEGRA_HSP_DB_MASTER_BPMP>; >>> shmem = <&cpu_bpmp_tx &cpu_bpmp_rx>; >>>