From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 423F1C433DF for ; Mon, 24 Aug 2020 14:19:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1D4912074D for ; Mon, 24 Aug 2020 14:19:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=agner.ch header.i=@agner.ch header.b="klG4oPX8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725958AbgHXOTc (ORCPT ); Mon, 24 Aug 2020 10:19:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60454 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725916AbgHXOTb (ORCPT ); Mon, 24 Aug 2020 10:19:31 -0400 Received: from mail.kmu-office.ch (mail.kmu-office.ch [IPv6:2a02:418:6a02::a2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7C82C061573 for ; Mon, 24 Aug 2020 07:19:30 -0700 (PDT) Received: from webmail.kmu-office.ch (unknown [IPv6:2a02:418:6a02::a3]) by mail.kmu-office.ch (Postfix) with ESMTPSA id 0115A5C3C43; Mon, 24 Aug 2020 16:19:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=agner.ch; s=dkim; t=1598278764; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZJ4IdJs7vNZOHX+v4Asmyv1svNA8lWS2xHxhNIw5NQw=; b=klG4oPX8z1HBdwMgPDp2O8SGPWF8a47XixIANUD22HRjeOAsU7wv/v/Qcxu3LA4IgK9Dmo hIiYXrhQDT2hyK8J2tF45euT5alXOcQdQE7WwhHOKJgXs/LCcrJP7ZbQhOwQvYZrcCxlrJ eahw5B5opFddIJvJn/8qXWVpnHUmn9Q= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Date: Mon, 24 Aug 2020 16:19:23 +0200 From: Stefan Agner To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, Marek Vasut , Rob Herring , Pengutronix Kernel Team , linux-arm-kernel@lists.infradead.org, =?UTF-8?Q?Guido_G=C3=BCnther?= Subject: Re: [PATCH 2/8] dt-bindings: display: mxsfb: Add and fix compatible strings In-Reply-To: <20200823232603.GO6002@pendragon.ideasonboard.com> References: <20200813012910.13576-1-laurent.pinchart@ideasonboard.com> <20200813012910.13576-3-laurent.pinchart@ideasonboard.com> <20200823232603.GO6002@pendragon.ideasonboard.com> User-Agent: Roundcube Webmail/1.4.1 Message-ID: <58ad6bef353ee25e5c548c0d950f7e46@agner.ch> X-Sender: stefan@agner.ch Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2020-08-24 01:26, Laurent Pinchart wrote: > Hi Stefan, > > On Fri, Aug 21, 2020 at 04:53:56PM +0200, Stefan Agner wrote: >> On 2020-08-13 03:29, Laurent Pinchart wrote: >> > Additional compatible strings have been added in DT source for the >> > i.MX6SL, i.MX6SLL, i.MX6UL and i.MX7D without updating the bindings. >> > Most of the upstream DT sources use the fsl,imx28-lcdif compatible >> > string, which mostly predates the realization that the LCDIF in the >> > i.MX6 and newer SoCs have extra features compared to the i.MX28. >> >> Agreed, we should add fsl,imx6sx-lcdif for those devices. >> >> But shouldn't we also keep fsl,imx28-lcdif? From what I can tell, the >> devices can be driven by a driver only supporting fsl,imx28-lcdif >> semantics, right? > > Isn't it kept by this patch ? > >> > Update the bindings to add the missing compatible strings, with the >> > correct fallback values. This fails to validate some of the upstream DT >> > sources. Instead of adding the incorrect compatible fallback to the >> > binding, the sources should be updated separately. >> > >> > Signed-off-by: Laurent Pinchart >> > --- >> > .../devicetree/bindings/display/mxsfb.yaml | 18 +++++++++++++----- >> > 1 file changed, 13 insertions(+), 5 deletions(-) >> > >> > diff --git a/Documentation/devicetree/bindings/display/mxsfb.yaml >> > b/Documentation/devicetree/bindings/display/mxsfb.yaml >> > index 202381ec5bb7..ec6533b1d4a3 100644 >> > --- a/Documentation/devicetree/bindings/display/mxsfb.yaml >> > +++ b/Documentation/devicetree/bindings/display/mxsfb.yaml >> > @@ -15,11 +15,19 @@ description: | >> > >> > properties: >> > compatible: >> > - enum: >> > - - fsl,imx23-lcdif >> > - - fsl,imx28-lcdif >> > - - fsl,imx6sx-lcdif >> > - - fsl,imx8mq-lcdif >> > + oneOf: >> > + - enum: >> > + - fsl,imx23-lcdif >> > + - fsl,imx28-lcdif > > Here -----------------^ > > The binding now support any of "fsl,imx23-lcdif", "fsl,imx28-lcdif" or > "fsl,imx6sx-lcdif" alone, or "fsl,imx6sx-lcdif" with another > device-specific compatible string. The driver supports the three base > compatible strings, for V3, V4 and V6 of the IP core. The binding yes, but I mean the device descriptions in the device tree. Since the device can be driven by a older kernel which only knows about the fsl,imx28-lcdif compatible string, we could keep that compatible. >From what I can tell, we can add both safely, e.g. compatible = "fsl,imx6sx-lcdif", "fsl,imx28-lcdif" >From how I read the description this now replaces "fsl,imx28-lcdif" with "fsl,imx6sx-lcdif" for the devices supporting the additional features, e.g.: --- a/arch/arm/boot/dts/imx6sl.dtsi +++ b/arch/arm/boot/dts/imx6sl.dtsi @@ -769,7 +769,7 @@ epdc: epdc@20f4000 { }; lcdif: lcdif@20f8000 { - compatible = "fsl,imx6sl-lcdif", "fsl,imx28-lcdif"; + compatible = "fsl,imx6sl-lcdif", "fsl,imx6sx-lcdif"; reg = <0x020f8000 0x4000>; interrupts = <0 39 IRQ_TYPE_LEVEL_HIGH>; clocks = <&clks IMX6SL_CLK_LCDIF_PIX>, -- Stefan > >> > + - fsl,imx6sx-lcdif >> > + - items: >> > + - enum: >> > + - fsl,imx6sl-lcdif >> > + - fsl,imx6sll-lcdif >> > + - fsl,imx6ul-lcdif >> > + - fsl,imx7d-lcdif >> > + - fsl,imx8mq-lcdif >> > + - const: fsl,imx6sx-lcdif >> > >> > reg: >> > maxItems: 1