From mboxrd@z Thu Jan 1 00:00:00 1970 From: JeffyChen Subject: Re: [PATCH v4 07/13] ARM: dts: rockchip: add clocks in vop iommu nodes Date: Fri, 19 Jan 2018 12:55:58 +0800 Message-ID: <5A617A5E.6070606@rock-chips.com> References: <20180118115251.5542-1-jeffy.chen@rock-chips.com> <20180118115251.5542-8-jeffy.chen@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Tomasz Figa Cc: Mark Rutland , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Heiko Stuebner , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Russell King , Ricky Liang , "open list:ARM/Rockchip SoC..." , "list-Y9sIeH5OGRo@public.gmane.org:IOMMU DRIVERS" , Rob Herring , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Tomasz, Thanks for your reply. On 01/19/2018 11:23 AM, Tomasz Figa wrote: > On Thu, Jan 18, 2018 at 8:52 PM, Jeffy Chen wrote: >> Add clocks in vop iommu nodes, since we are going to control clocks in >> rockchip iommu driver. >> >> Signed-off-by: Jeffy Chen >> --- >> >> Changes in v4: None >> Changes in v3: None >> Changes in v2: None >> >> arch/arm/boot/dts/rk3036.dtsi | 2 ++ >> arch/arm/boot/dts/rk3288.dtsi | 4 ++++ >> 2 files changed, 6 insertions(+) >> >> diff --git a/arch/arm/boot/dts/rk3036.dtsi b/arch/arm/boot/dts/rk3036.dtsi >> index 3b704cfed69a..95b0ebc7a40f 100644 >> --- a/arch/arm/boot/dts/rk3036.dtsi >> +++ b/arch/arm/boot/dts/rk3036.dtsi >> @@ -197,6 +197,8 @@ >> reg = <0x10118300 0x100>; >> interrupts = ; >> interrupt-names = "vop_mmu"; >> + clocks = <&cru ACLK_LCDC>, <&cru SCLK_LCDC>, <&cru HCLK_LCDC>; >> + clock-names = "aclk_vop", "dclk_vop", "hclk_vop"; > > We should remove clock-names from IOMMU nodes. The Rockchip IOMMU > bindings don't define clock names and only the clocks property should > be given. > hmmm, i'm trying to switch to clk_bulk APIs, the get and put are name based. or maybe i can use clk_get/put along with other clk_bulk APIs > Not even saying that the names currently listed are not good examples, > they name SoC clock controller output, rather than device inputs. > > Best regards, > Tomasz > > >