devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH v1 2/2] dt-bindings: net: bluetooth: Add device tree bindings for QCA6390
       [not found] <0101016ef8b923bc-5760b40c-1968-4992-9186-8e3965207236-000000@us-west-2.amazonses.com>
@ 2019-12-12 10:33 ` Marcel Holtmann
  2019-12-13  3:35   ` rjliao
  0 siblings, 1 reply; 5+ messages in thread
From: Marcel Holtmann @ 2019-12-12 10:33 UTC (permalink / raw)
  To: Rocky Liao
  Cc: Rob Herring, Mark Rutland, Johan Hedberg, netdev, devicetree,
	linux-kernel, linux-bluetooth, linux-arm-msm, bgodavar

Hi Rocky,

> Add compatible string for the Qualcomm QCA6390 Bluetooth controller
> 
> Signed-off-by: Rocky Liao <rjliao@codeaurora.org>
> ---
> Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
> index 68b67d9db63a..87b7f9d22414 100644
> --- a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
> +++ b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
> @@ -10,6 +10,7 @@ device the slave device is attached to.
> Required properties:
>  - compatible: should contain one of the following:
>    * "qcom,qca6174-bt"
> +   * "qcom,qca6390-bt"
>    * "qcom,wcn3990-bt"
>    * "qcom,wcn3998-bt"

now I am confused. Is this a DT platform or ACPI or both?

Regards

Marcel


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v1 2/2] dt-bindings: net: bluetooth: Add device tree bindings for QCA6390
  2019-12-12 10:33 ` [PATCH v1 2/2] dt-bindings: net: bluetooth: Add device tree bindings for QCA6390 Marcel Holtmann
@ 2019-12-13  3:35   ` rjliao
  2019-12-13  7:37     ` Marcel Holtmann
  0 siblings, 1 reply; 5+ messages in thread
From: rjliao @ 2019-12-13  3:35 UTC (permalink / raw)
  To: Marcel Holtmann
  Cc: Rob Herring, Mark Rutland, Johan Hedberg, netdev, devicetree,
	linux-kernel, linux-bluetooth, linux-arm-msm, bgodavar,
	linux-bluetooth-owner

在 2019-12-12 18:33,Marcel Holtmann 写道:
> Hi Rocky,
> 
>> Add compatible string for the Qualcomm QCA6390 Bluetooth controller
>> 
>> Signed-off-by: Rocky Liao <rjliao@codeaurora.org>
>> ---
>> Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt | 1 +
>> 1 file changed, 1 insertion(+)
>> 
>> diff --git 
>> a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt 
>> b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
>> index 68b67d9db63a..87b7f9d22414 100644
>> --- a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
>> +++ b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
>> @@ -10,6 +10,7 @@ device the slave device is attached to.
>> Required properties:
>>  - compatible: should contain one of the following:
>>    * "qcom,qca6174-bt"
>> +   * "qcom,qca6390-bt"
>>    * "qcom,wcn3990-bt"
>>    * "qcom,wcn3998-bt"
> 
> now I am confused. Is this a DT platform or ACPI or both?
> 
We need to support both, should I update ACPI part in this doc as well?
> Regards
> 
> Marcel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v1 2/2] dt-bindings: net: bluetooth: Add device tree bindings for QCA6390
  2019-12-13  3:35   ` rjliao
@ 2019-12-13  7:37     ` Marcel Holtmann
  0 siblings, 0 replies; 5+ messages in thread
From: Marcel Holtmann @ 2019-12-13  7:37 UTC (permalink / raw)
  To: Rocky Liao
  Cc: Rob Herring, Mark Rutland, Johan Hedberg, netdev, devicetree,
	linux-kernel, linux-bluetooth, linux-arm-msm, bgodavar,
	linux-bluetooth-owner

Hi Rocky,

>>> Add compatible string for the Qualcomm QCA6390 Bluetooth controller
>>> Signed-off-by: Rocky Liao <rjliao@codeaurora.org>
>>> ---
>>> Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt | 1 +
>>> 1 file changed, 1 insertion(+)
>>> diff --git a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
>>> index 68b67d9db63a..87b7f9d22414 100644
>>> --- a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
>>> +++ b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
>>> @@ -10,6 +10,7 @@ device the slave device is attached to.
>>> Required properties:
>>> - compatible: should contain one of the following:
>>>   * "qcom,qca6174-bt"
>>> +   * "qcom,qca6390-bt"
>>>   * "qcom,wcn3990-bt"
>>>   * "qcom,wcn3998-bt"
>> now I am confused. Is this a DT platform or ACPI or both?
> We need to support both, should I update ACPI part in this doc as well?

this patch is fine the, but the other one would be better if you split it in DT and ACPI support.

Regards

Marcel


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v1 2/2] dt-bindings: net: bluetooth: Add device tree bindings for QCA6390
  2019-12-12  6:08 Rocky Liao
@ 2019-12-19 23:07 ` Rob Herring
  0 siblings, 0 replies; 5+ messages in thread
From: Rob Herring @ 2019-12-19 23:07 UTC (permalink / raw)
  To: Rocky Liao
  Cc: robh+dt, mark.rutland, marcel, johan.hedberg, netdev, devicetree,
	linux-kernel, linux-bluetooth, linux-arm-msm, bgodavar,
	Rocky Liao

On Thu, 12 Dec 2019 06:08:33 +0000, Rocky Liao wrote:
> Add compatible string for the Qualcomm QCA6390 Bluetooth controller
> 
> Signed-off-by: Rocky Liao <rjliao@codeaurora.org>
> ---
>  Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt | 1 +
>  1 file changed, 1 insertion(+)
> 

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH v1 2/2] dt-bindings: net: bluetooth: Add device tree bindings for QCA6390
@ 2019-12-12  6:08 Rocky Liao
  2019-12-19 23:07 ` Rob Herring
  0 siblings, 1 reply; 5+ messages in thread
From: Rocky Liao @ 2019-12-12  6:08 UTC (permalink / raw)
  To: robh+dt, mark.rutland, marcel, johan.hedberg
  Cc: netdev, devicetree, linux-kernel, linux-bluetooth, linux-arm-msm,
	bgodavar, Rocky Liao

Add compatible string for the Qualcomm QCA6390 Bluetooth controller

Signed-off-by: Rocky Liao <rjliao@codeaurora.org>
---
 Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
index 68b67d9db63a..87b7f9d22414 100644
--- a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
+++ b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
@@ -10,6 +10,7 @@ device the slave device is attached to.
 Required properties:
  - compatible: should contain one of the following:
    * "qcom,qca6174-bt"
+   * "qcom,qca6390-bt"
    * "qcom,wcn3990-bt"
    * "qcom,wcn3998-bt"
 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project


^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-12-19 23:07 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <0101016ef8b923bc-5760b40c-1968-4992-9186-8e3965207236-000000@us-west-2.amazonses.com>
2019-12-12 10:33 ` [PATCH v1 2/2] dt-bindings: net: bluetooth: Add device tree bindings for QCA6390 Marcel Holtmann
2019-12-13  3:35   ` rjliao
2019-12-13  7:37     ` Marcel Holtmann
2019-12-12  6:08 Rocky Liao
2019-12-19 23:07 ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).