From: harigovi@codeaurora.org
To: Stephen Boyd <swboyd@chromium.org>
Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, robdclark@gmail.com,
seanpaul@chromium.org, hoegsberg@chromium.org,
kalyan_t@codeaurora.org, nganji@codeaurora.org
Subject: Re: [v3] arm64: dts: sc7180: add nodes for idp display
Date: Mon, 29 Jun 2020 19:20:09 +0530 [thread overview]
Message-ID: <5c2265e82af8f755d649c0c36a462f19@codeaurora.org> (raw)
In-Reply-To: <159304723830.62212.5069780400830519255@swboyd.mtv.corp.google.com>
On 2020-06-25 06:37, Stephen Boyd wrote:
> Quoting Harigovindan P (2020-02-17 00:58:42)
>> diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
>> b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
>> index 388f50ad4fde..349db8fe78a5 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
>> +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
>> @@ -232,6 +233,57 @@ vreg_bob: bob {
>> };
>> };
>>
>> +&dsi0 {
>> + status = "okay";
>> +
>> + vdda-supply = <&vreg_l3c_1p2>;
>> +
>> + panel@0 {
>> + compatible = "visionox,rm69299-1080p-display";
>> + reg = <0>;
>> +
>> + vdda-supply = <&vreg_l8c_1p8>;
>> + vdd3p3-supply = <&vreg_l18a_2p8>;
>> +
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&disp_pins>;
>> +
>> + reset-gpios = <&pm6150l_gpio 3 GPIO_ACTIVE_HIGH>;
>> +
>> + ports {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + port@0 {
>> + reg = <0>;
>> + panel0_in: endpoint {
>> + remote-endpoint = <&dsi0_out>;
>> + };
>> + };
>> + };
>> + };
>> +
>> + ports {
>> + port@1 {
>> + endpoint {
>> + remote-endpoint = <&panel0_in>;
>> + data-lanes = <0 1 2 3>;
>
> Is this property needed? If it's the default assumption it would be
> nice
> to omit it so that we don't have to think about it.
> This property is needed during panel probe. If this is not mentioned
> here,
mipi_dsi_attach() will fail during panel probe. In dsi_host.c,
dsi_host_attach()
fails since dsi lanes are greater than msm_host lanes. msm_host lanes
are updated
as part of dsi_host_parse_dt. If we dont provide data-lanes in dt, it'll
have default
value and fail in dsi_host_attach().
>> + };
>> + };
>> + };
>> +};
>> +
>> +&dsi_phy {
>> + status = "okay";
>> +};
>> +
>> +&mdp {
>> + status = "okay";
>> +};
>> +
>> +&mdss {
>> + status = "okay";
>> +};
>> +
>> &qspi {
>> status = "okay";
>> pinctrl-names = "default";
>> @@ -289,6 +341,17 @@ &usb_1_qmpphy {
>>
>> /* PINCTRL - additions to nodes defined in sc7180.dtsi */
>>
>> +&pm6150l_gpio {
>> + disp_pins: disp-pins {
>
> Curious how this works. It looks like PMIC GPIOS are expecting the node
> to look like:
>
> disp_pins: disp-pins {
> pinconf {
> pins = "gpio3";
> function = PMIC_GPIO_FUNC_FUNC1;
> qcom,drive-strength = <PMIC_GPIO_STRENGTH_MED>;
> power-source = <PM6150_GPIO_VPH>;
> bias-disable;
> output-low;
> };
>
> but this doesn't use the macros or the subnode for pinconf. Why? Also,
> the PM6150_GPIO_VPH macro doesn't exist.
We are discussing with PMIC team to have that macro in the header file.
Will add other macros as part of next version.
>
>> + pins = "gpio3";
>> + function = "func1";
>> + qcom,drive-strength = <2>;
>> + power-source = <0>;
>> + bias-disable;
>> + output-low;
>> + };
>> +};
>> +
next prev parent reply other threads:[~2020-06-29 19:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 8:58 [v3] arm64: dts: sc7180: add nodes for idp display Harigovindan P
2020-06-25 1:07 ` Stephen Boyd
2020-06-29 13:50 ` harigovi [this message]
2020-07-20 20:24 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c2265e82af8f755d649c0c36a462f19@codeaurora.org \
--to=harigovi@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=hoegsberg@chromium.org \
--cc=kalyan_t@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nganji@codeaurora.org \
--cc=robdclark@gmail.com \
--cc=seanpaul@chromium.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).