From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: broonie@kernel.org, lgirdwood@gmail.com,
alsa-devel@alsa-project.org, robh+dt@kernel.org,
devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
jcsing.lee@samsung.com, sbkim73@samsung.com,
linux-kernel@vger.kernel.org,
"Bartłomiej Żołnierkiewicz" <b.zolnierkie@samsung.com>,
"Marek Szyprowski" <m.szyprowski@samsung.com>
Subject: Re: [PATCH 7/8] ASoC: samsung: Add missing #sound-dai-cells property documentation
Date: Wed, 07 Feb 2018 17:37:33 +0100 [thread overview]
Message-ID: <5d525a1a-b7a7-8b90-97f9-a59c9e361509@samsung.com> (raw)
In-Reply-To: <CAJKOXPc_NUa2worczHpm4VoTY9Do1-Gq4-711kLz7W0qowTeGQ@mail.gmail.com>
On 02/06/2018 02:02 PM, Krzysztof Kozlowski wrote:
> On Mon, Feb 5, 2018 at 4:44 PM, Sylwester Nawrocki
> <s.nawrocki@samsung.com> wrote:
>> The #sound-dai-cells property might be helpful in selecting primary
>> or secondary CPU DAI and it's already present in i2s nodes for some
>> exynos SoCs so let's add it to the DT binding documentation.
>
> The description above looks like you are documenting existing optional
> property but you added it as a required property.
Actually, it would be better to have it as a required property, but
that could be done with any new device bindings. For the exisitng ones
I will move this property to the "Optional SoC Specific Properties"
paragraph.
--
Regards,
Sylwester
next prev parent reply other threads:[~2018-02-07 16:37 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180205154421epcas2p16072f713ea81f72b3f8230f6a9d412cf@epcas2p1.samsung.com>
2018-02-05 15:43 ` [PATCH 0/8] ASoC: samsung: Add HDMI sound support for tm2 board Sylwester Nawrocki
[not found] ` <CGME20180205154511epcas1p14dccb00b68fdb688f2c427c56e01c052@epcas1p1.samsung.com>
2018-02-05 15:43 ` [PATCH 2/8] ASoC: samsung: i2s: Ensure names of supplied clocks are unique Sylwester Nawrocki
2018-02-06 12:20 ` Krzysztof Kozlowski
2018-02-07 15:20 ` Sylwester Nawrocki
[not found] ` <CGME20180205154516epcas1p39c5977145e7b32879b935087ee3865f8@epcas1p3.samsung.com>
2018-02-05 15:43 ` [PATCH 3/8] ASoC: samsung: i2s: Prevent external abort on exynos5433 I2S1 access Sylwester Nawrocki
2018-02-06 12:22 ` Krzysztof Kozlowski
[not found] ` <CGME20180205154453epcas1p10046e1103497692c86c0899a5ef11781@epcas1p1.samsung.com>
[not found] ` <20180205154403.13520-1-s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2018-02-05 15:43 ` [PATCH 1/8] ASoC: samsung: i2s: Ensure the RCLK rate is properly determined Sylwester Nawrocki
[not found] ` <20180205154403.13520-2-s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2018-02-06 12:15 ` Krzysztof Kozlowski
2018-02-12 12:52 ` Applied "ASoC: samsung: i2s: Ensure the RCLK rate is properly determined" to the asoc tree Mark Brown
2018-02-05 15:43 ` [PATCH 4/8] ASoC: samsung: i2s: Define the parameters list for SAMSUNG_I2S_OPCLK Sylwester Nawrocki
2018-02-06 12:26 ` Krzysztof Kozlowski
2018-02-07 16:23 ` Sylwester Nawrocki
2018-02-12 10:00 ` Krzysztof Kozlowski
2018-02-14 13:29 ` Applied "ASoC: samsung: i2s: Define the parameters list for SAMSUNG_I2S_OPCLK" to the asoc tree Mark Brown
[not found] ` <CGME20180205154524epcas1p35874552d9056837a162dc59d847d1930@epcas1p3.samsung.com>
2018-02-05 15:44 ` [PATCH 5/8] ASoC: samsung: Add support for HDMI audio on TM2 board Sylwester Nawrocki
2018-02-06 12:57 ` Krzysztof Kozlowski
[not found] ` <CGME20180205154529epcas2p3478546ef61294ac06cd9d8ed3d7e12c9@epcas2p3.samsung.com>
2018-02-05 15:44 ` [PATCH 6/8] ASoC: samsung: i2s: Update clock-output-names property documentation Sylwester Nawrocki
2018-02-06 12:59 ` Krzysztof Kozlowski
2018-02-06 12:59 ` Krzysztof Kozlowski
2018-02-09 2:36 ` Rob Herring
[not found] ` <CGME20180205154533epcas2p2d0ed58188cf7f29751c08cd804f6fb0d@epcas2p2.samsung.com>
2018-02-05 15:44 ` [PATCH 7/8] ASoC: samsung: Add missing #sound-dai-cells " Sylwester Nawrocki
2018-02-06 13:02 ` Krzysztof Kozlowski
2018-02-07 16:37 ` Sylwester Nawrocki [this message]
[not found] ` <CGME20180205154537epcas1p10a9a30a574e3f472358e7dacf3cb0489@epcas1p1.samsung.com>
2018-02-05 15:44 ` [PATCH 8/8] ASoC: samsung,tm2-audio DT binding documentation update Sylwester Nawrocki
2018-02-06 13:05 ` Krzysztof Kozlowski
[not found] ` <CAJKOXPeRFgJQpUTeJeYYo+qqAxkT1iZczSJQzRzn3O3bXmvOZA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-02-07 16:31 ` Sylwester Nawrocki
[not found] ` <67a9f473-0eba-b3d0-ae92-5602658b6958-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2018-02-12 9:19 ` Krzysztof Kozlowski
2018-02-09 2:39 ` Rob Herring
2018-02-14 13:29 ` Applied "ASoC: samsung,tm2-audio DT binding documentation update" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d525a1a-b7a7-8b90-97f9-a59c9e361509@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=alsa-devel@alsa-project.org \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jcsing.lee@samsung.com \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=robh+dt@kernel.org \
--cc=sbkim73@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).