From: Rob Herring <robh@kernel.org>
To: Thara Gopinath <thara.gopinath@linaro.org>
Cc: rui.zhang@intel.com, edubezval@gmail.com,
daniel.lezcano@linaro.org, vincent.guittot@linaro.org,
bjorn.andersson@linaro.org, amit.kucheria@verdurent.com,
mark.rutland@arm.com, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: thermal: Introduce monitor-falling parameter to thermal trip point binding
Date: Tue, 01 Oct 2019 17:09:08 -0500 [thread overview]
Message-ID: <5d93ce86.1c69fb81.70b0d.ba56@mx.google.com> (raw)
In-Reply-To: <1568859503-19725-2-git-send-email-thara.gopinath@linaro.org>
On Wed, Sep 18, 2019 at 10:18:20PM -0400, Thara Gopinath wrote:
> Introduce a new binding parameter to thermal trip point description
> to indicate whether the temperature level specified by the trip point
> is monitored for a rise or fall in temperature.
What if it is both?
When do you need this? Seems like you'd always want to monitor both
directions to undo any action done on rising temp. Unless you want a
hysteresis, but this doesn't seem like the best way to implement that.
>
> Signed-off-by: Thara Gopinath <thara.gopinath@linaro.org>
> ---
> Documentation/devicetree/bindings/thermal/thermal.txt | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/thermal/thermal.txt b/Documentation/devicetree/bindings/thermal/thermal.txt
> index ca14ba9..849a2a9 100644
> --- a/Documentation/devicetree/bindings/thermal/thermal.txt
> +++ b/Documentation/devicetree/bindings/thermal/thermal.txt
> @@ -90,6 +90,14 @@ Required properties:
> "critical": Hardware not reliable.
> Type: string
>
> +Optional property:
> +- monitor-falling: Indicate whether the system action is kick
> + Type: boolean started when the temperature falls below or rises
> + above the trip temperature level indicated in
> + "temperature".If true, the trip point is monitored
> + for falling temperature else the trip point is
> + monitored for rising temperature.
> +
> * Cooling device maps
>
> The cooling device maps node is a node to describe how cooling devices
> --
> 2.1.4
>
next prev parent reply other threads:[~2019-10-01 22:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-19 2:18 [PATCH 0/4] thermal: Introduce support for monitoring falling temperatures Thara Gopinath
2019-09-19 2:18 ` [PATCH 1/4] dt-bindings: thermal: Introduce monitor-falling parameter to thermal trip point binding Thara Gopinath
2019-10-01 22:09 ` Rob Herring [this message]
2019-10-09 12:54 ` Thara Gopinath
2019-12-03 16:53 ` Amit Kucheria
2019-09-19 2:18 ` [PATCH 2/4] thermal: Thermal core and sysfs changes needed to support bi-directional monitoring of trip points Thara Gopinath
2019-09-19 2:18 ` [PATCH 3/4] thermal: of-thermal: Extend thermal dt driver to support bi-directional monitoring of a thermal trip point Thara Gopinath
2019-09-19 2:18 ` [PATCH 4/4] thermal: step_wise: Extend thermal step-wise governor to monitor falling temperature Thara Gopinath
2019-11-08 19:54 ` Ram Chandrasekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d93ce86.1c69fb81.70b0d.ba56@mx.google.com \
--to=robh@kernel.org \
--cc=amit.kucheria@verdurent.com \
--cc=bjorn.andersson@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=edubezval@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rui.zhang@intel.com \
--cc=thara.gopinath@linaro.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).