From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBA3BC33CA2 for ; Thu, 9 Jan 2020 11:55:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CC1782075D for ; Thu, 9 Jan 2020 11:55:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729130AbgAILz1 (ORCPT ); Thu, 9 Jan 2020 06:55:27 -0500 Received: from mail-sh.amlogic.com ([58.32.228.43]:58043 "EHLO mail-sh.amlogic.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730049AbgAILz1 (ORCPT ); Thu, 9 Jan 2020 06:55:27 -0500 Received: from [10.18.38.198] (10.18.38.198) by mail-sh.amlogic.com (10.18.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1591.10; Thu, 9 Jan 2020 19:55:50 +0800 Subject: Re: [PATCH v4 1/6] dt-bindings: phy: Add Amlogic A1 USB2 PHY Bindings To: Neil Armstrong , Jerome Brunet , Rob Herring , Greg Kroah-Hartman , Kevin Hilman CC: Yue Wang , , , , , Carlo Caione , Michael Turquette , Stephen Boyd , Martin Blumenstingl , Liang Yang , Jianxin Pan , Qiufang Dai , Jian Hu , Victor Wan , Xingyu Chen References: <1578537045-23260-1-git-send-email-hanjie.lin@amlogic.com> <1578537045-23260-2-git-send-email-hanjie.lin@amlogic.com> From: Hanjie Lin Message-ID: <5f89de05-857e-ac05-b67d-e3ab51ee5363@amlogic.com> Date: Thu, 9 Jan 2020 19:55:50 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.18.38.198] X-ClientProxiedBy: mail-sh.amlogic.com (10.18.11.5) To mail-sh.amlogic.com (10.18.11.5) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2020/1/9 17:21, Neil Armstrong wrote: > On 09/01/2020 03:30, Hanjie Lin wrote: >> Add the Amlogic A1 Family USB2 PHY Bindings >> >> It supports Host mode only. >> >> Signed-off-by: Hanjie Lin >> Signed-off-by: Yue Wang >> --- >> .../bindings/phy/amlogic,meson-a1-usb2-phy.yaml | 56 ++++++++++++++++++++++ >> 1 file changed, 56 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/phy/amlogic,meson-a1-usb2-phy.yaml >> >> diff --git a/Documentation/devicetree/bindings/phy/amlogic,meson-a1-usb2-phy.yaml b/Documentation/devicetree/bindings/phy/amlogic,meson-a1-usb2-phy.yaml >> new file mode 100644 >> index 00000000..dd2e3a6 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/phy/amlogic,meson-a1-usb2-phy.yaml >> @@ -0,0 +1,56 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +# Copyright 2019 Amlogic, Inc >> +%YAML 1.2 >> +--- >> +$id: "http://devicetree.org/schemas/phy/amlogic,meson-a1-usb2-phy.yaml#" >> +$schema: "http://devicetree.org/meta-schemas/core.yaml#" >> + >> +title: Amlogic A1 USB2 PHY >> + >> +maintainers: >> + - Yue Wang >> + >> +properties: >> + compatible: >> + const: amlogic,meson-a1-usb2-phy >> + >> + reg: >> + maxItems: 1 >> + >> + clocks: >> + maxItems: 1 >> + >> + clock-names: >> + items: >> + - const: xtal_usb_phy >> + >> + resets: >> + maxItems: 1 > > Please use reset-names like the g12a bindings. > > Neil > Ok, Neil I will revert reset-names change to keep consistence with G12A in next version. Thanks, Hanjie >> + >> + "#phy-cells": >> + const: 0 >> + >> + power-domains: >> + maxItems: 1 >> + >> +required: >> + - compatible >> + - reg >> + - clocks >> + - clock-names >> + - resets >> + - "#phy-cells" >> + - power-domains >> + >> +examples: >> + - | >> + usb2_phy1: phy@40000 { >> + status = "okay"; >> + compatible = "amlogic,a1-usb2-phy"; >> + clocks = <&clkc_periphs 2>; >> + clock-names = "xtal_usb_phy"; >> + reg = <0x0 0x40000 0x0 0x2000>; >> + resets = <&reset RESET_USBPHY>; >> + #phy-cells = <0>; >> + power-domains = <&pwrc PWRC_USB_ID>; >> + }; >> > > . >