From: Patrice CHOTARD <patrice.chotard@st.com>
To: Rob Herring <robh@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Cc: "arm@kernel.org" <arm@kernel.org>
Subject: Re: [PATCH] arm: dts: stih4xx: Add missing #sound-dai-cells
Date: Mon, 5 Mar 2018 10:37:17 +0000 [thread overview]
Message-ID: <5fca2bc1-1f8e-1760-9e6a-802661af0f7e@st.com> (raw)
In-Reply-To: <20180301202537.30571-4-robh@kernel.org>
Hi Rob
On 03/01/2018 09:25 PM, Rob Herring wrote:
> dtc now gives the following warnings:
>
> arch/arm/boot/dts/stih410-b2120.dtb: Warning (sound_dai_property): /soc/sound/simple-audio-card,dai-link@0/codec: Missing property '#sound-dai-cells' in node /soc/sti-display-subsystem/sti-hdmi@8d04000 or bad phandle (referred from sound-dai[0])
> arch/arm/boot/dts/stih407-b2120.dtb: Warning (sound_dai_property): /soc/sound/simple-audio-card,dai-link@0/codec: Missing property '#sound-dai-cells' in node /soc/sti-display-subsystem/sti-hdmi@8d04000 or bad phandle (referred from sound-dai[0])
> arch/arm/boot/dts/stih410-b2260.dtb: Warning (sound_dai_property): /soc/sound/simple-audio-card,dai-link@0/codec: Missing property '#sound-dai-cells' in node /soc/sti-display-subsystem/sti-hdmi@8d04000 or bad phandle (referred from sound-dai[0])
>
> Add the missing #sound-dai-cells property.
>
> Cc: Patrice Chotard <patrice.chotard@st.com>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> arch/arm/boot/dts/stih407.dtsi | 1 +
> arch/arm/boot/dts/stih410.dtsi | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/stih407.dtsi b/arch/arm/boot/dts/stih407.dtsi
> index 11fdecd9312e..b592ecbe6420 100644
> --- a/arch/arm/boot/dts/stih407.dtsi
> +++ b/arch/arm/boot/dts/stih407.dtsi
> @@ -107,6 +107,7 @@
> compatible = "st,stih407-hdmi";
> reg = <0x8d04000 0x1000>;
> reg-names = "hdmi-reg";
> + #sound-dai-cells = <0>;
> interrupts = <GIC_SPI 106 IRQ_TYPE_NONE>;
> interrupt-names = "irq";
> clock-names = "pix",
> diff --git a/arch/arm/boot/dts/stih410.dtsi b/arch/arm/boot/dts/stih410.dtsi
> index 68b5ff91d6a7..4bcdbbb70a31 100644
> --- a/arch/arm/boot/dts/stih410.dtsi
> +++ b/arch/arm/boot/dts/stih410.dtsi
> @@ -198,6 +198,7 @@
> compatible = "st,stih407-hdmi";
> reg = <0x8d04000 0x1000>;
> reg-names = "hdmi-reg";
> + #sound-dai-cells = <0>;
> interrupts = <GIC_SPI 106 IRQ_TYPE_NONE>;
> interrupt-names = "irq";
> clock-names = "pix",
>
Acked-by: Patrice Chotard <patrice.chotard@st.com>
Will you take this patch in your remotes/Rob_Herring/dtc-update branch ?
Or I can add this patch to my next STi pull-request.
Let me know.
Thanks
Patrice
next prev parent reply other threads:[~2018-03-05 10:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-01 20:25 [PATCH] arm: dts: stih4xx: Add missing #sound-dai-cells Rob Herring
2018-03-05 10:37 ` Patrice CHOTARD [this message]
2018-03-05 13:47 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5fca2bc1-1f8e-1760-9e6a-802661af0f7e@st.com \
--to=patrice.chotard@st.com \
--cc=arm@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).