Re: [PATCH 1/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

From: Randy Dunlap <rdunlap@infradead.org>
To: "Łukasz Stelmach" <l.stelmach@samsung.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Krzysztof Kozlowski" <krzk@kernel.org>,
	"Kukjin Kim" <kgene@kernel.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Russell King" <linux@armlinux.org.uk>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	netdev@vger.kernel.org, devicetree@vger.kernel.org
Cc: m.szyprowski@samsung.com, b.zolnierkie@samsung.com
Subject: Re: [PATCH 1/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver
Date: Tue, 25 Aug 2020 10:19:51 -0700	[thread overview]
Message-ID: <6062dc73-99bc-cde0-26a1-5c40ea1447bd@infradead.org> (raw)
In-Reply-To: <20200825170311.24886-1-l.stelmach@samsung.com>

On 8/25/20 10:03 AM, Łukasz Stelmach wrote:
> diff --git a/drivers/net/ethernet/asix/Kconfig b/drivers/net/ethernet/asix/Kconfig
> new file mode 100644
> index 000000000000..4b127a4a659a
> --- /dev/null
> +++ b/drivers/net/ethernet/asix/Kconfig
> @@ -0,0 +1,20 @@
> +#
> +# Asix network device configuration
> +#
> +
> +config NET_VENDOR_ASIX
> +	bool "Asix devices"

Most vendor entries also have:
	default y
so that they will be displayed in the config menu.

> +	depends on SPI
> +	help
> +	  If you have a network (Ethernet) interface based on a chip from ASIX, say Y
> +
> +if NET_VENDOR_ASIX
> +
> +config SPI_AX88796C
> +	tristate "Asix AX88796C-SPI support"
> +	depends on SPI

That line is redundant (but not harmful).

> +	depends on GPIOLIB
> +	help
> +	  Say Y here if you intend to attach a Asix AX88796C as SPI mode
> +
> +endif # NET_VENDOR_ASIX

-- 
~Randy