From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D918C43334 for ; Wed, 6 Jul 2022 12:57:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232280AbiGFM5l (ORCPT ); Wed, 6 Jul 2022 08:57:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231549AbiGFM5k (ORCPT ); Wed, 6 Jul 2022 08:57:40 -0400 Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 064A81B9 for ; Wed, 6 Jul 2022 05:57:40 -0700 (PDT) Received: by mail-lj1-x236.google.com with SMTP id l7so17607401ljj.4 for ; Wed, 06 Jul 2022 05:57:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=q4qL646g+dPV/1dAguuPRJHbp+riKG5TWuUodAczhNs=; b=bLFBOIfT+FRUTzf2Ks12yMYU4s5V4up/R+PtWt8nbikcgt9NCOKMfeLcdKDhkhwl0v 91rDCPlPZS7N9fZLgJSZrlP6l5RFxWukCoOwWF/sprACqs8TD/XVCx43j+jP8H3lLGTm ZrK3B3B+TDwa/pOdvV2HLijpVWPoPaloRYZU8Fv9moyRt7Kle/xZ8fGEkqi1D4J246oi MqyTtkToqlrktl174U3Gbevdic1nFeZ+s+tmH/PvEoNxP0TXIeQkz7lEdjwpa+eGifdX 0EuUbUfBlUiRf6dAUO9dmot/C/lRCBzbt1gylFiaKKRy/TWVps3SLOE0I7h2k71U94Qq lWLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=q4qL646g+dPV/1dAguuPRJHbp+riKG5TWuUodAczhNs=; b=ABPLlVyGL4oK5t5Vc93q/Tt6OvWYoAOIFOFGD0vyd02jrqj72Zk6X7f0b1dbwvAvmC jaD7e2/4Nz5ZWmLJNc3RlE+Rymt7AeyxsL8jGp4X3jqcxCBNzHWXP5hb7tC8yF9hBKgW hGmI122VIcD5KSupei5aoEKutof7GIxyBP18SOpdEooMnjFIIKj9azHvjR7DOx4SVDa2 N4NvGvxkR22GNQTdd3YzDScIfIY08Muy0sXWJTb9W0dAxI/pIC0K5L6iP7/hm93Z4Lx+ ZiyMoguUvFEAb3FglWRAR4TCwit+bMFeinK/Tt54uq/hj4SsnUADlKzngv4ZnWfPGtki cnpQ== X-Gm-Message-State: AJIora/nOivKu5psVyc3dB5lDgkrMWO17AuJ7X3LuFjmQfEq55W76cOk jBvNyI6SRxTiDhFmAG1LZZBqdg== X-Google-Smtp-Source: AGRyM1sxSzE4RVFE/z7AFhVcj2m8K5D5n91eVpcb8YK/KiiDH7f5ktCSCDvDHHo9EBFmBkwiBIRyzg== X-Received: by 2002:a2e:3215:0:b0:25a:93bb:f801 with SMTP id y21-20020a2e3215000000b0025a93bbf801mr23378514ljy.489.1657112258181; Wed, 06 Jul 2022 05:57:38 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id c25-20020ac24159000000b00478f174c598sm6268148lfi.95.2022.07.06.05.57.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Jul 2022 05:57:37 -0700 (PDT) Message-ID: <6130f39d-21b6-145d-8e6b-26c2f4b89e88@linaro.org> Date: Wed, 6 Jul 2022 15:57:36 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 6/7] dt-bindings: msm: dsi: Add missing clocks to 28nm DSI PHY YAML Content-Language: en-GB To: Bryan O'Donoghue , robdclark@gmail.com, quic_abhinavk@quicinc.com, sean@poorly.run, airlied@linux.ie, daniel@ffwll.ch, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: quic_mkrishn@quicinc.com, swboyd@chromium.org, bjorn.andersson@linaro.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org References: <20220630120845.3356144-1-bryan.odonoghue@linaro.org> <20220630120845.3356144-7-bryan.odonoghue@linaro.org> From: Dmitry Baryshkov In-Reply-To: <20220630120845.3356144-7-bryan.odonoghue@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 30/06/2022 15:08, Bryan O'Donoghue wrote: > Add in missing clock and clock-names declarations to the 28nm DSI PHY. > When converting from .txt to .yaml we missed these. > > Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings") > Signed-off-by: Bryan O'Donoghue I checked the schema. I think you can drop this patch. The issue that you probably saw with apq8064 should be solved in the dtsi, not in the schema. > --- > .../bindings/display/msm/dsi-phy-28nm.yaml | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml > index 3d8540a06fe22..9ecd513d93661 100644 > --- a/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml > +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-28nm.yaml > @@ -19,6 +19,21 @@ properties: > - qcom,dsi-phy-28nm-lp > - qcom,dsi-phy-28nm-8960 > > + clocks: > + minItems: 1 > + maxItems: 2 > + > + clock-names: > + items: > + - const: iface > + description: AHB clock > + - const: iface_clk > + description: AHB clock > + - const: ref > + description: Block reference clock > + minItems: 1 > + maxItems: 2 > + > reg: > items: > - description: dsi pll register set > @@ -36,6 +51,8 @@ properties: > > required: > - compatible > + - clocks > + - clock-names > - reg > - reg-names > - vddio-supply -- With best wishes Dmitry