From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Dylan Van Assche <me@dylanvanassche.be>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Konrad Dybcio <konrad.dybcio@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org
Subject: Re: [PATCH 2/4] dts: arm64: qcom: sdm845: add SLPI FastRPC support
Date: Sun, 26 Mar 2023 10:56:31 +0200 [thread overview]
Message-ID: <61881229-cd91-cfb3-be2b-51d516f8473c@linaro.org> (raw)
In-Reply-To: <20230325135114.21688-3-me@dylanvanassche.be>
On 25/03/2023 14:51, Dylan Van Assche wrote:
> Qualcomm SDM845 SoC features a SLPI DSP which uses FastRPC through
> an allocated memory region to load files from the host filesystem
> such as sensor configuration files.
>
> Add a FastRPC node at /dev/fastrpc-sdsp and a DMA region, similar to
> downstream, to allow userspace to communicate with the SLPI via the
> FastRPC interface for initializing the sensors on the SLPI.
>
> Signed-off-by: Dylan Van Assche <me@dylanvanassche.be>
> ---
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index 8dcfe6293762..5a6c7d00719b 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -878,6 +878,14 @@ mdata_mem: mpss-metadata {
> size = <0 0x4000>;
> no-map;
> };
> +
> + fastrpc_mem: fastrpc {
> + compatible = "shared-dma-pool";
> + reusable;
> + alloc-ranges = <0 0x00000000 0 0xffffffff>;
> + alignment = <0 0x400000>;
> + size = <0 0x1000000>;
> + };
> };
>
> adsp_pas: remoteproc-adsp {
> @@ -3344,6 +3352,22 @@ glink-edge {
> label = "dsps";
> qcom,remote-pid = <3>;
> mboxes = <&apss_shared 24>;
> +
> + fastrpc {
> + compatible = "qcom,fastrpc";
> + qcom,glink-channels = "fastrpcglink-apps-dsp";
> + label = "sdsp";
> + qcom,non-secure-domain;
> + qcom,vmids = <0x3 0xF 0x5 0x6>;
> + memory-region = <&fastrpc_mem>;
> + qcom,assign-all-mem;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + compute-cb {
Does not look like you tested the DTS against bindings. Please run `make
dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst
for instructions).
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-03-26 8:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-25 13:51 [PATCH 0/4] Qualcomm SDM845 SLPI DSP enablement Dylan Van Assche
2023-03-25 13:51 ` [PATCH 1/4] dts: arm64: qcom: sdm845: add SLPI remoteproc Dylan Van Assche
2023-03-26 8:56 ` Krzysztof Kozlowski
2023-03-25 13:51 ` [PATCH 2/4] dts: arm64: qcom: sdm845: add SLPI FastRPC support Dylan Van Assche
2023-03-25 16:16 ` kernel test robot
2023-03-26 8:56 ` Krzysztof Kozlowski [this message]
2023-03-25 13:51 ` [PATCH 3/4] dts: arm64: qcom: sdm845-oneplus: enable SLPI Dylan Van Assche
2023-03-26 8:56 ` Krzysztof Kozlowski
2023-03-25 13:51 ` [PATCH 4/4] dts: arm64: qcom: sdm845-shift-axolotl: " Dylan Van Assche
2023-03-26 8:57 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61881229-cd91-cfb3-be2b-51d516f8473c@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@dylanvanassche.be \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).