From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Conor.Dooley@microchip.com, green.wan@sifive.com,
vkoul@kernel.org, robh+dt@kernel.org, krzk+dt@kernel.org,
paul.walmsley@sifive.com, palmer@dabbelt.com,
aou@eecs.berkeley.edu, geert@linux-m68k.org,
alexandre.ghiti@canonical.com, palmer@sifive.com,
dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] riscv: dts: sifive: fu540-c000: align dma node name with dtschema
Date: Tue, 19 Apr 2022 12:50:30 +0200 [thread overview]
Message-ID: <61923e45-6594-6dfc-5e2f-e808af99e7c1@linaro.org> (raw)
In-Reply-To: <03e28a55-d3bd-f3e1-f418-557306d65505@microchip.com>
On 19/04/2022 12:45, Conor.Dooley@microchip.com wrote:
> On 19/04/2022 10:09, Krzysztof Kozlowski wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>
>> On 18/03/2022 17:20, Krzysztof Kozlowski wrote:
>>> Fixes dtbs_check warnings like:
>>>
>>> dma@3000000: $nodename:0: 'dma@3000000' does not match '^dma-controller(@.*)?$'
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
>>> ---
>>> arch/riscv/boot/dts/sifive/fu540-c000.dtsi | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Any comments here?
>
> Not sure that this one is actually needed Krzysztof, Zong Li has a fix
> for this in his series of fixes for the sifive pdma:
> https://lore.kernel.org/linux-riscv/edd72c0cca1ebceddc032ff6ec2284e3f48c5ad3.1648461096.git.zong.li@sifive.com/
>
> Maybe you could add your review to his version?
Zong's Li patch was sent 10 days after my patch... [1] Why riscv DTS
patches take so much time to pick up?
[1]
https://lore.kernel.org/linux-devicetree/20220318162044.169350-2-krzysztof.kozlowski@canonical.com/
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-04-19 10:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-18 16:20 [PATCH 1/2] dt-bindings: dmaengine: sifive,fu540-c000: include generic schema Krzysztof Kozlowski
2022-03-18 16:20 ` [PATCH 2/2] riscv: dts: sifive: fu540-c000: align dma node name with dtschema Krzysztof Kozlowski
2022-04-19 10:09 ` Krzysztof Kozlowski
2022-04-19 10:45 ` Conor.Dooley
2022-04-19 10:50 ` Krzysztof Kozlowski [this message]
2022-04-19 10:57 ` Conor.Dooley
2022-04-19 10:59 ` Krzysztof Kozlowski
2022-04-19 12:18 ` Zong Li
2022-03-21 18:55 ` [PATCH 1/2] dt-bindings: dmaengine: sifive,fu540-c000: include generic schema Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61923e45-6594-6dfc-5e2f-e808af99e7c1@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Conor.Dooley@microchip.com \
--cc=alexandre.ghiti@canonical.com \
--cc=aou@eecs.berkeley.edu \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=green.wan@sifive.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=palmer@sifive.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).