From: Florian Fainelli <f.fainelli@gmail.com>
To: Ray Jui <ray.jui@broadcom.com>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
Subject: Re: [PATCH 1/2] dt-bindings: soc: Add binding doc for iProc IDM device
Date: Thu, 5 Dec 2019 16:09:48 -0800 [thread overview]
Message-ID: <62254bbb-168e-c0ad-a72d-bd659a2c23fa@gmail.com> (raw)
In-Reply-To: <20191202233127.31160-2-ray.jui@broadcom.com>
On 12/2/19 3:31 PM, Ray Jui wrote:
> Add binding document for iProc based IDM devices.
>
> Signed-off-by: Ray Jui <ray.jui@broadcom.com>
Looks good to me, it's 2019, nearly 2020, maybe make this a YAML
compatible binding since it is a new one?
> ---
> .../bindings/soc/bcm/brcm,iproc-idm.txt | 44 +++++++++++++++++++
> 1 file changed, 44 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,iproc-idm.txt
>
> diff --git a/Documentation/devicetree/bindings/soc/bcm/brcm,iproc-idm.txt b/Documentation/devicetree/bindings/soc/bcm/brcm,iproc-idm.txt
> new file mode 100644
> index 000000000000..388c6b036d7e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/bcm/brcm,iproc-idm.txt
> @@ -0,0 +1,44 @@
> +Broadcom iProc Interconnect Device Management (IDM) device
> +
> +The Broadcom iProc IDM device allows control and monitoring of ASIC internal
> +bus transactions. Most importantly, it can be configured to detect bus
> +transaction timeout. In such case, critical information such as transaction
> +address that caused the error, bus master ID of the transaction that caused
> +the error, and etc., are made available from the IDM device.
> +
> +-------------------------------------------------------------------------------
> +
> +Required properties for IDM device node:
> +- compatible: must be "brcm,iproc-idm"
> +- reg: base address and length of the IDM register space
> +- interrupt: IDM interrupt number
> +- brcm,iproc-idm-bus: IDM bus string
> +
> +Optional properties for IDM device node:
> +- brcm,iproc-idm-elog: phandle to the device node of the IDM logging device
> +
> +-------------------------------------------------------------------------------
> +
> +Required properties for IDM error logging device node:
> +- compatible: must be "brcm,iproc-idm-elog";
> +- reg: base address and length of reserved memory location where IDM error
> + events can be saved
> +
> +-------------------------------------------------------------------------------
> +
> +Example:
> +
> +idm {
> + idm-elog {
> + compatible = "brcm,iproc-idm-elog";
> + reg = <0x8f221000 0x1000>;
> + };
> +
> + idm-mhb-paxc-axi {
> + compatible = "brcm,iproc-idm";
> + reg = <0x60406900 0x200>;
> + interrupt = <GIC_SPI 516 IRQ_TYPE_LEVEL_HIGH>;
> + brcm,iproc-idm-bus = "idm-mhb-paxc-axi";
> + brcm,iproc-idm-elog = <&idm-elog>;
> + };
> +};
>
--
Florian
next prev parent reply other threads:[~2019-12-06 0:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-02 23:31 [PATCH 0/2] Add iProc IDM device support Ray Jui
2019-12-02 23:31 ` [PATCH 1/2] dt-bindings: soc: Add binding doc for iProc IDM device Ray Jui
2019-12-06 0:09 ` Florian Fainelli [this message]
2019-12-07 1:09 ` Ray Jui
2019-12-13 23:50 ` Rob Herring
2019-12-14 0:00 ` Florian Fainelli
2019-12-16 15:52 ` Rob Herring
2019-12-02 23:31 ` [PATCH 2/2] soc: bcm: iproc: Add Broadcom iProc IDM driver Ray Jui
2019-12-06 0:22 ` Florian Fainelli
2019-12-07 1:15 ` Ray Jui
2019-12-07 17:52 ` Florian Fainelli
2019-12-09 18:05 ` Ray Jui
2019-12-07 17:39 ` [PATCH 0/2] Add iProc IDM device support Marc Zyngier
2019-12-09 18:02 ` Ray Jui
2019-12-09 18:36 ` Marc Zyngier
2019-12-10 0:19 ` Ray Jui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62254bbb-168e-c0ad-a72d-bd659a2c23fa@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=ray.jui@broadcom.com \
--cc=rayagonda.kokatanur@broadcom.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).