From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrzej Hajda Subject: Re: [PATCH 2/2] arm64: dts: exynos: add OF graph between USB-PHY and MUIC Date: Thu, 01 Feb 2018 09:19:39 +0100 Message-ID: <6581962f-3552-2891-e6b3-b2f7c0018c93@samsung.com> References: <20180131155718.5237-1-a.hajda@samsung.com> <20180131155718.5237-3-a.hajda@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-reply-to: Content-language: en-US Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Krzysztof Kozlowski Cc: "open list:DESIGNWARE USB3 DRD IP DRIVER" , Bartlomiej Zolnierkiewicz , Marek Szyprowski , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Felipe Balbi , Greg Kroah-Hartman , Inki Dae , Rob Herring , Mark Rutland , Chanwoo Choi , Laurent Pinchart , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On 01.02.2018 08:50, Krzysztof Kozlowski wrote: > On Wed, Jan 31, 2018 at 4:57 PM, Andrzej Hajda wrote: >> OF graph describes USB data lanes between USB-PHY and respective MUIC. >> Since graph is present and DWC driver can use it to get extcon, obsolete >> extcon property can be removed. >> >> Signed-off-by: Andrzej Hajda >> --- >> arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 18 +++++++++++++++++- >> 1 file changed, 17 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi >> index 427ff861b441..b20b42659206 100644 >> --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi >> +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi >> @@ -828,6 +828,17 @@ >> }; >> }; >> }; >> + >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + port@0 { >> + reg = <0>; >> + muic_to_usb: endpoint { >> + remote-endpoint = <&usb_to_muic>; >> + }; >> + }; >> }; >> }; >> >> @@ -1242,12 +1253,17 @@ >> >> &usbdrd_dwc3 { >> dr_mode = "otg"; >> - extcon = <&muic>; > Look ok for me. > > Does this depend on #1 patch for DWC? Yes, it depends. #1 adds code to find extcon using graph, without it dwc3 won't be able to work in dual-role mode. Alternatively, I could split this patch into two parts: 2a. adding graph bindings. 2b. removing extcon property. In such case only 2b depends on #1. Regards Andrzej > > Best regards, > Krzysztof > > > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html