From: Arnd Bergmann <arnd@arndb.de>
To: suman-tripathi <stripathi@apm.com>
Cc: olof@lixom.net, tj@kernel.org, linux-ide@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
mlangsdo@redhat.com, jcm@redhat.com, patches@apm.com
Subject: Re: [PATCH] ata: ahci_platform: Add ACPI support for APM X-Gene AHCI controller v3 hardware.
Date: Thu, 16 Jun 2016 08:54:09 +0200 [thread overview]
Message-ID: <6691907.FIx2xYmxSs@wuerfel> (raw)
In-Reply-To: <1466034240-22694-1-git-send-email-stripathi@apm.com>
On Wednesday, June 15, 2016 5:44:00 PM CEST suman-tripathi wrote:
> This patch adds ACPI support for APM X-Gene AHCI controller in
> ahci_platform driver for v3 hardware. APM X-Gene AHCI controller
> v3 hardware is fully compliant with ahci_platform driver and requires
> no workaround quirk.
>
> Signed-off-by: Suman Tripathi <stripathi@apm.com>
> ---
> drivers/ata/ahci_platform.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/ata/ahci_platform.c b/drivers/ata/ahci_platform.c
> index 62a04c8..3395baf 100644
> --- a/drivers/ata/ahci_platform.c
> +++ b/drivers/ata/ahci_platform.c
> @@ -86,6 +86,7 @@ MODULE_DEVICE_TABLE(of, ahci_of_match);
>
> static const struct acpi_device_id ahci_acpi_match[] = {
> { ACPI_DEVICE_CLASS(PCI_CLASS_STORAGE_SATA_AHCI, 0xffffff) },
> + { "APMC0D33", 0},
> {},
> };
> MODULE_DEVICE_TABLE(acpi, ahci_acpi_match);
>
Doesn't the ACPI_DEVICE_CLASS entry take care of this? I thought it had been
added specifically for this purpose. It doesn't seem right to add vendor
specific entries for generic hardware in each generic driver.
Arnd
next prev parent reply other threads:[~2016-06-16 6:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <stripathi@apm.com>
2016-06-15 23:44 ` [PATCH] ata: ahci_platform: Add ACPI support for APM X-Gene AHCI controller v3 hardware suman-tripathi
2016-06-16 6:54 ` Arnd Bergmann [this message]
2016-06-21 18:08 ` Suman Tripathi
[not found] ` <CAOHikRCB4c79okd0q3=Lqwk7LKwZ6EDnWfHRH_oXokrB4PHcyw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-06-21 23:31 ` Suman Tripathi
2016-06-22 10:18 ` Arnd Bergmann
2016-07-05 9:07 ` Graeme Gregory
2016-07-05 18:01 ` Suman Tripathi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6691907.FIx2xYmxSs@wuerfel \
--to=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=jcm@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=mlangsdo@redhat.com \
--cc=olof@lixom.net \
--cc=patches@apm.com \
--cc=stripathi@apm.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).