From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D248EC04E30 for ; Tue, 10 Dec 2019 00:19:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A4FEB20828 for ; Tue, 10 Dec 2019 00:19:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="SwCeGizo" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727213AbfLJATN (ORCPT ); Mon, 9 Dec 2019 19:19:13 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:38442 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727306AbfLJATM (ORCPT ); Mon, 9 Dec 2019 19:19:12 -0500 Received: by mail-wm1-f66.google.com with SMTP id p17so1208098wmi.3 for ; Mon, 09 Dec 2019 16:19:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=7SQNMrH3FWLOHx8P5+nc/Y/vfFqnbuXwKn95w6eAgao=; b=SwCeGizoute6aM8WBuWO5aqLXZvlBE9LQkiA01eogphBriUxjYU5BxsC+cYroUmZE8 tqi0jLBqvVR7I87fm/QGOxMkRFn8sICZntbBTvgffbv8ooc6M63WJ+CKxFd+/tP/SSSK UQucOxuaOq96ykIy8qxsmP526hqGxid+/SVSw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7SQNMrH3FWLOHx8P5+nc/Y/vfFqnbuXwKn95w6eAgao=; b=URDSWGRh1ViKoudJXkrrsyEWCQogpG14q2axEjyHWJ90H4F1jrYP+t21FNEKo/kqiy fFRjarSBvLRZAz7nmqqSAibKuhgLu4Hg21ZvRbYN8ngQGza/prDxbJ7sw6eeUK938sRB qAbro6z0SMIfLcQcfEha8z3vbR4NCHq5/MASyd3jxojXeiXy2GL/JVip3MWIKEstASnX JOMT3AIe88P52cp7r6Ya/7qBg/OnPmAaaF2be1zHNUemUg163j8nppxDTR3p9wTbLlAa RcSNMr/fjZt+2COtyr+thEFzXbZg2LnCZr4I1LQSvLQLanLXoOkB97KQPiBG0B/c1F6s b7fg== X-Gm-Message-State: APjAAAUxflyG+MXex6g6ok57RpL/nAmqBT8hJZJwLwIax9jum5HQLifG bQ5Abn9RZo53dewZHm5J4SdC0Q== X-Google-Smtp-Source: APXvYqxzOk0JdZlf+46jK9Xp8GhKR0K8LVhI3QZ5He8BwBXVH+OKWm/me7LNc/zlPupDn98PkoD4/Q== X-Received: by 2002:a1c:a750:: with SMTP id q77mr1645652wme.76.1575937149108; Mon, 09 Dec 2019 16:19:09 -0800 (PST) Received: from rj-aorus.ric.broadcom.com ([192.19.228.250]) by smtp.gmail.com with ESMTPSA id b17sm1229259wrp.49.2019.12.09.16.19.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Dec 2019 16:19:07 -0800 (PST) Subject: Re: [PATCH 0/2] Add iProc IDM device support To: Marc Zyngier Cc: Rob Herring , Mark Rutland , devicetree@vger.kernel.org, Rayagonda Kokatanur , linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org References: <20191202233127.31160-1-ray.jui@broadcom.com> <20191207173914.353f768d@why> <20191209183636.6d708bfd@why> From: Ray Jui Message-ID: <69ff3b8a-e99e-7128-a02a-1cac1da3eb66@broadcom.com> Date: Mon, 9 Dec 2019 16:19:02 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.1 MIME-Version: 1.0 In-Reply-To: <20191209183636.6d708bfd@why> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 12/9/19 10:36 AM, Marc Zyngier wrote: > On Mon, 9 Dec 2019 10:02:53 -0800 > Ray Jui wrote: > >> On 12/7/19 9:39 AM, Marc Zyngier wrote: >>> On Mon, 2 Dec 2019 15:31:25 -0800 >>> Ray Jui wrote: >>> >>>> The Broadcom iProc IDM device allows control and monitoring of ASIC internal >>>> bus transactions. Most importantly, it can be configured to detect bus >>>> transaction timeout. In such case, critical information such as transaction >>>> address that caused the error, bus master ID of the transaction that caused >>>> the error, and etc., are made available from the IDM device. >>> >>> This seems to have many of the features of an EDAC device reporting >>> uncorrectable errors. >>> >>> Is there any reason why it is not implemented as such? >>> >>> Thanks, >>> >>> M. >>> >> >> I thought EDAC errors (in fact, in our case, that's fatal rather than >> uncorrectable) are mostly for DDR. Is my understanding incorrect? > > No, they are for HW errors in general. There is no real limitation of > scope, as far as I understand. Recently, the Annapurna guys came up > with a similar HW block, and were convinced to make it an EDAC device. > > See [1] for details. > > Thanks, > > M. > > [1] https://lore.kernel.org/linux-devicetree/1570707681-865-1-git-send-email-talel@amazon.com/ > Ah I see. It looks like memory controllers are the primary devices supported by EDAC. In addition to that, EDAC also does seem to provide a generic data structure to support other types of HW devices and error events. I'll look into this and get back. Thanks, Ray