From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Wahren <stefan.wahren@i2se.com>
Subject: Re: [PATCH v3 4/4] ARM: dts: bcm2837-rpi-3-b: add GPIO expander
Date: Wed, 17 Jan 2018 09:30:09 +0100
Message-ID: <6c07ab6a-a2c6-284e-6205-58d2512d0256@i2se.com>
References: <cover.1516105893.git.baruch@tkos.co.il>
 <8ba2147dc08bb50a65b49ca2142f7710e1635d20.1516105893.git.baruch@tkos.co.il>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <linux-gpio-owner@vger.kernel.org>
In-Reply-To: <8ba2147dc08bb50a65b49ca2142f7710e1635d20.1516105893.git.baruch@tkos.co.il>
Content-Language: en-US
Sender: linux-gpio-owner@vger.kernel.org
To: Baruch Siach <baruch@tkos.co.il>, Dave Stevenson <dave.stevenson@raspberrypi.org>, Eric Anholt <eric@anholt.net>, Linus Walleij <linus.walleij@linaro.org>
Cc: devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, Michael Zoran <mzoran@crowfest.net>, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Rob Herring <robh+dt@kernel.org>, Frank Rowand <frowand.list@gmail.com>
List-Id: devicetree@vger.kernel.org

Hi Linus,
hi Eric,


Am 16.01.2018 um 13:45 schrieb Baruch Siach:
> Add a description of the RPi3 GPIO expander that the VC4 firmware controls.
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> v3:
>    * List GPIO names one per line.
>
> v2:
>    * Move GPIO expander node out of the soc container
>    * Rename compatible string
>    * Add gpio-line-names property
> ---
>   arch/arm/boot/dts/bcm2837-rpi-3-b.dts | 16 ++++++++++++++++
>   1 file changed, 16 insertions(+)
>
> diff --git a/arch/arm/boot/dts/bcm2837-rpi-3-b.dts b/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
> index b44b3b5af00d..8cd93425ffe3 100644
> --- a/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
> +++ b/arch/arm/boot/dts/bcm2837-rpi-3-b.dts
> @@ -23,6 +23,22 @@
>   			gpios = <&gpio 47 0>;
>   		};
>   	};

i noticed that this patch conflicts with my patch ("ARM: dts: bcm283x: 
Use GPIO polarity defines consistently") in linux-next.

How should we proceed?

> +
> +	expgpio: gpio-expander {
> +		compatible = "raspberrypi,firmware-gpio";
> +		gpio-controller;
> +		#gpio-cells = <2>;
> +		firmware = <&firmware>;
> +		gpio-line-names = "BT_ON",
> +				  "WL_ON",
> +				  "STATUS_LED",
> +				  "LAN_RUN",
> +				  "HPD_N",
> +				  "CAM_GPIO0",
> +				  "CAM_GPIO1",
> +				  "PWR_LOW_N";
> +		status = "okay";
> +	};
>   };
>   
>   /* uart0 communicates with the BT module */