From: Pramod Kumar <pramod.kumar@broadcom.com>
To: Florian Fainelli <f.fainelli@gmail.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
"David S. Miller" <davem@davemloft.net>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Jon Mason <jonmason@broadcom.com>
Subject: RE: [PATCH v4 7/7] phy: Add Northstar2 PCI Phy support
Date: Tue, 7 Jun 2016 17:55:55 +0530 [thread overview]
Message-ID: <6ed8bf6ba5de670588715d55ca42d631@mail.gmail.com> (raw)
In-Reply-To: <5755C404.3080502@gmail.com>
Hi Florian,
> -----Original Message-----
> From: Florian Fainelli [mailto:f.fainelli@gmail.com]
> Sent: 07 June 2016 00:12
> To: Pramod Kumar; Rob Herring; Pawel Moll; Mark Rutland; Ian Campbell;
> Kumar Gala; Catalin Marinas; Will Deacon; Kishon Vijay Abraham I; David S.
> Miller
> Cc: devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; bcm-
> kernel-feedback-list@broadcom.com; linux-kernel@vger.kernel.org;
> netdev@vger.kernel.org; Jon Mason
> Subject: Re: [PATCH v4 7/7] phy: Add Northstar2 PCI Phy support
>
> On 06/06/2016 05:41 AM, Pramod Kumar wrote:
> > Add PCI Phy support for Broadcom Northstar2 SoCs. This driver uses
> > the interface from the iproc mdio mux driver to enable the devices
> > respective phys.
> >
> > Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> > Signed-off-by: Jon Mason <jonmason@broadcom.com>
> > Signed-off-by: Pramod Kumar <pramod.kumar@broadcom.com>
> > ---
> > drivers/phy/Kconfig | 8 +++
> > drivers/phy/Makefile | 2 +-
> > drivers/phy/phy-bcm-ns2-pcie.c | 115
> > +++++++++++++++++++++++++++++++++++++++++
> > 3 files changed, 124 insertions(+), 1 deletion(-) create mode 100644
> > drivers/phy/phy-bcm-ns2-pcie.c
> >
> > diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig index
> > b869b98..01fb93b 100644
> > --- a/drivers/phy/Kconfig
> > +++ b/drivers/phy/Kconfig
> > @@ -434,4 +434,12 @@ config PHY_CYGNUS_PCIE
> >
> > source "drivers/phy/tegra/Kconfig"
> >
> > +config PHY_NS2_PCIE
> > + tristate "Broadcom Northstar2 PCIe PHY driver"
> > + depends on OF && MDIO_BUS_MUX_BCM_IPROC
> > + select GENERIC_PHY
> > + default ARCH_BCM_IPROC
>
> Are not you missing a dependency on PHYLIB too to provide
> mdio_module_register() etc. (at least make it build)?
>
This depends on MDIO_BUS_MUX_BCM_IPROC which itself depends on PHYLIB. Hence
I don't think We need to take care of this here.
> --
> Florian
Regards,
Pramod
next prev parent reply other threads:[~2016-06-07 12:25 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 12:41 [PATCH v4 0/7] Add MDIO bus multiplexer support for iProc SoCs Pramod Kumar
2016-06-06 12:41 ` [PATCH v4 1/7] mdio: mux: Enhanced MDIO mux framework for integrated multiplexers Pramod Kumar
2016-06-06 14:17 ` Andrew Lunn
2016-06-06 18:33 ` Florian Fainelli
2016-06-06 12:41 ` [PATCH v4 2/7] binding: Make "mdio-parent-bus" property from mandatory to optional Pramod Kumar
2016-06-06 14:17 ` Andrew Lunn
2016-06-08 19:39 ` Rob Herring
2016-06-06 12:41 ` [PATCH v4 3/7] binding: mdio-mux: Add DT binding doc for Broadcom MDIO bus multiplexer Pramod Kumar
2016-06-06 18:36 ` Florian Fainelli
2016-06-07 11:57 ` Pramod Kumar
2016-06-08 19:40 ` Rob Herring
[not found] ` <1465216900-11755-4-git-send-email-pramod.kumar-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2016-06-08 19:43 ` Rob Herring
2016-06-06 12:41 ` [PATCH v4 4/7] dt: mdio-mux: Add mdio multiplexer driver node Pramod Kumar
2016-06-06 18:37 ` Florian Fainelli
2016-06-10 4:24 ` Pramod Kumar
2016-06-06 12:41 ` [PATCH v4 5/7] net: mdio-mux: Add MDIO mux driver for iProc SoCs Pramod Kumar
[not found] ` <1465216900-11755-6-git-send-email-pramod.kumar-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2016-06-06 14:15 ` Andrew Lunn
2016-06-06 18:42 ` Florian Fainelli
2016-06-06 12:41 ` [PATCH v4 6/7] binding: PHY: Binding doc for NS2 PCIe PHYs Pramod Kumar
2016-06-06 12:41 ` [PATCH v4 7/7] phy: Add Northstar2 PCI Phy support Pramod Kumar
[not found] ` <1465216900-11755-8-git-send-email-pramod.kumar-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2016-06-06 18:42 ` Florian Fainelli
2016-06-07 12:25 ` Pramod Kumar [this message]
2016-06-30 12:16 ` Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ed8bf6ba5de670588715d55ca42d631@mail.gmail.com \
--to=pramod.kumar@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jonmason@broadcom.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).