From: Jyri Sarha <jsarha@ti.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: <dri-devel@lists.freedesktop.org>, <tony@atomide.com>,
<sam@ravnborg.org>, <robh+dt@kernel.org>,
<devicetree@vger.kernel.org>, <linux-omap@vger.kernel.org>,
<tomi.valkeinen@ti.com>, <peter.ujfalusi@ti.com>,
<bparrot@ti.com>
Subject: Re: [PATCH 2/2] dt-bindings: display: Add obsolete note to "ti,tilcdc,panel" binding
Date: Thu, 5 Dec 2019 11:17:53 +0200 [thread overview]
Message-ID: <6f1d616d-e471-5175-c291-034d6afe7509@ti.com> (raw)
In-Reply-To: <20191205084626.GB4734@pendragon.ideasonboard.com>
On 05/12/2019 10:46, Laurent Pinchart wrote:
> Hi Jyri,
>
> Thank you for the patch.
>
> On Wed, Dec 04, 2019 at 07:53:11PM +0200, Jyri Sarha wrote:
>> The "ti,tilcdc,panel" binding should not be used anymore, since tilcdc
>> is fully capable of using generic drm panels like panel-simple and
>> panel-common binding. However, the obsolete binding is still widely
>> used in many mainline supported platforms that I do not have access to
>> and who knows how many custom platforms. So I am afraid we have to
>> keep the old bundled tilcdc panel driver around.
>>
>> Signed-off-by: Jyri Sarha <jsarha@ti.com>
>> ---
>> Documentation/devicetree/bindings/display/tilcdc/panel.txt | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/display/tilcdc/panel.txt b/Documentation/devicetree/bindings/display/tilcdc/panel.txt
>> index 808216310ea2..54963f9173cc 100644
>> --- a/Documentation/devicetree/bindings/display/tilcdc/panel.txt
>> +++ b/Documentation/devicetree/bindings/display/tilcdc/panel.txt
>> @@ -1,5 +1,11 @@
>> Device-Tree bindings for tilcdc DRM generic panel output driver
>>
>> +NOTE: This binding (and the related driver) is obsolete and should not
>> + be used anymore. Please refer to drm panel-common binding (and
>> + to a generic drm panel driver like panel-simple).
>> + Documentation/devicetree/bindings/display/panel/panel-common.yaml
>> + (drivers/gpu/drm/panel/panel-simple.c)
>> +
>
> How about adding a WARN_ON() in the code when this binding is used ?
> This could help getting those platforms converted.
>
I don't see why not, I'll add that.
Thanks
Jyro
>> Required properties:
>> - compatible: value should be "ti,tilcdc,panel".
>> - panel-info: configuration info to configure LCDC correctly for the panel
>
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
prev parent reply other threads:[~2019-12-05 9:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-04 17:53 [PATCH 0/2] drm/tilcdc: Remove "ti,tilcdc,tfp410" and mark "ti,tilcdc,panel" obsolete Jyri Sarha
2019-12-04 17:53 ` [PATCH 1/2] drm/tilcdc: Remove obsolete bundled tilcdc tfp410 driver Jyri Sarha
2019-12-05 8:45 ` Laurent Pinchart
2019-12-04 17:53 ` [PATCH 2/2] dt-bindings: display: Add obsolete note to "ti,tilcdc,panel" binding Jyri Sarha
2019-12-05 7:06 ` H. Nikolaus Schaller
2019-12-05 7:13 ` Jyri Sarha
2019-12-05 8:46 ` Laurent Pinchart
2019-12-05 9:17 ` Jyri Sarha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f1d616d-e471-5175-c291-034d6afe7509@ti.com \
--to=jsarha@ti.com \
--cc=bparrot@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=tomi.valkeinen@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).