From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA0C7C433E1 for ; Thu, 30 Jul 2020 16:33:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 49E202082E for ; Thu, 30 Jul 2020 16:33:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728412AbgG3Qdx (ORCPT ); Thu, 30 Jul 2020 12:33:53 -0400 Received: from foss.arm.com ([217.140.110.172]:42294 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728473AbgG3Qdx (ORCPT ); Thu, 30 Jul 2020 12:33:53 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 38B3D1FB; Thu, 30 Jul 2020 09:33:53 -0700 (PDT) Received: from [10.37.12.83] (unknown [10.37.12.83]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CF01C3F66E; Thu, 30 Jul 2020 09:33:51 -0700 (PDT) Subject: Re: [RFC PATCH 14/14] dts: bindings: coresight: ETMv4.4 system register access only units To: mathieu.poirier@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, mike.leach@linaro.org, coresight@lists.linaro.org, robh+dt@kernel.org, devicetree@vger.kernel.org References: <20200722172040.1299289-1-suzuki.poulose@arm.com> <20200722172040.1299289-15-suzuki.poulose@arm.com> <20200729172058.GA3060370@xps15> From: Suzuki K Poulose Message-ID: <7036b8c5-b920-3de7-21d0-474e759e2624@arm.com> Date: Thu, 30 Jul 2020 17:38:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20200729172058.GA3060370@xps15> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 07/29/2020 06:20 PM, Mathieu Poirier wrote: > On Wed, Jul 22, 2020 at 06:20:40PM +0100, Suzuki K Poulose wrote: >> Document the bindings for ETMv4.4 and later with only system register >> access. >> >> Cc: Rob Herring >> Cc: devicetree@vger.kernel.org >> Cc: Mathieu Poirier >> Cc: Mike Leach >> Signed-off-by: Suzuki K Poulose >> --- >> Documentation/devicetree/bindings/arm/coresight.txt | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/arm/coresight.txt b/Documentation/devicetree/bindings/arm/coresight.txt >> index d711676b4a51..cfe47bdda728 100644 >> --- a/Documentation/devicetree/bindings/arm/coresight.txt >> +++ b/Documentation/devicetree/bindings/arm/coresight.txt >> @@ -34,9 +34,13 @@ its hardware characteristcs. >> Program Flow Trace Macrocell: >> "arm,coresight-etm3x", "arm,primecell"; >> >> - - Embedded Trace Macrocell (version 4.x): >> + - Embedded Trace Macrocell (version 4.x), with memory mapped access. >> "arm,coresight-etm4x", "arm,primecell"; >> >> + - Embedded Trace Macrocell (version 4.4 and later) with system >> + register access only. >> + "arm,coresight-etm-v4.4"; > > I would rather call this "arm,coresight-etm-v4.4+" so that the binding's > semantic is still relevant when dealing with ETM v4.5 and onward. AFAIUC, "compatible" stands for something that is compatible with v4.4. All v4.4+ versions that are compatible with v4.4 are covered here. Having said that I am fine with "arm,coresight-etm-v4.4+" , if it is fine by the DT conventions. Cheers Suzuki