From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AD07C433EF for ; Mon, 17 Jan 2022 06:57:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232999AbiAQG5h (ORCPT ); Mon, 17 Jan 2022 01:57:37 -0500 Received: from marcansoft.com ([212.63.210.85]:56888 "EHLO mail.marcansoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231831AbiAQG5g (ORCPT ); Mon, 17 Jan 2022 01:57:36 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: marcan@marcan.st) by mail.marcansoft.com (Postfix) with ESMTPSA id 05597425B7; Mon, 17 Jan 2022 06:57:26 +0000 (UTC) Subject: Re: [PATCH v2 23/35] brcmfmac: cfg80211: Add support for scan params v2 To: Arend Van Spriel , Kalle Valo , "David S. Miller" , Jakub Kicinski , Rob Herring , "Rafael J. Wysocki" , Len Brown , Arend van Spriel , Franky Lin , Hante Meuleman , Chi-hsien Lin , Wright Feng , Dmitry Osipenko Cc: Sven Peter , Alyssa Rosenzweig , Mark Kettenis , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Pieter-Paul Giesberts , Linus Walleij , Hans de Goede , "John W. Linville" , "brian m. carlson" , Andy Shevchenko , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, SHA-cyfmac-dev-list@infineon.com References: <20220104072658.69756-1-marcan@marcan.st> <20220104072658.69756-24-marcan@marcan.st> <17e26a0de80.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> From: Hector Martin Message-ID: <773f6732-3b2d-3b73-c8e6-0aed89f6b415@marcan.st> Date: Mon, 17 Jan 2022 15:57:24 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <17e26a0de80.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> Content-Type: text/plain; charset=utf-8 Content-Language: es-ES Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 05/01/2022 04.46, Arend Van Spriel wrote: > On January 4, 2022 8:30:51 AM Hector Martin wrote: > >> This new API version is required for at least the BCM4387 firmware. Add >> support for it, with a fallback to the v1 API. >> >> Acked-by: Linus Walleij >> Signed-off-by: Hector Martin >> --- >> .../broadcom/brcm80211/brcmfmac/cfg80211.c | 113 ++++++++++++++---- >> .../broadcom/brcm80211/brcmfmac/feature.c | 1 + >> .../broadcom/brcm80211/brcmfmac/feature.h | 4 +- >> .../broadcom/brcm80211/brcmfmac/fwil_types.h | 49 +++++++- >> 4 files changed, 145 insertions(+), 22 deletions(-) > > Compiling this patch with C=2 gives following warnings: > > drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:1086:28: > warning: incorrect type in assignment (different base types) > drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:1086:28: > expected restricted __le16 [usertype] version > drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:1086:28: got int > drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:1148:38: > warning: incorrect type in assignment (different base types) > drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:1148:38: > expected restricted __le32 [usertype] scan_type > drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:1148:38: got int > drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:789:30: > warning: incorrect type in assignment (different base types) > drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:789:30: > expected unsigned char [usertype] scan_type > drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:789:30: got > restricted __le32 [usertype] scan_type > > Will check if this is a valid warning. Those are valid bugs (it'd break on big endian platforms), thanks for checking this. Fixed for v3 :) -- Hector Martin (marcan@marcan.st) Public Key: https://mrcn.st/pub