From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CE86C433EF for ; Thu, 30 Jun 2022 18:37:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236111AbiF3Shs (ORCPT ); Thu, 30 Jun 2022 14:37:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51220 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235808AbiF3Shs (ORCPT ); Thu, 30 Jun 2022 14:37:48 -0400 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E648143398 for ; Thu, 30 Jun 2022 11:37:46 -0700 (PDT) Received: by mail-ed1-x532.google.com with SMTP id k20so6312274edj.13 for ; Thu, 30 Jun 2022 11:37:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=UGGrUYFGtLESoSS2rsNev5359I+9qUzB9ek9G4Qz7uw=; b=BMDwOu1iMHdN/94k0T57BSZk6Ka2rjPA+yoEJvBvvMc/Gwo6WSABuWeZmjb68VZxsC cf/ddiswpYS37nUGMgrVNctpRxdymbfFaWTVgIyQbSHsW7DLYsRXUb+rGAZ5Bm6q9ITT BM9SrGQGZhCGmnVmirm6lxkoy9aVsforz+HxYqh87vp8+fzspUmnm8kLgXe9Hl6qjyk4 edIuRV5ceN4gtJzGoO+F9o7OYHLvO/RTG+kWp7yj05N2Dy8CYs8X3pf3mk9LZyoMT/ga 1/V1DqJEx8+Ivzhrq3esF5osKtBoo9jZEsIFusx5B7bmDX8D+EoEVzb+bnp8GwtEF7qr nQwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=UGGrUYFGtLESoSS2rsNev5359I+9qUzB9ek9G4Qz7uw=; b=KzXGOkx/tLqTRwGOtTb3Sk5WGH+dKqnMzlHXFJ/SKAzIqsnlXOn624s1U9zK91poCP nwGS9bn8oq03JrM8B/3hn9m2ZWlN4m5/4rqdlfg+bi7vvioUCYEdzRWXtrpp7AaMS5aV eh2ddBD9/6qqhhhzvJ9+/ZgK3LHJMBqQOcV4Mjq9qgV6OMaWE4WHG59rwvG6G4tNdhjn bvIbNA0XCLPYpDgzgux9EZSMS9fR5nkOeaSCFhbT7HgMzQf7BlUj3Ywee9ux8P+OQhEb /gVVs4m7K80Ci7iVXflARk6ZU7FgnnP7wqYCMkifauoMWfxQ+/4xJXIgJ/nnC3MkHl9l nYBQ== X-Gm-Message-State: AJIora8vDV+REVYmsv2uqLInRVnw6ejiMwCNG+mJHGdcf8bhnuk0lGN2 OvoZMh2Bd0LNztVhwt+ISaH+fw== X-Google-Smtp-Source: AGRyM1u3+PvK76fsXCzRLEryKlS/LLxqIEfJGGkbPSWvuPgDleiH5x/0VdYGGFhx9tY7hChc96qMkA== X-Received: by 2002:a05:6402:42c8:b0:435:b99c:35f9 with SMTP id i8-20020a05640242c800b00435b99c35f9mr13853065edc.137.1656614265507; Thu, 30 Jun 2022 11:37:45 -0700 (PDT) Received: from [192.168.0.190] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id s12-20020a170906354c00b0072637b9c8c0sm8669926eja.219.2022.06.30.11.37.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Jun 2022 11:37:44 -0700 (PDT) Message-ID: <7824e14b-89fb-a816-441d-012d76def59a@linaro.org> Date: Thu, 30 Jun 2022 20:37:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 1/2] dt-bindings: mailbox: qcom: Add syscon const for relevant entries Content-Language: en-US To: Bryan O'Donoghue , agross@kernel.org, bjorn.andersson@linaro.org, jassisinghbrar@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org References: <20220630043536.3308546-1-bryan.odonoghue@linaro.org> <20220630043536.3308546-2-bryan.odonoghue@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20220630043536.3308546-2-bryan.odonoghue@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 30/06/2022 06:35, Bryan O'Donoghue wrote: > msm8916, msm8939, msm8953, msm8994 and qcs404 already declare or should > declare syscon as they have drivers that use syscon inside of the apcs-kpss > block. > > grep apcs arch/arm64/boot/dts/qcom/* | grep syscon > > Add in the additional syscon in the documentation for the above mentioned > parts. Subject should have prefix: dt-bindings: mailbox: qcom,apcs-kpss-global: > > Signed-off-by: Bryan O'Donoghue > --- > .../mailbox/qcom,apcs-kpss-global.yaml | 44 ++++++++++--------- > 1 file changed, 24 insertions(+), 20 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml > index 3b5ba7ecc19d9..f342494fd6108 100644 > --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml > +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml > @@ -15,26 +15,30 @@ maintainers: > > properties: > compatible: > - enum: > - - qcom,ipq6018-apcs-apps-global > - - qcom,ipq8074-apcs-apps-global > - - qcom,msm8916-apcs-kpss-global > - - qcom,msm8939-apcs-kpss-global > - - qcom,msm8953-apcs-kpss-global > - - qcom,msm8976-apcs-kpss-global > - - qcom,msm8994-apcs-kpss-global > - - qcom,msm8996-apcs-hmss-global > - - qcom,msm8998-apcs-hmss-global > - - qcom,qcm2290-apcs-hmss-global > - - qcom,qcs404-apcs-apps-global > - - qcom,sc7180-apss-shared > - - qcom,sc8180x-apss-shared > - - qcom,sdm660-apcs-hmss-global > - - qcom,sdm845-apss-shared > - - qcom,sm6125-apcs-hmss-global > - - qcom,sm6115-apcs-hmss-global > - - qcom,sm8150-apss-shared > - > + oneOf: > + - items: > + - enum: > + - qcom,ipq6018-apcs-apps-global > + - qcom,ipq8074-apcs-apps-global > + - qcom,msm8976-apcs-kpss-global > + - qcom,msm8996-apcs-hmss-global > + - qcom,msm8998-apcs-hmss-global > + - qcom,qcm2290-apcs-hmss-global > + - qcom,sc7180-apss-shared > + - qcom,sc8180x-apss-shared > + - qcom,sdm660-apcs-hmss-global > + - qcom,sdm845-apss-shared > + - qcom,sm6125-apcs-hmss-global > + - qcom,sm6115-apcs-hmss-global > + - qcom,sm8150-apss-shared These are not items, but one item, so enum directly under oneOf. > + - items: > + - enum: > + - qcom,msm8916-apcs-kpss-global > + - qcom,msm8939-apcs-kpss-global > + - qcom,msm8953-apcs-kpss-global > + - qcom,msm8994-apcs-kpss-global > + - qcom,qcs404-apcs-apps-global > + - const: syscon > reg: > maxItems: 1 > Best regards, Krzysztof