From: "Sven Peter" <sven@svenpeter.dev>
To: "Rob Herring" <robh@kernel.org>
Cc: "Felipe Balbi" <balbi@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Hector Martin" <marcan@marcan.st>,
"Alyssa Rosenzweig" <alyssa@rosenzweig.io>,
"Mark Kettenis" <mark.kettenis@xs4all.nl>,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: usb: Add Apple dwc3 bindings
Date: Mon, 29 Nov 2021 23:34:24 +0100 [thread overview]
Message-ID: <78db7a00-93a4-46de-8071-2801c84bc171@www.fastmail.com> (raw)
In-Reply-To: <YaQseO5kF71vABji@robh.at.kernel.org>
Hi,
Thanks for the review!
On Mon, Nov 29, 2021, at 02:27, Rob Herring wrote:
> On Mon, Nov 08, 2021 at 06:09:45PM +0100, Sven Peter wrote:
>> Apple Silicon SoCs such as the M1 have multiple USB controllers based on
>> the Synopsys DesignWare USB3 controller.
>> References to the ATC PHY required for SuperSpeed are left out for now
>> until support has been upstreamed as well.
>>
>> Signed-off-by: Sven Peter <sven@svenpeter.dev>
>> ---
>> v1 -> v2:
>> - added apple,dwc3 bindings instead of a property for the reset quirk
>> as requested by robh
>>
>> I think I have to use GPL-2.0 for this binding since it's based
>> on and references snps,dwc3.yaml which is also only GPL-2.0.
>> Otherwise I'd be fine with the usual GPL/BSD dual license as well.
>>
>> .../devicetree/bindings/usb/apple,dwc3.yaml | 64 +++++++++++++++++++
>> MAINTAINERS | 1 +
>> 2 files changed, 65 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/usb/apple,dwc3.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/usb/apple,dwc3.yaml b/Documentation/devicetree/bindings/usb/apple,dwc3.yaml
>> new file mode 100644
>> index 000000000000..fb3b3489e6b2
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/usb/apple,dwc3.yaml
>> @@ -0,0 +1,64 @@
>> +# SPDX-License-Identifier: GPL-2.0
>
> Dual license please.
I'd like to but I'm not sure if I can do that. This binding is based on
snps,dwc3.yaml and rockchip,dwc3.yaml which are both only GPL-2.0.
>
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/usb/apple,dwc3.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Apple Silicon DWC3 USB controller
>> +
>> +maintainers:
>> + - Sven Peter <sven@svenpeter.dev>
>> +
>> +description:
>> + On Apple Silicon SoCs such as the M1 each Type-C port has a corresponding
>> + USB controller based on the Synopsys DesignWare USB3 controller.
>> +
>> + The common content of this binding is defined in snps,dwc3.yaml.
>> +
>> +allOf:
>> + - $ref: snps,dwc3.yaml#
>> +
>> +select:
>> + properties:
>> + compatible:
>> + contains:
>> + const: apple,dwc3
>
> This needs to list all possible compatibles except snps,dwc3 so the
> schema is applied for any incorrect mixture of compatibles.
Makes sense, will do that for the next version.
Thanks,
Sven
prev parent reply other threads:[~2021-11-29 22:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-08 17:09 [PATCH v2 1/2] dt-bindings: usb: Add Apple dwc3 bindings Sven Peter
2021-11-08 17:09 ` [PATCH v2 2/2] usb: dwc3: Add role switch reset quirk for Apple DWC3 Sven Peter
2021-11-13 11:05 ` Janne Grunau
2021-11-29 1:27 ` [PATCH v2 1/2] dt-bindings: usb: Add Apple dwc3 bindings Rob Herring
2021-11-29 22:34 ` Sven Peter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78db7a00-93a4-46de-8071-2801c84bc171@www.fastmail.com \
--to=sven@svenpeter.dev \
--cc=alyssa@rosenzweig.io \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=mark.kettenis@xs4all.nl \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).