Linux-Devicetree Archive on lore.kernel.org
 help / color / Atom feed
From: Phil Reid <preid@electromag.com.au>
To: Jonathan Cameron <jic23@kernel.org>, linux-iio@vger.kernel.org
Cc: Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH 13/13] dt-bindings: iio: adc: ti,tlc4541 binding conversion
Date: Mon, 10 Aug 2020 08:42:39 +0800
Message-ID: <7de481eb-a3d1-09b2-5ced-aaff3a14dc72@electromag.com.au> (raw)
In-Reply-To: <20200809111753.156236-14-jic23@kernel.org>

On 9/08/2020 19:17, Jonathan Cameron wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> Simple binding so easy to convert.
> Dropped the stated value of maximum spi bus frequency as it does
> not seem to correspond to the datasheet.  The value of 200kHz
> is the max sampling frequency of the ADC, not the clock frequency of
> the SPI bus.
> 
> Added #io-channel-cells to allow use as a provider of channels to
> other devices via the consumer binding.
> 
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Phil Reid <preid@electromag.com.au>

Yes, the spi frequency can be higher.
Thanks.

Reviewed-By: Phil Reid <preid@electromag.com.au>

> ---
>   .../bindings/iio/adc/ti,tlc4541.yaml          | 52 +++++++++++++++++++
>   .../bindings/iio/adc/ti-tlc4541.txt           | 17 ------
>   2 files changed, 52 insertions(+), 17 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/ti,tlc4541.yaml b/Documentation/devicetree/bindings/iio/adc/ti,tlc4541.yaml
> new file mode 100644
> index 000000000000..6c2539b3d707
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/ti,tlc4541.yaml
> @@ -0,0 +1,52 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/adc/ti,tlc4541.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Texas Instruments TLC4541 and similar ADCs
> +
> +maintainers:
> +  - Phil Reid <preid@electromag.com.au>
> +
> +description: |
> +  14/16bit single channel ADC with SPI interface.
> +
> +properties:
> +  compatible:
> +    enum:
> +      - ti,tlc3541
> +      - ti,tlc4541
> +
> +  reg:
> +    maxItems: 1
> +
> +  spi-max-frequency: true
> +
> +  vref-supply: true
> +
> +  "#io-channel-cells":
> +    const: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - vref-supply
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    spi {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        adc@0 {
> +            compatible = "ti,tlc4541";
> +            reg = <0>;
> +            vref-supply = <&vdd_supply>;
> +            spi-max-frequency = <200000>;
> +            #io-channel-cells = <1>;
> +        };
> +    };
> +...
> diff --git a/Documentation/devicetree/bindings/iio/adc/ti-tlc4541.txt b/Documentation/devicetree/bindings/iio/adc/ti-tlc4541.txt
> deleted file mode 100644
> index 6b2692723a04..000000000000
> --- a/Documentation/devicetree/bindings/iio/adc/ti-tlc4541.txt
> +++ /dev/null
> @@ -1,17 +0,0 @@
> -* Texas Instruments' TLC4541
> -
> -Required properties:
> - - compatible: Should be one of
> -	* "ti,tlc4541"
> -	* "ti,tlc3541"
> -	- reg: SPI chip select number for the device
> - - vref-supply: The regulator supply for ADC reference voltage
> - - spi-max-frequency: Max SPI frequency to use (<= 200000)
> -
> -Example:
> -adc@0 {
> -	compatible = "ti,tlc4541";
> -	reg = <0>;
> -	vref-supply = <&vdd_supply>;
> -	spi-max-frequency = <200000>;
> -};
> 


-- 
Regards
Phil Reid



  reply index

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-09 11:17 [PATCH 00/13] dt-bindings: yaml conversions of some simple ADC bindings Jonathan Cameron
2020-08-09 11:17 ` [PATCH 01/13] dt-bindings: iio: adc: microchip,mcp3201 yaml conversion Jonathan Cameron
2020-08-18  2:24   ` Rob Herring
2020-08-30 13:25     ` Jonathan Cameron
2020-08-09 11:17 ` [PATCH 02/13] dt-bindings: trivial-devices: Add mcp342x ADCs and drop separate binding doc Jonathan Cameron
2020-08-18  2:27   ` Rob Herring
2020-08-29 17:48     ` Jonathan Cameron
2020-08-09 11:17 ` [PATCH 03/13] dt-bindings: iio: adc: ti,adc108s102 yaml conversion Jonathan Cameron
2020-08-18  2:27   ` Rob Herring
2020-08-29 17:50     ` Jonathan Cameron
2020-08-09 11:17 ` [PATCH 04/13] dt-bindings: iio: adc: lltc,ltc2497 " Jonathan Cameron
2020-08-18  2:28   ` Rob Herring
2020-08-29 17:50     ` Jonathan Cameron
2020-08-09 11:17 ` [PATCH 05/13] dt-bindings: iio: adc: ti,adc161s626 " Jonathan Cameron
2020-08-11  3:35   ` Matt Ranostay
2020-08-18  2:28   ` Rob Herring
2020-08-29 17:51     ` Jonathan Cameron
2020-08-09 11:17 ` [PATCH 06/13] dt-bindings: iio: adc: ti,adc0832 " Jonathan Cameron
2020-08-18  2:29   ` Rob Herring
2020-08-09 11:17 ` [PATCH 07/13] dt-bindings: iio: adc: ti,adc084s021 " Jonathan Cameron
2020-08-18  2:30   ` Rob Herring
2020-08-29 17:53     ` Jonathan Cameron
2020-10-27 15:28       ` Jonathan Cameron
2020-08-09 11:17 ` [PATCH 08/13] dt-bindings: iio: adc: ti,adc12138 " Jonathan Cameron
2020-08-12 16:29   ` Rob Herring
2020-08-16  9:06     ` Jonathan Cameron
2020-08-17 14:17   ` Rob Herring
2020-08-09 11:17 ` [PATCH 09/13] dt-bindings: iio: adc: ti,adc128s052 " Jonathan Cameron
2020-08-18  2:30   ` Rob Herring
2020-08-29 17:55     ` Jonathan Cameron
2020-08-09 11:17 ` [PATCH 10/13] dt-bindings: iio: adc: ti,ads7950 binding conversion Jonathan Cameron
2020-08-12 16:30   ` David Lechner
2020-08-30 15:55     ` Jonathan Cameron
2020-08-09 11:17 ` [PATCH 11/13] dt-bindings: iio: adc: ti,ads8344 yaml conversion Jonathan Cameron
2020-08-18  2:31   ` Rob Herring
2020-08-29 17:58     ` Jonathan Cameron
2020-08-09 11:17 ` [PATCH 12/13] dt-bindings: iio: adc: tlc4541 - recover accidentally dropped binding doc Jonathan Cameron
2020-08-29 17:57   ` Jonathan Cameron
2020-08-09 11:17 ` [PATCH 13/13] dt-bindings: iio: adc: ti,tlc4541 binding conversion Jonathan Cameron
2020-08-10  0:42   ` Phil Reid [this message]
2020-08-18  2:32   ` Rob Herring
2020-08-29 17:59     ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7de481eb-a3d1-09b2-5ced-aaff3a14dc72@electromag.com.au \
    --to=preid@electromag.com.au \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Devicetree Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-devicetree/0 linux-devicetree/git/0.git
	git clone --mirror https://lore.kernel.org/linux-devicetree/1 linux-devicetree/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-devicetree linux-devicetree/ https://lore.kernel.org/linux-devicetree \
		devicetree@vger.kernel.org
	public-inbox-index linux-devicetree

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-devicetree


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git