From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1836C4363D for ; Wed, 7 Oct 2020 14:20:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8FA3121531 for ; Wed, 7 Oct 2020 14:20:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728577AbgJGOU0 (ORCPT ); Wed, 7 Oct 2020 10:20:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728567AbgJGOU0 (ORCPT ); Wed, 7 Oct 2020 10:20:26 -0400 Received: from mail-out.m-online.net (mail-out.m-online.net [IPv6:2001:a60:0:28:0:1:25:1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9758C061755 for ; Wed, 7 Oct 2020 07:20:25 -0700 (PDT) Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4C5xLv1ZmYz1sQrf; Wed, 7 Oct 2020 16:20:23 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4C5xLt6ygdz1qqkM; Wed, 7 Oct 2020 16:20:22 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id pziLOkGfj2Kn; Wed, 7 Oct 2020 16:20:21 +0200 (CEST) X-Auth-Info: FajRkvEwn7zFglMjFpW/8QrpOMHWznfBIrlMfoJH3uk= Received: from [IPv6:::1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Wed, 7 Oct 2020 16:20:21 +0200 (CEST) Subject: Re: [PATCH v2 1/7] dt-bindings: display: mxsfb: Convert binding to YAML To: Laurent Pinchart Cc: Lucas Stach , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, =?UTF-8?Q?Guido_G=c3=bcnther?= , Stefan Agner , Rob Herring , Pengutronix Kernel Team , linux-arm-kernel@lists.infradead.org References: <20201007012438.27970-1-laurent.pinchart@ideasonboard.com> <20201007012438.27970-2-laurent.pinchart@ideasonboard.com> <20201007133357.GJ3937@pendragon.ideasonboard.com> From: Marek Vasut Message-ID: <7fc84f7c-0660-efb6-6baf-4e2b9df6b48a@denx.de> Date: Wed, 7 Oct 2020 16:20:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201007133357.GJ3937@pendragon.ideasonboard.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 10/7/20 3:33 PM, Laurent Pinchart wrote: > Hi Marek, > > On Wed, Oct 07, 2020 at 10:55:24AM +0200, Marek Vasut wrote: >> On 10/7/20 10:43 AM, Lucas Stach wrote: >>> On Mi, 2020-10-07 at 10:32 +0200, Marek Vasut wrote: >>>> On 10/7/20 3:24 AM, Laurent Pinchart wrote: >>>> [...] >>>>> +properties: >>>>> + compatible: >>>>> + enum: >>>>> + - fsl,imx23-lcdif >>>>> + - fsl,imx28-lcdif >>>>> + - fsl,imx6sx-lcdif >>>>> + - fsl,imx8mq-lcdif >>>> >>>> There is no fsl,imx8mq-lcdif in drivers/gpu/drm/mxsfb/mxsfb_drv.c, >>>> so the DT must specify compatible = "fsl,imx8mq-lcdif", >>>> "fsl,imx28-lcdif" (since imx28 is the oldest SoC with LCDIF V4). >>>> >>>> Should the compatible be added to drivers/gpu/drm/mxsfb/mxsfb_drv.c or >>>> dropped from the YAML file or neither ? >>> >>> Neither. As far as we know the block is compatible, so the DT should >>> claim that it's compatible to "fsl,imx28-lcdif". However we don't know >>> if there are any surprises, so we add the SoC specific compatible to be >>> able to change the driver matching later without changing the DT if the >>> need arises. For the DT validation to pass the SoC specific compatible >>> needs to be documented, even if it currently unused by the driver. >> >> What in that binding says you should specify compatible = >> "fsl,imx8mq-lcdif", "fsl,imx28-lcdif"; and not e.g. "fsl,imx8mq-lcdif", >> "fsl,imx23-lcdif" or simply "fsl,imx8mq-lcdif" ? > > Nothing, until the next patch :-) This patch only handles the YAML > conversion but doesn't fix issues. Good, thanks !