From: Steev Klimaszewski <steev@kali.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Rob Herring <robh+dt@kernel.org>,
Andrzej Hajda <a.hajda@samsung.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Douglas Anderson <dianders@chromium.org>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: drm/bridge: ti-sn65dsi86: Replace #pwm-cells
Date: Wed, 30 Sep 2020 18:06:55 -0500 [thread overview]
Message-ID: <7ff13ed2-5fe4-01b5-d1d7-0916f0630196@kali.org> (raw)
In-Reply-To: <20200930223532.77755-2-bjorn.andersson@linaro.org>
On 9/30/20 5:35 PM, Bjorn Andersson wrote:
> While the signal on GPIO4 to drive the backlight controller indeed is
> pulse width modulated its purpose is specifically to control the
> brightness of a backlight.
>
> Drop the #pwm-cells and instead expose a new property to configure the
> granularity of the backlight PWM signal.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> .../devicetree/bindings/display/bridge/ti,sn65dsi86.yaml | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.yaml b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.yaml
> index f8622bd0f61e..e380218b4646 100644
> --- a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.yaml
> @@ -66,9 +66,12 @@ properties:
> 1-based to match the datasheet. See ../../gpio/gpio.txt for more
> information.
>
> - '#pwm-cells':
> - const: 1
> - description: See ../../pwm/pwm.yaml for description of the cell formats.
> + ti,backlight-scale:
> + description:
> + The granularity of brightness for the PWM signal provided on GPIO4, if
> + this property is specified.
> + minimum: 0
> + maximum: 65535
>
> ports:
> type: object
Tested-By: Steev Klimaszewski <steev@kali.org>
next prev parent reply other threads:[~2020-09-30 23:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 22:35 [PATCH 0/2] drm/bridge: ti-sn65dsi86: Support backlight controls Bjorn Andersson
2020-09-30 22:35 ` [PATCH 1/2] dt-bindings: drm/bridge: ti-sn65dsi86: Replace #pwm-cells Bjorn Andersson
2020-09-30 23:06 ` Steev Klimaszewski [this message]
2020-10-02 20:42 ` Doug Anderson
2020-11-02 17:08 ` Bjorn Andersson
2020-11-11 0:48 ` Doug Anderson
2020-10-05 13:50 ` Rob Herring
2020-09-30 22:35 ` [PATCH 2/2] drm/bridge: ti-sn65dsi86: Expose backlight controls Bjorn Andersson
2020-09-30 23:07 ` Steev Klimaszewski
2020-10-02 20:42 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ff13ed2-5fe4-01b5-d1d7-0916f0630196@kali.org \
--to=steev@kali.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=bjorn.andersson@linaro.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).