Linux-Devicetree Archive on lore.kernel.org
 help / color / Atom feed
From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
	Rob Herring <robh+dt@kernel.org>, Kukjin Kim <kgene@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Sylwester Nawrocki <snawrocki@kernel.org>
Subject: Re: [PATCH 11/13] ARM: dts: exynos: Silence SATA PHY warning in Exynos5250 Arndale
Date: Tue, 1 Sep 2020 10:13:28 +0200
Message-ID: <800d8fa8-7fd4-6221-f8be-ef422e5642d9@samsung.com> (raw)
In-Reply-To: <20200901075417.22481-12-krzk@kernel.org>

Hi Krzysztof,

On 01.09.2020 09:54, Krzysztof Kozlowski wrote:
> The SATA PHY in Exynos5250 SoCs has two interfaces and two device nodes:
> 1. sata-phy@12170000
> 2. i2c-9/i2c@38
>
> The first node represents the actual SATA PHY device with phy-cells.
> The second represents additional I2C interface, needed by the driver
> to communicate with the SATA PHY device.  It is not a PHY-provider in
> the terms of dtschema so rename it to silence dtbs_check warning:
>
>    arch/arm/boot/dts/exynos5250-arndale.dt.yaml: sata-phy@38: '#phy-cells' is a required property
>      From schema: lib/python3.6/site-packages/dtschema/schemas/phy/phy-provider.yaml
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
>   arch/arm/boot/dts/exynos5250-arndale.dts | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts
> index f2bcce167b2d..3c401c82905c 100644
> --- a/arch/arm/boot/dts/exynos5250-arndale.dts
> +++ b/arch/arm/boot/dts/exynos5250-arndale.dts
> @@ -544,7 +544,7 @@
>   	samsung,i2c-max-bus-freq = <40000>;
>   	samsung,i2c-slave-addr = <0x38>;
>   
> -	sata_phy_i2c: sata-phy@38 {
> +	sata_phy_i2c: sata-phy-i2c@38 {
>   		compatible = "samsung,exynos-sataphy-i2c";
>   		reg = <0x38>;
>   	};

I'm not against the rename, but frankly, the above node and all i2c 
parameters should be moved to exynos5250.dtsi. This is a SoC internal 
things (the same way as hdmiphy in exynos4.dtsi), so the board dts 
should only contain information like status = "enabled" for i2c_8 and 
hdmi_i2c_phy nodes. No need to duplicate it here and in smdk5250.dts.

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland


  reply index

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-01  7:54 [PATCH 00/13] ARM: dts: exynos: dtschema cleanups for Exynos5 Krzysztof Kozlowski
2020-09-01  7:54 ` [PATCH 01/13] ARM: dts: exynos: Correct compatible for Exynos5 GIC Krzysztof Kozlowski
2020-09-03 20:48   ` Krzysztof Kozlowski
2020-09-01  7:54 ` [PATCH 02/13] ARM: dts: exynos: Correct compatible for Exynos5260 GIC Krzysztof Kozlowski
2020-09-01  7:54 ` [PATCH 03/13] ARM: dts: exynos: Remove unneeded address/size cells in " Krzysztof Kozlowski
2020-09-01  7:54 ` [PATCH 04/13] ARM: dts: exynos: Correct S3C RTC bindings in SMDK5410 Krzysztof Kozlowski
2020-09-01  7:54 ` [PATCH 05/13] ARM: dts: exynos: Silence i2c-gpio dtschema warning in Exynos5250 Arndale Krzysztof Kozlowski
2020-09-01  7:54 ` [PATCH 06/13] ARM: dts: exynos: Correct whitespace and indentation issues in Exynos5 Krzysztof Kozlowski
2020-09-01  7:54 ` [PATCH 07/13] ARM: dts: exynos: Override thermal by label in Exynos5250 Krzysztof Kozlowski
2020-09-01  7:54 ` [PATCH 08/13] ARM: dts: exynos: Add max77686 clocks for S3C RTC in SMDK5250 Krzysztof Kozlowski
2020-09-01  7:54 ` [PATCH 09/13] ARM: dts: exynos: Use S5M8767 clock in S3C RTC in Exynos5250 Spring Krzysztof Kozlowski
2020-09-01  7:54 ` [PATCH 10/13] ARM: dts: exynos: Silence DP HPD pinctrl dtschema warning " Krzysztof Kozlowski
2020-09-01  7:54 ` [PATCH 11/13] ARM: dts: exynos: Silence SATA PHY warning in Exynos5250 Arndale Krzysztof Kozlowski
2020-09-01  8:13   ` Marek Szyprowski [this message]
2020-09-01  8:17     ` Krzysztof Kozlowski
2020-09-01  8:19       ` Krzysztof Kozlowski
2020-09-01  8:36         ` Marek Szyprowski
2020-09-01  8:42           ` Krzysztof Kozlowski
2020-09-01  7:54 ` [PATCH 12/13] ARM: dts: exynos: Silence SATA PHY warning in SMDK5250 Krzysztof Kozlowski
2020-09-01  7:54 ` [PATCH 13/13] ARM: dts: exynos: Use S2MPS11 clock in S3C RTC in SMDK5420 Krzysztof Kozlowski
2020-09-04  8:59   ` Krzysztof Kozlowski
2020-09-01  8:02 ` [PATCH 00/13] ARM: dts: exynos: dtschema cleanups for Exynos5 Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=800d8fa8-7fd4-6221-f8be-ef422e5642d9@samsung.com \
    --to=m.szyprowski@samsung.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kgene@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=snawrocki@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Devicetree Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-devicetree/0 linux-devicetree/git/0.git
	git clone --mirror https://lore.kernel.org/linux-devicetree/1 linux-devicetree/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-devicetree linux-devicetree/ https://lore.kernel.org/linux-devicetree \
		devicetree@vger.kernel.org
	public-inbox-index linux-devicetree

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-devicetree


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git