From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Mark Brown <broonie@kernel.org>
Cc: Chanwoo Choi <cw00.choi@samsung.com>, Pavel Machek <pavel@ucw.cz>,
Rob Herring <robh+dt@kernel.org>,
Lee Jones <lee.jones@linaro.org>,
Sebastian Reichel <sre@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v2 3/4] regulator: dt-bindings: maxim,max77693: convert to dtschema
Date: Mon, 14 Feb 2022 18:28:39 +0100 [thread overview]
Message-ID: <8347bd3c-12d4-8479-153f-8a5beaec786c@canonical.com> (raw)
In-Reply-To: <YgqMZhNhMRgO0V8t@sirena.org.uk>
On 14/02/2022 18:07, Mark Brown wrote:
> On Mon, Feb 14, 2022 at 06:01:17PM +0100, Krzysztof Kozlowski wrote:
>
>> You mantioned new features - this approach does not change that. If you
>> add new properties to common schema, you already alter bindings. Just
>> because we use common part, it does not change the fact that it is a
>> bindings change. Adding new features in common schema is the same
>> binding change as adding new feature in the specific binding, except
>> more work.
>
>> I guess you though that work in scaling, so yes, this scales worse. The
>> benefit is that this really restricts usage of regulator to what is
>> supported, so allows to detect wrongly configured DTS.
>
> We should have a way of specifying generic properties that doesn't
> require us to go through every single user of a binding and updating
> them all, then auditing by hand any new users to make sure they didn't
> forget one of the generic properties. This is just error prone and
> miserable, especially when most of the checking is done by hand rather
> than automated.
I see. The hardware really does not support most of core regulator
features, so if we switch to your proposal
(unevaluatedProperties:false), the DTS could contain something which is
good from the core regulator point of view, but does not fit at all this
hardware.
A disallow/deny-list could solve it... but it also does not scale.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-02-14 17:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-11 17:50 [PATCH v2 0/4] leds/power/regulator/mfd: dt-bindings: maxim,max77693: convert to dtschema Krzysztof Kozlowski
2022-01-11 17:50 ` [PATCH v2 1/4] dt-bindings: leds: " Krzysztof Kozlowski
2022-01-11 22:29 ` Rob Herring
2022-01-11 17:50 ` [PATCH v2 2/4] dt-bindings: power: supply: " Krzysztof Kozlowski
2022-01-12 11:31 ` Sebastian Reichel
2022-01-11 17:50 ` [PATCH v2 3/4] regulator: dt-bindings: " Krzysztof Kozlowski
2022-01-11 22:30 ` Rob Herring
2022-02-14 16:41 ` Mark Brown
2022-02-14 16:45 ` Krzysztof Kozlowski
2022-02-14 16:51 ` Mark Brown
2022-02-14 17:01 ` Krzysztof Kozlowski
2022-02-14 17:07 ` Mark Brown
2022-02-14 17:28 ` Krzysztof Kozlowski [this message]
2022-01-11 17:50 ` [PATCH v2 4/4] dt-bindings: mfd: " Krzysztof Kozlowski
2022-01-12 2:26 ` Rob Herring
2022-02-06 17:36 ` [PATCH v2 0/4] leds/power/regulator/mfd: dt-bindings: " Krzysztof Kozlowski
2022-02-07 9:35 ` Lee Jones
2022-02-14 14:14 ` [GIT PULL] Immutable branch between MFD, LED, Power and Regulator due for the v5.18 merge window Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8347bd3c-12d4-8479-153f-8a5beaec786c@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).