devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Caleb Robey <c-robey@ti.com>, <linux-omap@vger.kernel.org>
Cc: "Jason Kridner" <jkridner@gmail.com>,
	"Lokesh Vutla" <lokeshvutla@ti.com>, "Jason Kridner" <jdk@ti.com>,
	"Faiz Abbas" <faiz_abbas@ti.com>,
	"Andreas Dannenberg" <dannenberg@ti.com>,
	"Jean-Jacques Hiblot" <jjhiblot@ti.com>,
	"Praneeth Bajjuri" <praneeth@ti.com>,
	"Andrew F . Davis" <afd@ti.com>, "Tom Rini" <trini@konsulko.com>,
	"Robert Nelson" <robertcnelson@gmail.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Benoît Cousson" <bcousson@baylibre.com>,
	"Tony Lindgren" <tony@atomide.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] ARM: dts: am5729: beaglebone-ai: adding device tree
Date: Thu, 21 Nov 2019 13:04:35 +0200	[thread overview]
Message-ID: <8465b8c3-db4b-31fd-a299-3d5251ec99cf@ti.com> (raw)
In-Reply-To: <20191119202850.18149-2-c-robey@ti.com>



On 19/11/2019 22:28, Caleb Robey wrote:
> From: Jason Kridner <jdk@ti.com>
> 
> BeagleBoard.org BeagleBone AI is an open source hardware single
> board computer based on the Texas Instruments AM5729 SoC featuring
> dual-core 1.5GHz Arm Cortex-A15 processor, dual-core C66 digital
> signal processor (DSP), quad-core embedded vision engine (EVE),
> Arm Cortex-M4 processors, dual programmable realtime unit
> industrial control subsystems and more. The board features 1GB
> DDR3L, USB3.0 Type-C, USB HS Type-A, microHDMI, 16GB eMMC flash,
> 1G Ethernet, 802.11ac 2/5GHz, Bluetooth, and BeagleBone expansion
> headers.
> 
> For more information, refer to:
> https://beaglebone.ai


> 
> This patch introduces the BeagleBone AI device tree.
> 
> Note that the device use the "ti,tpd12s016" component which is
> software compatible with "ti,tpd12s015". Thus we only use the
> latter driver.
> 
> Signed-off-by: Jason Kridner <jdk@ti.com>
> Signed-off-by: Caleb Robey <c-robey@ti.com>
> Cc: Robert Nelson <robertcnelson@gmail.com>
> 
> ---
>   arch/arm/boot/dts/Makefile                |   1 +
>   arch/arm/boot/dts/am5729-beagleboneai.dts | 782 ++++++++++++++++++++++
>   2 files changed, 783 insertions(+)
>   create mode 100644 arch/arm/boot/dts/am5729-beagleboneai.dts
> 
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index b21b3a64641a..b1154dbda73c 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile

[..]

> +
> +&uart1 {
> +	status = "okay";
> +};
> +
> +&davinci_mdio {
> +	reset-gpios = <&gpio2 23 GPIO_ACTIVE_LOW>;
> +	reset-delay-us = <2>;
> +
> +	phy0: ethernet-phy@1 {
> +		reg = <4>;
> +		compatible = "ethernet-phy-id004d.d072",
> +			"ethernet-phy-ieee802.3-c22";

Pls, do not ignore my comments.

Above compatible should not be required.

> +		eee-broken-100tx;
> +		eee-broken-1000t;
> +	};
> +};
> +
> +&mac {
> +	slaves = <1>;
> +	status = "okay";
> +};

Pls, move cpsw node here

> +
> +&ocp {
> +	pruss1_shmem: pruss_shmem@4b200000 {
> +		status = "okay";
> +		compatible = "ti,pruss-shmem";
> +		reg = <0x4b200000 0x020000>;
> +	};
> +

[..]

> +
> +&cpsw_emac0 {
> +	phy-handle = <&phy0>;
> +	phy-mode = "rgmii";
> +};

Move it up, pls.

-- 
Best regards,
grygorii

  parent reply	other threads:[~2019-11-21 11:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-19 20:28 [PATCH 0/1] ARM: dts: am5729: beaglebone-ai: enable board Caleb Robey
2019-11-19 20:28 ` [PATCH 1/1] ARM: dts: am5729: beaglebone-ai: adding device tree Caleb Robey
2019-11-19 21:21   ` Andrew F. Davis
2019-11-21 11:04   ` Grygorii Strashko [this message]
2019-11-21 14:41     ` Robey, Caleb
2019-11-22  9:29       ` Grygorii Strashko
2019-11-21 13:19   ` Andrew F. Davis
2019-11-22 13:50   ` Jason Kridner
2019-11-19 20:40 ` [PATCH 0/1] ARM: dts: am5729: beaglebone-ai: enable board Andrew F. Davis
2019-11-19 20:45   ` Robey, Caleb
2019-11-21 11:05 ` Grygorii Strashko
2019-11-21 14:42   ` Robey, Caleb

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8465b8c3-db4b-31fd-a299-3d5251ec99cf@ti.com \
    --to=grygorii.strashko@ti.com \
    --cc=afd@ti.com \
    --cc=bcousson@baylibre.com \
    --cc=c-robey@ti.com \
    --cc=dannenberg@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=faiz_abbas@ti.com \
    --cc=jdk@ti.com \
    --cc=jjhiblot@ti.com \
    --cc=jkridner@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=lokeshvutla@ti.com \
    --cc=mark.rutland@arm.com \
    --cc=praneeth@ti.com \
    --cc=robertcnelson@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=tony@atomide.com \
    --cc=trini@konsulko.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).