From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2F12C43217 for ; Mon, 28 Nov 2022 14:58:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230518AbiK1O6d (ORCPT ); Mon, 28 Nov 2022 09:58:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48134 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230376AbiK1O6c (ORCPT ); Mon, 28 Nov 2022 09:58:32 -0500 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C3C77C31 for ; Mon, 28 Nov 2022 06:58:31 -0800 (PST) Received: by mail-lf1-x134.google.com with SMTP id b3so17787457lfv.2 for ; Mon, 28 Nov 2022 06:58:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ajNcLMY6QmAqgwHvTgxzL1USgmPi+/KLdoITf1G/CH4=; b=tqY2QmgNNWKIuP1WstZFTIldppn0/o3pVsMgn2N/EcXxdevmWKxoQYawyQqMoDUrUj lGXNuo2U2+dKA5WS/uSLRc3xAehkglIXDob89APQkw3zg4FcmOk6QkNS0XMOuzC7D2uO gDlKiuDlnL+VMIT/L7F3Y1azw8vP9wbINtSTgeMWxYwD0QTwWR9DhgEB3vjGc67sr2QG sz0nxySHhY5PEUjanSFA3tN1Jd44Opck5ZzIHJyciO6JWwkqVIHYSNiTtu5t9dSkbaAh gJPE/JcslvwliQe+swhij4knkMl6zUMoezk6LU/ltF2vwpXqTm5MYs+8MT24ixKZAJtS wwYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ajNcLMY6QmAqgwHvTgxzL1USgmPi+/KLdoITf1G/CH4=; b=goS84JOL8QHf8vF1pDa7BrpIUS+2W91Xfi75nXCO+kdDetIzZUrU3A3SA/Mcqybo4B xkKbd3FksOtk8TDzzksZhK5kZdHYoEexlfIkBCbA0qdqu6XguoOsrlio2HCyePcFsySm msGUQGNFNnmbbFbOBbud5p17wqBBCQ24XhpRLpohWs72gHCn62pu6seuaN9DvSImpHBe yc5z/8as6m0hNBw+5jG71t8xeB0BC38rjO6yfpmmjW3axx2zKvPbi1GSeK9+Arg/PU94 rvyChkdcA/1eVJuFMMu2pdsVK4hsQyX9zVZ0OLiJ4kusm36gSyr6uXep6/oYRFHnfcOa GiHA== X-Gm-Message-State: ANoB5pke0oOPTajYiSWPkWr+qLxaZSQFOcu26Gc0ivNfgIhIWwDQt9ly yR3lwYOoPkfKhl4caoDbwl278w== X-Google-Smtp-Source: AA0mqf6UI6FcpPI9uDfhvcmtur1U1zghV+aGkDbYf1gqWnNqpTKptXZ1bg39H7fkD1Or5r1DtWSNGg== X-Received: by 2002:a05:6512:32d0:b0:4b4:b5ed:c71f with SMTP id f16-20020a05651232d000b004b4b5edc71fmr17042575lfg.227.1669647510166; Mon, 28 Nov 2022 06:58:30 -0800 (PST) Received: from [192.168.1.101] (95.49.125.236.neoplus.adsl.tpnet.pl. [95.49.125.236]) by smtp.gmail.com with ESMTPSA id p8-20020a2eba08000000b002776eb5b1ccsm1272424lja.4.2022.11.28.06.58.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Nov 2022 06:58:29 -0800 (PST) Message-ID: <850051e5-73d4-6ab9-f924-8cd01dd2a3d6@linaro.org> Date: Mon, 28 Nov 2022 15:58:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v2 1/3] arm64: dts: qcom: msm8996-xiaomi-gemini: use preferred enable-gpios for LP5562 LED Content-Language: en-US To: Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221127203240.54955-1-krzysztof.kozlowski@linaro.org> From: Konrad Dybcio In-Reply-To: <20221127203240.54955-1-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 27.11.2022 21:32, Krzysztof Kozlowski wrote: > The preferred name suffix for properties with single and multiple GPIOs > is "gpios". Linux GPIO core code supports both. Bindings are going to > expect the "gpios" one: > > qcom/msm8996-xiaomi-gemini.dtb: lp5562@30: 'enable-gpio' does not match any of the regexes: '^led@[0-8]$', '^multi-led@[0-8]$', 'pinctrl-[0-9]+' > > Signed-off-by: Krzysztof Kozlowski > > --- Reviewed-by: Konrad Dybcio Konrad > > Changes since v1: > 1. New patch > --- > arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dts b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dts > index d8734913482f..dbd5f7e2df65 100644 > --- a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dts > +++ b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dts > @@ -54,7 +54,7 @@ lp5562@30 { > reg = <0x30>; > #address-cells = <1>; > #size-cells = <0>; > - enable-gpio = <&pm8994_gpios 7 1>; > + enable-gpios = <&pm8994_gpios 7 1>; > clock-mode = /bits/8 <2>; > label = "button-backlight"; >