From: Eric Anholt <eric@anholt.net>
To: Robin Murphy <robin.murphy@arm.com>,
Stefan Wahren <stefan.wahren@i2se.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>
Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
Florian Fainelli <f.fainelli@gmail.com>,
Scott Branden <sbranden@broadcom.com>,
Ray Jui <rjui@broadcom.com>, Phil Elwell <phil@raspberrypi.org>,
bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH RFC 2/6] dt-bindings: hwmon: Add Raspberry Pi voltage sensor
Date: Wed, 16 May 2018 18:51:39 +0100 [thread overview]
Message-ID: <874lj7cwus.fsf@anholt.net> (raw)
In-Reply-To: <30fc5bac-0c4a-b2c4-a018-ea521510aaea@arm.com>
[-- Attachment #1.1: Type: text/plain, Size: 1112 bytes --]
Robin Murphy <robin.murphy@arm.com> writes:
> On 16/05/18 14:37, Stefan Wahren wrote:
>> Recent VC4 firmware provides a hardware-independent way to retrieve the
>> under-voltage sensor on the following Raspberry Pi boards:
>> - Raspberry Pi B+ (via GPIO on SoC)
>> - Raspberry Pi A+ (via GPIO on SoC)
>> - Raspberry Pi 2 B (via GPIO on SoC)
>> - Raspberry Pi 3 B (via GPIO on port expander)
>> - Raspberry Pi 3 B+ (via PMIC)
>>
>> TODO:
>> - try to make bcm2835 firmware a bus driver
>
> Do you actually need a DT binding? From the probe routine in patch 2 it
> looks like this capability can be discovered dynamically by asking the
> firmware, therefore it might be more straightforward for the firmware
> driver itself to probe that and create a child device iff the feature is
> present, which the hwmon driver can then bind to as a pure platform driver.
Agreed, let's skip doing this in DT. I just switched the bcm2835-camera
driver over to not need DT, and I think you could do something similar
(and use the pdev->dev.parent to get at the firmware device).
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-05-16 17:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-16 13:37 [PATCH RFC 0/6] hwmon: Add support for Raspberry Pi voltage sensor Stefan Wahren
2018-05-16 13:37 ` [PATCH RFC 1/6] ARM: bcm2835: Add GET_THROTTLED firmware property Stefan Wahren
2018-05-16 13:37 ` [PATCH RFC 2/6] dt-bindings: hwmon: Add Raspberry Pi voltage sensor Stefan Wahren
2018-05-16 14:23 ` Robin Murphy
2018-05-16 17:51 ` Eric Anholt [this message]
2018-05-16 14:52 ` Guenter Roeck
2018-05-16 13:37 ` [PATCH RFC 3/6] hwmon: Add support for RPi " Stefan Wahren
2018-05-16 13:51 ` Robin Murphy
2018-05-16 18:05 ` Guenter Roeck
2018-05-16 18:23 ` Robin Murphy
2018-05-16 18:21 ` Guenter Roeck
2018-05-16 19:59 ` Stefan Wahren
2018-05-17 16:43 ` Guenter Roeck
2018-05-17 17:25 ` Eric Anholt
2018-05-16 13:37 ` [PATCH RFC 4/6] ARM: bcm2835_defconfig: Enable " Stefan Wahren
2018-05-16 13:37 ` [PATCH RFC 5/6] ARM: multi_v7_defconfig: " Stefan Wahren
2018-05-16 13:37 ` [PATCH RFC 6/6] arm64: defconfig: " Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874lj7cwus.fsf@anholt.net \
--to=eric@anholt.net \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=jdelvare@suse.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=phil@raspberrypi.org \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=sbranden@broadcom.com \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).