From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felipe Balbi Subject: Re: [PATCH v9 2/6] usb:gadget Separated decoding functions from dwc3 driver. Date: Wed, 07 Aug 2019 13:22:25 +0300 Message-ID: <877e7pnula.fsf@gmail.com> References: <1562324238-16655-1-git-send-email-pawell@cadence.com> <1562324238-16655-3-git-send-email-pawell@cadence.com> <87tvc0lngz.fsf@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Roger Quadros , Pawel Laszczak , "devicetree@vger.kernel.org" Cc: "gregkh@linuxfoundation.org" , "linux-usb@vger.kernel.org" , "hdegoede@redhat.com" , "heikki.krogerus@linux.intel.com" , "robh+dt@kernel.org" , "linux-kernel@vger.kernel.org" , "jbergsagel@ti.com" , "nsekhar@ti.com" , "nm@ti.com" , Suresh Punnoose , "peter.chen@nxp.com" , Jayshri Dajiram Pawar , Rahul Kumar List-Id: devicetree@vger.kernel.org Hi, Roger Quadros writes: >>>> +extern const char *usb_decode_ctrl(char *str, size_t size, __u8 bRequestType, >>>> + __u8 bRequest, __u16 wValue, __u16 wIndex, >>>> + __u16 wLength); >>>> + >>> >>> where's the stub when !TRACING? >> >> Right, I will add >> #ifdef CONFIG_TRACING >> ..... >> #endif > > Can usb_decode_ctrl() be used even when CONFIG_TRACING is not set? > If yes then above #ifdefe is not sufficient. > > You might need to do something like > > #if defined(CONFIG_TRACING) > > extern const char *usb_decode_ctrl(..) > > #else > > static inline const char *usb_decode_ctrl(..) { > return NULL; > } > > #endif This is what I mean. They shouldn't be used outside of TRACING, but it's far safer to have the stubs. -- balbi