From: Gregory CLEMENT <gregory.clement@free-electrons.com>
To: Adrian Hunter <adrian.hunter@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mmc@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, Jason Cooper <jason@lakedaemon.net>,
Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
linux-arm-kernel@lists.infradead.org,
Nadav Haklai <nadavh@marvell.com>, Victor Gu <xigu@marvell.com>,
Romain Perier <romain.perier@free-electrons.com>,
Omri Itach <omrii@marvell.com>, Marcin Wojtas <mw@semihalf.com>,
Wilson Ding <dingwei@marvell.com>,
Shadi Ammouri <shadi@marvell.com>
Subject: Re: [PATCH 09/12] mmc: sdhci-xenon: add initial Xenon eMMC driver
Date: Tue, 14 Jun 2016 10:19:12 +0200 [thread overview]
Message-ID: <878ty8chdr.fsf@free-electrons.com> (raw)
In-Reply-To: <575FA9BF.6070703@intel.com> (Adrian Hunter's message of "Tue, 14 Jun 2016 09:52:47 +0300")
Hi Adrian,
On mar., juin 14 2016, Adrian Hunter <adrian.hunter@intel.com> wrote:
> On 09/06/16 10:10, Gregory CLEMENT wrote:
>> From: Victor Gu <xigu@marvell.com>
>>
>> This path adds the driver for the Marvell Xenon eMMC host controller
>> which supports eMMC 5.1, SD 3.0.
>>
>> However this driver supports only up to eMMC 5.0 since the command queue
>> feature is not included (yet) in the driver.
>>
>> [gregory.clement@free-electrons.com:
>> - reformulate commit log
>> - overload the sdhci_set_uhs_signaling function instead of using a quirk
>> - fix a kconfig dependency
>> - remove dead code]
>>
>> Signed-off-by: Victor Gu <xigu@marvell.com>
>> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
>> ---
>> drivers/mmc/host/Kconfig | 10 +
>> drivers/mmc/host/Makefile | 1 +
>> drivers/mmc/host/sdhci-xenon.c | 1164 ++++++++++++++++++++++++++++++++++++++++
>> 3 files changed, 1175 insertions(+)
>> create mode 100644 drivers/mmc/host/sdhci-xenon.c
>>
>
> <SNIP>
>
>> diff --git a/drivers/mmc/host/sdhci-xenon.c b/drivers/mmc/host/sdhci-xenon.c
>> new file mode 100644
>> index 000000000000..43c06db95872
>> --- /dev/null
>> +++ b/drivers/mmc/host/sdhci-xenon.c
>
> <SNIP>
>
>> +static int sdhci_xenon_delay_adj_test(struct sdhci_host *host,
>> + struct mmc_card *card, unsigned int delay,
>> + bool invert, bool phase)
>> +{
>> + int ret;
>> + struct mmc_card *oldcard;
>> +
>> + sdhci_xenon_set_fix_delay(host, delay, invert, phase);
>> +
>> + /*
>> + * If the card is not yet associated to the host, we
>> + * temporally do it
>> + */
>> + oldcard = card->host->card;
>> + if (!oldcard)
>> + card->host->card = card;
>> + ret = card_alive(card);
>
> This looks like an abuse of bus_ops->alive(). You will need to get
> agreement with Ulf how to handle this. I will wait for Ulf's comments
> before reviewing this patch set further.
Actually I modified this part of the driver to use
bus_ops->alive(). Initially, the alive() code was more or less copied
and paste from the mmc core with ugly include from mmc_ops.h and
sdio_ops.h to make it work. I find it cleaner to directly access the
alive() function.
Could you explain why it is an abuse of bus_ops->alive()?
Thanks,
Gregory
>> + card->host->card = oldcard;
>> + if (ret) {
>> + pr_debug("Xenon failed when sampling fix delay %d, inverted %d, phase %d\n",
>> + delay, invert, phase);
>> + return -EIO;
>> + }
>> +
>> + pr_debug("Xenon succeeded when sampling fixed delay %d, inverted %d, phase %d\n",
>> + delay, invert, phase);
>> + return 0;
>> +}
>
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2016-06-14 8:19 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-09 7:10 [PATCH 00/12] Add SDHCI Xenon driver Gregory CLEMENT
[not found] ` <1465456218-28354-1-git-send-email-gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-06-09 7:10 ` [PATCH 01/12] mmc: sdhci: add init_card callback to sdhci Gregory CLEMENT
2016-06-13 8:32 ` Adrian Hunter
2016-06-14 7:58 ` Gregory CLEMENT
2016-06-09 7:10 ` [PATCH 10/12] arm64: dts: marvell: add eMMC support for Armada 37xx Gregory CLEMENT
2016-06-09 7:10 ` [PATCH 02/12] mmc: sdhci_f_sdh30: restrict voltage_switch() callback to the 1.8V case Gregory CLEMENT
2016-06-09 7:10 ` [PATCH 03/12] mmc: tegra: restrict the " Gregory CLEMENT
2016-06-09 9:54 ` Lucas Stach
2016-06-09 12:27 ` Gregory CLEMENT
2016-06-09 7:10 ` [PATCH 04/12] mmc: sdhci: call voltage_switch callback also for the 3.3V case Gregory CLEMENT
2016-06-09 7:10 ` [PATCH 05/12] mmc: sdhci: add a pre voltage switch callback function Gregory CLEMENT
[not found] ` <1465456218-28354-6-git-send-email-gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-06-13 8:46 ` Adrian Hunter
[not found] ` <575E72DC.5090604-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-06-13 14:04 ` Ziji Hu
[not found] ` <D7CF8A19-9181-4A97-90AF-AC5A6517CE2B-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>
2016-06-14 7:07 ` Adrian Hunter
2016-06-14 7:59 ` Gregory CLEMENT
2016-06-09 7:10 ` [PATCH 06/12] mmc: sdhci: add delay adjust feature including phy reset Gregory CLEMENT
2016-06-09 7:10 ` [PATCH 07/12] mmc: core: export the alive operation Gregory CLEMENT
2016-06-09 7:10 ` [PATCH 08/12] dt-bindings: mmc: Add Xenon description Gregory CLEMENT
2016-06-10 14:16 ` Rob Herring
2016-06-14 8:02 ` Gregory CLEMENT
2016-06-09 7:10 ` [PATCH 09/12] mmc: sdhci-xenon: add initial Xenon eMMC driver Gregory CLEMENT
2016-06-09 13:45 ` kbuild test robot
2016-06-09 14:33 ` Gregory CLEMENT
2016-06-09 14:20 ` kbuild test robot
2016-06-09 14:54 ` Gregory CLEMENT
[not found] ` <87r3c6mmyp.fsf-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-06-09 21:49 ` Arnd Bergmann
2016-06-14 6:52 ` Adrian Hunter
2016-06-14 8:19 ` Gregory CLEMENT [this message]
[not found] ` <878ty8chdr.fsf-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-06-14 8:36 ` Adrian Hunter
2016-06-22 11:04 ` Ulf Hansson
2016-06-09 7:10 ` [PATCH 11/12] arm64: dts: marvell: add SDIO support for Armada 37xx Gregory CLEMENT
2016-06-09 7:10 ` [PATCH 12/12] arm64: defconfig: Add Xenon sdhci Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878ty8chdr.fsf@free-electrons.com \
--to=gregory.clement@free-electrons.com \
--cc=adrian.hunter@intel.com \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=dingwei@marvell.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=omrii@marvell.com \
--cc=robh+dt@kernel.org \
--cc=romain.perier@free-electrons.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=shadi@marvell.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=ulf.hansson@linaro.org \
--cc=xigu@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).