From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC2C5C4332B for ; Wed, 13 Jan 2021 00:51:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9A16523125 for ; Wed, 13 Jan 2021 00:51:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393599AbhAMAm7 (ORCPT ); Tue, 12 Jan 2021 19:42:59 -0500 Received: from relmlor2.renesas.com ([210.160.252.172]:49752 "EHLO relmlie6.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2392078AbhAMABL (ORCPT ); Tue, 12 Jan 2021 19:01:11 -0500 Date: 13 Jan 2021 09:00:19 +0900 X-IronPort-AV: E=Sophos;i="5.79,342,1602514800"; d="scan'208";a="68582624" Received: from unknown (HELO relmlir5.idc.renesas.com) ([10.200.68.151]) by relmlie6.idc.renesas.com with ESMTP; 13 Jan 2021 09:00:19 +0900 Received: from mercury.renesas.com (unknown [10.166.252.133]) by relmlir5.idc.renesas.com (Postfix) with ESMTP id B10084009F78; Wed, 13 Jan 2021 09:00:19 +0900 (JST) Message-ID: <87czy9r9ue.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Richard Fitzgerald Cc: , , , , , , , , , , Subject: Re: [PATCH v4 3/6] ASoC: audio-graph-card: Support setting component plls and sysclks In-Reply-To: <762d798c-bd75-e24a-40fd-263f68f1a5f1@opensource.cirrus.com> References: <20210108160501.7638-1-rf@opensource.cirrus.com> <20210108160501.7638-4-rf@opensource.cirrus.com> <87y2gzymc5.wl-kuninori.morimoto.gx@renesas.com> <762d798c-bd75-e24a-40fd-263f68f1a5f1@opensource.cirrus.com> User-Agent: Wanderlust/2.15.9 Emacs/26.3 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Richard > > As I mentioned in v3, adding *general* pll to common card driver is > > maybe difficult. > > You did say that. But you did not say why. > Can you be more specific about what problem you see with adding it > to the generic driver? > > > Using your own customized audio-graph-card driver is better idea, > > instead of adding code to common driver. > > I just don't want to duplicate code without good reason. Ahh, sorry for my unclear comment. I think "PLL settings" is very board/platform specific, so, adding such code to common driver will be issue in the future. This is the reason why I don't want add it to audio-graph-card. But, as I mentioned above and Sameer is already doing, you can reuse audio-graph-card and customize it. Reuse audio-graph-card + Use your own PLL code = your own customized audio-graph-card You can reuse audio-graph-card code by calling graph_parse_of(), and customize before/after that. I think no duplicate code is needed. I hope it can help you. Thank you for your help !! Best regards --- Kuninori Morimoto