From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01804C43215 for ; Fri, 15 Nov 2019 08:11:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D040B2073B for ; Fri, 15 Nov 2019 08:11:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="cezKxZfD"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="DQHZwmxz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727295AbfKOILd (ORCPT ); Fri, 15 Nov 2019 03:11:33 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:56388 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725829AbfKOILd (ORCPT ); Fri, 15 Nov 2019 03:11:33 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 7548360F7A; Fri, 15 Nov 2019 08:11:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1573805492; bh=tkjLr6SlUn+QeQ8qUjDOStzhyxXnXQ0fWPvfLy8QjVQ=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=cezKxZfDfOyerLWd8Kk4K5RTqVRcDbcLf3OQPeokcLGWWLFsmNHDQXDuvM3RW/GZ+ Srhfkvpz/PlrBRPn+zw3grbK+Z0wgi01FuDLiSmsPnbHD8pzua7aUMyOvMKV3SlKUE N9TENW/DjHu1IHOIDYqHcDio/pGjkJf/5HDRwZog= Received: from [10.206.28.9] (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: tdas@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id C954860AFE; Fri, 15 Nov 2019 08:11:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1573805491; bh=tkjLr6SlUn+QeQ8qUjDOStzhyxXnXQ0fWPvfLy8QjVQ=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=DQHZwmxzPDvt9zpcAWw5Vc1WcijjbJhUPbUHqHeL3jL3nuopLlu5PlwMdfo+Scsf8 Fr25pb2NfYq5Emdx75wYa6bLpaozLJsvhDW9ynlVZFM2hYnhL+mcckJgROeCht1lUR nvKwp6glWFcDtlsnAJyw58ykX5+qbCZjgRj0P8qc= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org C954860AFE Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=tdas@codeaurora.org Subject: Re: [PATCH v1 1/7] clk: qcom: clk-alpha-pll: Add support for Fabia PLL calibration To: Doug Anderson Cc: Stephen Boyd , Michael Turquette , David Brown , Rajendra Nayak , linux-arm-msm , "open list:ARM/QUALCOMM SUPPORT" , linux-clk , LKML , Andy Gross , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Rob Herring , Rob Herring References: <1572524473-19344-1-git-send-email-tdas@codeaurora.org> <1572524473-19344-2-git-send-email-tdas@codeaurora.org> From: Taniya Das Message-ID: <87f22b35-5239-f128-3267-05a867324afe@codeaurora.org> Date: Fri, 15 Nov 2019 13:41:25 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Doug, On 11/7/2019 9:54 AM, Doug Anderson wrote: >> - ret = regmap_read(pll->clkr.regmap, PLL_MODE(pll), &val); >> - if (ret) >> - return ret; > > My compiler happened to notice that with the change to this function: > > drivers/clk/qcom/clk-alpha-pll.c:1166:6: error: unused variable 'ret' > [-Werror,-Wunused-variable] > int ret = 0; > > -Doug > Thanks for the review, will remove the unused variable. -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation. --