From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kuninori Morimoto Subject: Re: [PATCH 1/7] Documentation: of: add type property Date: Mon, 27 Jun 2016 00:09:13 +0000 Message-ID: <87r3bjxzw7.wl%kuninori.morimoto.gx@renesas.com> References: <87fus3xr2q.wl%kuninori.morimoto.gx@renesas.com> <87eg7nxr00.wl%kuninori.morimoto.gx@renesas.com> Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Rob Herring Cc: Linux-DT , Linux-ALSA , Mark Brown , Linux-Kernel , Mark Brown , Laurent , Grant Likely , Frank Rowand , Guennadi List-Id: devicetree@vger.kernel.org Hi Rob Thank you for your review > > +Each ports / port / endpoint can have its type if needed. > > I think type should only apply to a port. ports is only a grouping for > multiple ports. endpoints are just the connection. A port is a single > data flow, so 2 endpoints on a port reflect 2 possible connections for > that data flow. > > > +child node can take over parent node type. below example indicates > > +device0 type is "typeA" && "typeB", > > +device1 type is "typeA" && "typeB" && "typeC". > > This does not make sense to me. A concrete example perhaps using HDMI > audio would be helpful. "type" on "port" only is OK. I will fix that. Multi type feature (= take over from parent) and type on "endpoint" is not urgent at this point, so I will drop these in v2. I just thought that it will be necessary in the future.