From: Randy Dunlap <rdunlap@infradead.org>
To: Gavin Shan <gshan@redhat.com>, devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, drjones@redhat.com,
robh+dt@kernel.org, shan.gavin@gmail.com
Subject: Re: [PATCH v5] Documentation, dt, numa: Add note to empty NUMA node
Date: Mon, 28 Jun 2021 09:15:16 -0700 [thread overview]
Message-ID: <89e25fd7-b323-2092-4151-faba060d4c10@infradead.org> (raw)
In-Reply-To: <20210628093411.88805-1-gshan@redhat.com>
On 6/28/21 2:34 AM, Gavin Shan wrote:
> The empty memory nodes, where no memory resides in, are allowed.
> For these empty memory nodes, the 'len' of 'reg' property is zero.
> The NUMA node IDs are still valid and parsed, but memory may be
> added to them through hotplug afterwards. I finds difficulty to
> get where it's properly documented.
>
> So lets add a section for empty memory nodes in NUMA binding
> document. Also, the 'unit-address', equivalent to 'base-address'
> in the 'reg' property of these empty memory nodes is suggested to
> be the summation of highest memory address plus the NUMA node ID.
>
> Signed-off-by: Gavin Shan <gshan@redhat.com>
> ---
> v5: Separate section for empty memory node
> ---
> Documentation/devicetree/bindings/numa.txt | 61 +++++++++++++++++++++-
> 1 file changed, 60 insertions(+), 1 deletion(-)
>
LGTM. Thanks.
Acked-by: Randy Dunlap <rdunlap@infradead.org>
--
~Randy
next prev parent reply other threads:[~2021-06-28 16:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 9:34 [PATCH v5] Documentation, dt, numa: Add note to empty NUMA node Gavin Shan
2021-06-28 16:15 ` Randy Dunlap [this message]
2021-06-30 7:26 ` Gavin Shan
2021-07-01 17:25 ` Rob Herring
2021-07-02 0:02 ` Gavin Shan
2021-07-11 0:59 ` Gavin Shan
2021-07-12 19:44 ` Rob Herring
2021-07-15 4:54 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89e25fd7-b323-2092-4151-faba060d4c10@infradead.org \
--to=rdunlap@infradead.org \
--cc=devicetree@vger.kernel.org \
--cc=drjones@redhat.com \
--cc=gshan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=shan.gavin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).