From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACD10C433FE for ; Sun, 9 Oct 2022 15:18:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230109AbiJIPSp (ORCPT ); Sun, 9 Oct 2022 11:18:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230100AbiJIPSo (ORCPT ); Sun, 9 Oct 2022 11:18:44 -0400 Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com [IPv6:2607:f8b0:4864:20::733]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD6A02A26A for ; Sun, 9 Oct 2022 08:18:43 -0700 (PDT) Received: by mail-qk1-x733.google.com with SMTP id a5so469546qkl.6 for ; Sun, 09 Oct 2022 08:18:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=akrQmjJ5ANNV9oJ9U081ngxumiXjo/3S9Mc5SAIBAo4=; b=zY2GkVGgwwzE6TzX4K9RcSkWVEvq1t01CH68PG0NUS2gh/e9MkdC2BH9pkwJKNczCR HhT8beTnLqIeI+++qrQYlklUCPXaD0kgfp13PQwzuYedG3pYjg6dT2pLNMXatzYzSCjk d+03YtbjJIKR5WsSTLsQHFneqyhW7Dnm6+a0xRCCJDCBdVeoCY53Ak8wO20XD/meqBrL x8Wvhsq38xtA5uPh786ACn11NfkuITyp1dym/4Q1NUEnRiFZ3AIOIemsnHavcclGovom qDWnXC/gG6fKQjGY7iwX9gnUm+AFJ3IsNY3hKlgrnQOOkdJCx3ehcaJaS91CsJAhztnA 3yzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=akrQmjJ5ANNV9oJ9U081ngxumiXjo/3S9Mc5SAIBAo4=; b=jwncdNi/S41KnS9/NhaS5OvZ3fQNZM487zjBZSb9Jkq/X1FkZ5PpnVOkRMBnKdeJYa WyqtAC0bOJ31aBMKJEBlEVD03rmymxrZMnvDpQhPNQBnSo13JHgYY/dfrbPpDgWPcgyr 37SbqeJoe9zhW/Csbj14jXlYTWJwshu5ofMtYgolSgppxAo/ODLn904wRBdzLiNEq+Gf KnPhD4gQeDhBwWOs4xkDXkDwyyQ5S+JtLphGyBagM8gCdcG0EPbbXJKwmh4Fmkb2abgE IXhCzREbDdoqlj9R2IavCp32R6IJ3r9l1CxMc86hiHD4ZYZ9pwIvFfWAHILOqjs3s/Ad Skww== X-Gm-Message-State: ACrzQf1UvWwPaYRKXhoCbeQy5Hp5qJvyi0QgtZMWO6ATO/uZjhUNhqQj KD4sqTGYFrKtram920uIe5NvRw== X-Google-Smtp-Source: AMsMyM7wkO+uNHublLqxbJQRkrkJLB4Tdfxa8dNbZoat2NF6x6vAN9JwuDKqfO3jpnBNaKGD+syWqg== X-Received: by 2002:a05:620a:a03:b0:6ec:bf65:d0fc with SMTP id i3-20020a05620a0a0300b006ecbf65d0fcmr864584qka.381.1665328723009; Sun, 09 Oct 2022 08:18:43 -0700 (PDT) Received: from [192.168.1.57] (cpe-72-225-192-120.nyc.res.rr.com. [72.225.192.120]) by smtp.gmail.com with ESMTPSA id t28-20020a37ea1c000000b006cdd0939ffbsm7756178qkj.86.2022.10.09.08.18.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 09 Oct 2022 08:18:42 -0700 (PDT) Message-ID: <8b4a2bfd-ce7f-6bb9-4e50-ecd9bda881a2@linaro.org> Date: Sun, 9 Oct 2022 17:16:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v3 1/4] dt-bindings: mfd: Document RZ/G2L MTU3a bindings Content-Language: en-US To: Biju Das , Rob Herring , William Breathitt Gray , Thierry Reding , Lee Jones , Philipp Zabel Cc: Krzysztof Kozlowski , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , "devicetree@vger.kernel.org" , "linux-pwm@vger.kernel.org" , Geert Uytterhoeven , Chris Paterson , Biju Das , Prabhakar Mahadev Lad , "linux-renesas-soc@vger.kernel.org" References: <20221006135717.1748560-1-biju.das.jz@bp.renesas.com> <20221006135717.1748560-2-biju.das.jz@bp.renesas.com> <20221006201746.GA93297-robh@kernel.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 08/10/2022 09:42, Biju Das wrote: >>>> + "tgia8", "tgib8", "tgic8", "tgid8", >>> "tgiv8", "tgiu8"; >>>> + clocks = <&cpg CPG_MOD R9A07G044_MTU_X_MCK_MTU3>; >>>> + power-domains = <&cpg>; >>>> + resets = <&cpg R9A07G044_MTU_X_PRESET_MTU3>; >>>> + >>>> + counter { >>>> + compatible = "renesas,rz-mtu3-counter"; >>> >>> You don't have any resources for the counter in DT, so you don't >> even >>> need a node here. Just have the parent driver instaniate the counter >>> driver. >> > > If I remove "renesas,rz-mtu3-counter" and "renesas,rz-mtu3-pwm" then instantiating > the counter and pwm driver from parent driver by directly calling probe function is > giving cyclic dependency error[1]. How is this related to DT? Purpose of DT is not to solve your probe problems. > > So looks like either we need to use compatible "renesas,rz-mtu3-counter" and > "renesas,rz-mtu3-pwm" if these functionalities to be in respective subsystem tree > No, you don't need. Your driver implementation is not really related to the bindings. Best regards, Krzysztof