devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: <Codrin.Ciubotariu@microchip.com>
To: <Eugen.Hristev@microchip.com>, <robh+dt@kernel.org>,
	<Ludovic.Desroches@microchip.com>, <wsa@the-dreams.de>,
	<linux-i2c@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <peda@axentia.se>
Cc: <Nicolas.Ferre@microchip.com>
Subject: Re: [PATCH 2/3] i2c: at91: fix clk_offset for sama5d2
Date: Fri, 6 Dec 2019 16:58:53 +0000	[thread overview]
Message-ID: <8b911756-e1ad-0a49-f553-7d58b2f3c155@microchip.com> (raw)
In-Reply-To: <1575276957-5615-2-git-send-email-eugen.hristev@microchip.com>

On 02.12.2019 10:56, Eugen Hristev - M18282 wrote:
> From: Eugen Hristev <eugen.hristev@microchip.com>
> 
> In SAM9X60 datasheet, FLEX_TWI_CWGR register rescription mentions clock
> offset of 3 cycles (compared to 4 in eg. SAMA5D3).
> This is the same offset as in SAMA5D2.
> 
> Fixes: b00277923743 ("i2c: at91: add new platform support for sam9x60")
> Suggested-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>

Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>

Thanks!

Best regards,
Codrin

> ---
>   drivers/i2c/busses/i2c-at91-core.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/i2c-at91-core.c b/drivers/i2c/busses/i2c-at91-core.c
> index e13af48..5137e62 100644
> --- a/drivers/i2c/busses/i2c-at91-core.c
> +++ b/drivers/i2c/busses/i2c-at91-core.c
> @@ -174,7 +174,7 @@ static struct at91_twi_pdata sama5d2_config = {
>   
>   static struct at91_twi_pdata sam9x60_config = {
>   	.clk_max_div = 7,
> -	.clk_offset = 4,
> +	.clk_offset = 3,
>   	.has_unre_flag = true,
>   	.has_alt_cmd = true,
>   	.has_hold_field = true,
> 


  parent reply	other threads:[~2019-12-06 16:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-02  8:56 [PATCH 1/3] dt-bindings: i2c: at91: cosmetic formatting of compatible list Eugen.Hristev
2019-12-02  8:56 ` [PATCH 2/3] i2c: at91: fix clk_offset for sama5d2 Eugen.Hristev
2019-12-02  9:01   ` [PATCH v2 2/3] i2c: at91: fix clk_offset for sam9x60 Eugen.Hristev
2019-12-03  7:01     ` Ludovic Desroches
2019-12-06 16:58   ` Codrin.Ciubotariu [this message]
2019-12-02  8:56 ` [PATCH 3/3] i2c: at91: remote default value initialization Eugen.Hristev
2019-12-03  7:13   ` Ludovic Desroches
2019-12-03  6:57 ` [PATCH 1/3] dt-bindings: i2c: at91: cosmetic formatting of compatible list Ludovic Desroches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8b911756-e1ad-0a49-f553-7d58b2f3c155@microchip.com \
    --to=codrin.ciubotariu@microchip.com \
    --cc=Eugen.Hristev@microchip.com \
    --cc=Ludovic.Desroches@microchip.com \
    --cc=Nicolas.Ferre@microchip.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peda@axentia.se \
    --cc=robh+dt@kernel.org \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).