From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25ED8C33CAF for ; Mon, 13 Jan 2020 21:28:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EBC5420CC7 for ; Mon, 13 Jan 2020 21:28:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="Lcox1vkA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728516AbgAMV24 (ORCPT ); Mon, 13 Jan 2020 16:28:56 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:49144 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726488AbgAMV24 (ORCPT ); Mon, 13 Jan 2020 16:28:56 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id 00DLShVu153496; Mon, 13 Jan 2020 21:28:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2019-08-05; bh=kOS3eT26FYkCs3ZW6Ea57yVyzp/mMYsR+c//v2A9eQg=; b=Lcox1vkA3UX4fQQOQPCy3lyBWF3NxLYb+0J8QrBIfy+dZ0GixOYTczwifI6n+sqHhf9q 4dVED11/MOv2fHFLLyr3htzinWFlsqkapYAWQ/1oCm5CGPgDEOsHOnCxlz2K593bXFZ3 4eVSmHyrcK1mGRSb+otBWBuwdskwOMR7oA1+pGn82VX62YpPa4t+OVR9tCTNh6gEAGBb Ls3gh6pXfC7iPX1Lh/jcgH8HNV/X64Ct5jn/znTcf4jfMjAgTt8HE+Zh22JkJukMfYM7 qCVcxPETOTEwYGvBfCutwZ9vHnuA/06Z+PHprWxx9NMVAt6EmiJIbMrp8dxgYpxwoHkB Qw== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2130.oracle.com with ESMTP id 2xf74s1r2p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 13 Jan 2020 21:28:43 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id 00DLF6fc061634; Mon, 13 Jan 2020 21:28:42 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3020.oracle.com with ESMTP id 2xfqvtbxpe-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 13 Jan 2020 21:28:42 +0000 Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 00DLSepq008043; Mon, 13 Jan 2020 21:28:41 GMT Received: from [10.209.227.41] (/10.209.227.41) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 13 Jan 2020 13:28:40 -0800 Subject: Re: [PATCH v8 02/18] soc: ti: k3: add navss ringacc driver To: Peter Ujfalusi , vkoul@kernel.org, robh+dt@kernel.org, nm@ti.com, ssantosh@kernel.org Cc: dan.j.williams@intel.com, dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, grygorii.strashko@ti.com, lokeshvutla@ti.com, t-kristo@ti.com, tony@atomide.com, j-keerthy@ti.com, vigneshr@ti.com, frowand.list@gmail.com References: <20191223110458.30766-1-peter.ujfalusi@ti.com> <20191223110458.30766-3-peter.ujfalusi@ti.com> <6d70686b-a94e-18d1-7b33-ff9df7176089@ti.com> From: santosh.shilimkar@oracle.com Organization: Oracle Corporation Message-ID: <900c2f21-22bf-47f9-5c3c-0a3d95a5d645@oracle.com> Date: Mon, 13 Jan 2020 13:28:39 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <6d70686b-a94e-18d1-7b33-ff9df7176089@ti.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9499 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=2 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-2001130173 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9499 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-2001130175 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 12/23/19 3:38 AM, Peter Ujfalusi wrote: > Hi Santosh, > > On 23/12/2019 13.04, Peter Ujfalusi wrote: >> From: Grygorii Strashko >> >> The Ring Accelerator (RINGACC or RA) provides hardware acceleration to >> enable straightforward passing of work between a producer and a consumer. >> There is one RINGACC module per NAVSS on TI AM65x SoCs. >> >> The RINGACC converts constant-address read and write accesses to equivalent >> read or write accesses to a circular data structure in memory. The RINGACC >> eliminates the need for each DMA controller which needs to access ring >> elements from having to know the current state of the ring (base address, >> current offset). The DMA controller performs a read or write access to a >> specific address range (which maps to the source interface on the RINGACC) >> and the RINGACC replaces the address for the transaction with a new address >> which corresponds to the head or tail element of the ring (head for reads, >> tail for writes). Since the RINGACC maintains the state, multiple DMA >> controllers or channels are allowed to coherently share the same rings as >> applicable. The RINGACC is able to place data which is destined towards >> software into cached memory directly. >> >> Supported ring modes: >> - Ring Mode >> - Messaging Mode >> - Credentials Mode >> - Queue Manager Mode >> >> TI-SCI integration: >> >> Texas Instrument's System Control Interface (TI-SCI) Message Protocol now >> has control over Ringacc module resources management (RM) and Rings >> configuration. >> >> The corresponding support of TI-SCI Ringacc module RM protocol >> introduced as option through DT parameters: >> - ti,sci: phandle on TI-SCI firmware controller DT node >> - ti,sci-dev-id: TI-SCI device identifier as per TI-SCI firmware spec >> >> if both parameters present - Ringacc driver will configure/free/reset Rings >> using TI-SCI Message Ringacc RM Protocol. >> >> The Ringacc driver manages Rings allocation by itself now and requests >> TI-SCI firmware to allocate and configure specific Rings only. It's done >> this way because, Linux driver implements two stage Rings allocation and >> configuration (allocate ring and configure ring) while TI-SCI Message >> Protocol supports only one combined operation (allocate+configure). >> >> Signed-off-by: Grygorii Strashko >> Signed-off-by: Peter Ujfalusi >> Reviewed-by: Tero Kristo >> Tested-by: Keerthy > > Can you please giver your Acked-by for the ringacc patches if they are > still OK from your point of view as you had offered to take them before > I got comments from Lokesh. > Sure. But you really need to split the series so that dma engine and soc driver patches can be applied independently. Can you please do that?