From: Marc Zyngier <maz@kernel.org>
To: Samuel Dionne-Riel <samuel@dionne-riel.com>,
Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, Frank Rowand <frowand.list@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: Boot failure on gru-scarlet-inx with 5.9-rc2
Date: Mon, 31 Aug 2020 10:27:37 +0100 [thread overview]
Message-ID: <90731ebb54fe03003dce03bc7ec4872e@kernel.org> (raw)
In-Reply-To: <20200831031838.2d6d76d9@DUFFMAN>
On 2020-08-31 08:18, Samuel Dionne-Riel wrote:
> On Sun, 30 Aug 2020 10:41:42 +0100
> Marc Zyngier <maz@kernel.org> wrote:
>
> Hi,
>
>>
>> Could you try replacing the problematic patch with [1], and let me
>> know whether this changes anything on your end? This patch probably
>> isn't the right approach, but it would certainly help pointing me
>> in the right direction.
>>
>> [1]
>> https://lore.kernel.org/lkml/20200815125112.462652-2-maz@kernel.org/
>
> Following through a bisect session to figure out why the Wi-Fi broke
> between 5.8 and 5.9-rc1, I figured out something that you might have in
> mind already.
>
> It seems that anything that makes of_bus_pci_match return true will
> cause this to happen. This is why your initial fix also fails.
>
> I believe my understanding is right since applying the following on top
> of 5.9-rc1 also produces the same result.
>
> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> @@ -227,6 +227,7 @@ dmac_peri: dma-controller@ff6e0000 {
> };
>
> pcie0: pcie@f8000000 {
> + device_type = "pci";
> compatible = "rockchip,rk3399-pcie";
> reg = <0x0 0xf8000000 0x0 0x2000000>,
> <0x0 0xfd000000 0x0 0x1000000>;
>
>
> This was found out since the Wi-Fi pci-based ath10k Wi-Fi broke, with
> 2f96593ecc37e98bf99525f0629128080533867f, which changes stuff around
> pci bus... things...
>
> Am I understanding right that your fix(es) were related to the change
> set where the commit is found?
>
> My intuition is that the commit causing the boot issue could be related
> to changes with PCI or PCIe subsystems, and that your fix for
> of_bus_pci_match is a red herring, that only surfaced the existing
> issue.
>
> This is backed by applying the previous dts patch on top of 2f96593e,
> and having Wi-Fi work. I would assume that between that commit and
> 5.9-rc1 there is a commit that causes the complete failure to boot,
> which is unrelated to the first identified commit on 5.9-rc2.
Ah, so actually anything that *enables pcie* kills your system.
Great investigative work!
>
> And backed by a further bisection with this that points to
> d84c572de1a360501d2e439ac632126f5facf59d being the actual change that
> causes the tablet to fail to boot, as long as the pcie0 node is
> identified as pci properly.
>
> I am unsure if I should add as a Cc everyone involved in that change
> set, though the author (coincidentally) is already in the original list
> of recipients.
I've deliberately moved Rob from Cc to To... ;-)
> Any additional thoughts from this additional information?
What you could do is to start looking at which of the pci_is_root_bus()
changes breaks PCIe on this system. The fact that it breaks on your
system and not on mine is a bit puzzling.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2020-08-31 9:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-29 20:54 Boot failure on gru-scarlet-inx with 5.9-rc2 Samuel Dionne-Riel
2020-08-30 9:41 ` Marc Zyngier
2020-08-30 20:19 ` Samuel Dionne-Riel
2020-08-31 7:18 ` Samuel Dionne-Riel
2020-08-31 9:27 ` Marc Zyngier [this message]
2020-09-01 3:45 ` Samuel Dionne-Riel
2020-09-01 15:37 ` Marc Zyngier
2020-09-01 16:42 ` Lorenzo Pieralisi
2020-09-01 18:33 ` Samuel Dionne-Riel
2020-09-02 16:01 ` Lorenzo Pieralisi
2020-09-03 3:47 ` Samuel Dionne-Riel
2020-09-03 9:19 ` Lorenzo Pieralisi
2020-09-03 14:35 ` Rob Herring
2020-09-03 15:59 ` Marc Zyngier
2020-09-03 19:21 ` Samuel Dionne-Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90731ebb54fe03003dce03bc7ec4872e@kernel.org \
--to=maz@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=samuel@dionne-riel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).