From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Sven Van Asbroeck <thesven73@gmail.com>
Cc: Lee Jones <lee.jones@linaro.org>, Pavel Machek <pavel@ucw.cz>,
Rob Herring <robh+dt@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Grigoryev Denis <grigoryev@fastwel.ru>,
Axel Lin <axel.lin@ingics.com>, Dan Murphy <dmurphy@ti.com>,
Mark Rutland <mark.rutland@arm.com>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-leds@vger.kernel.org
Subject: Re: [PATCH v3 2/3] leds: tps6105x: add driver for mfd chip led mode
Date: Wed, 20 Nov 2019 22:50:25 +0100 [thread overview]
Message-ID: <93dce6c1-e044-086d-3c4a-a3219c26ddee@gmail.com> (raw)
In-Reply-To: <CAGngYiXP8xu3UQTZxEqSXNkic3iNU43hD-KBJQkAmduXPp8zhQ@mail.gmail.com>
On 11/20/19 10:41 PM, Sven Van Asbroeck wrote:
> Hi Jacek,
>
> On Wed, Nov 20, 2019 at 4:33 PM Jacek Anaszewski
> <jacek.anaszewski@gmail.com> wrote:
>> This is covered in DT bindings, it is redundant in the commit message.
>
> Ok, I will remove it from the commit message.
>
>>> + priv->cdev.name = "tps6105x::torch";
>>
>> Please remove above line.
>>
>> And use new LED registration API like below:
>>
>> struct led_init_data init_data = {
>> .devicename = "tps6105x",
>> .default_label = ":torch" };
>>
>> return devm_led_classdev_register_ext(&pdev->dev, &priv->cdev, &init_data);
>
> I would love to do that, but my platform (with a tps6105x) can only boot a lts
> vendor kernel (4.14). classdev_register_ext() is not available there.
>
> I can make the change you suggest, but cannot test to check if it will actually
> work. Is that ok for you?
Can't you backport also the LED core patches with *ext API?
--
Best regards,
Jacek Anaszewski
next prev parent reply other threads:[~2019-11-20 21:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 14:43 [PATCH v3 0/3] tps6105x add devicetree and leds support Sven Van Asbroeck
2019-11-20 14:43 ` [PATCH v3 1/3] tps6105x: add optional devicetree support Sven Van Asbroeck
2019-11-20 14:44 ` [PATCH v3 2/3] leds: tps6105x: add driver for mfd chip led mode Sven Van Asbroeck
2019-11-20 21:33 ` Jacek Anaszewski
2019-11-20 21:41 ` Sven Van Asbroeck
2019-11-20 21:50 ` Jacek Anaszewski [this message]
2019-11-20 14:44 ` [PATCH v3 3/3] dt-bindings: mfd: update TI tps6105x chip bindings Sven Van Asbroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93dce6c1-e044-086d-3c4a-a3219c26ddee@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=axel.lin@ingics.com \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=grigoryev@fastwel.ru \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=thesven73@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).