* [PATCH 1/2] dt-bindings: iio: adc: rockchip-saradc: add description for rk3568
@ 2021-07-02 2:14 Simon Xue
2021-07-02 2:15 ` [PATCH 2/2] iio: adc: rockchip_saradc: add support for rk3568 saradc Simon Xue
2021-07-02 10:09 ` [PATCH 1/2] dt-bindings: iio: adc: rockchip-saradc: add description for rk3568 Johan Jonker
0 siblings, 2 replies; 4+ messages in thread
From: Simon Xue @ 2021-07-02 2:14 UTC (permalink / raw)
To: Jonathan Cameron
Cc: linux-rockchip, devicetree, robh+dt, Johan Jonker,
Heiko Stuebner, Lars-Peter Clausen, Peter Meerwald-Stadler,
linux-iio, Simon Xue
Signed-off-by: Simon Xue <xxm@rock-chips.com>
---
Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml b/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml
index 1bb76197787b..e512a14e41b4 100644
--- a/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml
@@ -20,6 +20,7 @@ properties:
- rockchip,px30-saradc
- rockchip,rk3308-saradc
- rockchip,rk3328-saradc
+ - rockchip,rk3568-saradc
- rockchip,rv1108-saradc
- const: rockchip,rk3399-saradc
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] iio: adc: rockchip_saradc: add support for rk3568 saradc
2021-07-02 2:14 [PATCH 1/2] dt-bindings: iio: adc: rockchip-saradc: add description for rk3568 Simon Xue
@ 2021-07-02 2:15 ` Simon Xue
2021-07-03 16:59 ` Jonathan Cameron
2021-07-02 10:09 ` [PATCH 1/2] dt-bindings: iio: adc: rockchip-saradc: add description for rk3568 Johan Jonker
1 sibling, 1 reply; 4+ messages in thread
From: Simon Xue @ 2021-07-02 2:15 UTC (permalink / raw)
To: Jonathan Cameron
Cc: linux-rockchip, devicetree, robh+dt, Johan Jonker,
Heiko Stuebner, Lars-Peter Clausen, Peter Meerwald-Stadler,
linux-iio, Simon Xue
Signed-off-by: Simon Xue <xxm@rock-chips.com>
---
drivers/iio/adc/rockchip_saradc.c | 22 +++++++++++++++++++++-
1 file changed, 21 insertions(+), 1 deletion(-)
diff --git a/drivers/iio/adc/rockchip_saradc.c b/drivers/iio/adc/rockchip_saradc.c
index 12584f1631d8..f3eb8d2e50dc 100644
--- a/drivers/iio/adc/rockchip_saradc.c
+++ b/drivers/iio/adc/rockchip_saradc.c
@@ -35,7 +35,7 @@
#define SARADC_DLY_PU_SOC_MASK 0x3f
#define SARADC_TIMEOUT msecs_to_jiffies(100)
-#define SARADC_MAX_CHANNELS 6
+#define SARADC_MAX_CHANNELS 8
struct rockchip_saradc_data {
const struct iio_chan_spec *channels;
@@ -192,6 +192,23 @@ static const struct rockchip_saradc_data rk3399_saradc_data = {
.clk_rate = 1000000,
};
+static const struct iio_chan_spec rockchip_rk3568_saradc_iio_channels[] = {
+ SARADC_CHANNEL(0, "adc0", 10),
+ SARADC_CHANNEL(1, "adc1", 10),
+ SARADC_CHANNEL(2, "adc2", 10),
+ SARADC_CHANNEL(3, "adc3", 10),
+ SARADC_CHANNEL(4, "adc4", 10),
+ SARADC_CHANNEL(5, "adc5", 10),
+ SARADC_CHANNEL(6, "adc6", 10),
+ SARADC_CHANNEL(7, "adc7", 10),
+};
+
+static const struct rockchip_saradc_data rk3568_saradc_data = {
+ .channels = rockchip_rk3568_saradc_iio_channels,
+ .num_channels = ARRAY_SIZE(rockchip_rk3568_saradc_iio_channels),
+ .clk_rate = 1000000,
+};
+
static const struct of_device_id rockchip_saradc_match[] = {
{
.compatible = "rockchip,saradc",
@@ -202,6 +219,9 @@ static const struct of_device_id rockchip_saradc_match[] = {
}, {
.compatible = "rockchip,rk3399-saradc",
.data = &rk3399_saradc_data,
+ }, {
+ .compatible = "rockchip,rk3568-saradc",
+ .data = &rk3568_saradc_data,
},
{},
};
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] dt-bindings: iio: adc: rockchip-saradc: add description for rk3568
2021-07-02 2:14 [PATCH 1/2] dt-bindings: iio: adc: rockchip-saradc: add description for rk3568 Simon Xue
2021-07-02 2:15 ` [PATCH 2/2] iio: adc: rockchip_saradc: add support for rk3568 saradc Simon Xue
@ 2021-07-02 10:09 ` Johan Jonker
1 sibling, 0 replies; 4+ messages in thread
From: Johan Jonker @ 2021-07-02 10:09 UTC (permalink / raw)
To: Simon Xue, Jonathan Cameron
Cc: linux-rockchip, devicetree, robh+dt, Heiko Stuebner,
Lars-Peter Clausen, Peter Meerwald-Stadler, linux-iio
Hi Simon,
The file rk3568.dtsi is now available in linux-next.
Could you make a complete package with also a patch for rk3568.dtsi?
Johan
===
rk3568.dtsi:
saradc: saradc@fe720000 {
compatible = "rockchip,rk3568-saradc", "rockchip,rk3399-saradc";
reg = <0x0 0xfe720000 0x0 0x100>;
interrupts = <GIC_SPI 93 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&cru CLK_SARADC>, <&cru PCLK_SARADC>;
clock-names = "saradc", "apb_pclk";
resets = <&cru SRST_P_SARADC>;
reset-names = "saradc-apb";
#io-channel-cells = <1>;
status = "disabled";
};
On 7/2/21 4:14 AM, Simon Xue wrote:
> Signed-off-by: Simon Xue <xxm@rock-chips.com>
> ---
> Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml b/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml
> index 1bb76197787b..e512a14e41b4 100644
> --- a/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/rockchip-saradc.yaml
> @@ -20,6 +20,7 @@ properties:
> - rockchip,px30-saradc
> - rockchip,rk3308-saradc
> - rockchip,rk3328-saradc
> + - rockchip,rk3568-saradc
> - rockchip,rv1108-saradc
> - const: rockchip,rk3399-saradc
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] iio: adc: rockchip_saradc: add support for rk3568 saradc
2021-07-02 2:15 ` [PATCH 2/2] iio: adc: rockchip_saradc: add support for rk3568 saradc Simon Xue
@ 2021-07-03 16:59 ` Jonathan Cameron
0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2021-07-03 16:59 UTC (permalink / raw)
To: Simon Xue
Cc: linux-rockchip, devicetree, robh+dt, Johan Jonker,
Heiko Stuebner, Lars-Peter Clausen, Peter Meerwald-Stadler,
linux-iio
On Fri, 2 Jul 2021 10:15:27 +0800
Simon Xue <xxm@rock-chips.com> wrote:
A small amount of info on the device is always useful in a commit like this.
Here, perhaps you could call out that it is similar to some other device, but
with 8 channels?
Otherwise, looks good to me. DT patch is fine as well. I'll let them sit
a little longer though to give others time to comment.
The dtsi change requested by Johan goes via a different tree anyway so doesn't
need to be part of this series.
Jonathan
> Signed-off-by: Simon Xue <xxm@rock-chips.com>
> ---
> drivers/iio/adc/rockchip_saradc.c | 22 +++++++++++++++++++++-
> 1 file changed, 21 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/rockchip_saradc.c b/drivers/iio/adc/rockchip_saradc.c
> index 12584f1631d8..f3eb8d2e50dc 100644
> --- a/drivers/iio/adc/rockchip_saradc.c
> +++ b/drivers/iio/adc/rockchip_saradc.c
> @@ -35,7 +35,7 @@
> #define SARADC_DLY_PU_SOC_MASK 0x3f
>
> #define SARADC_TIMEOUT msecs_to_jiffies(100)
> -#define SARADC_MAX_CHANNELS 6
> +#define SARADC_MAX_CHANNELS 8
>
> struct rockchip_saradc_data {
> const struct iio_chan_spec *channels;
> @@ -192,6 +192,23 @@ static const struct rockchip_saradc_data rk3399_saradc_data = {
> .clk_rate = 1000000,
> };
>
> +static const struct iio_chan_spec rockchip_rk3568_saradc_iio_channels[] = {
> + SARADC_CHANNEL(0, "adc0", 10),
> + SARADC_CHANNEL(1, "adc1", 10),
> + SARADC_CHANNEL(2, "adc2", 10),
> + SARADC_CHANNEL(3, "adc3", 10),
> + SARADC_CHANNEL(4, "adc4", 10),
> + SARADC_CHANNEL(5, "adc5", 10),
> + SARADC_CHANNEL(6, "adc6", 10),
> + SARADC_CHANNEL(7, "adc7", 10),
> +};
> +
> +static const struct rockchip_saradc_data rk3568_saradc_data = {
> + .channels = rockchip_rk3568_saradc_iio_channels,
> + .num_channels = ARRAY_SIZE(rockchip_rk3568_saradc_iio_channels),
> + .clk_rate = 1000000,
> +};
> +
> static const struct of_device_id rockchip_saradc_match[] = {
> {
> .compatible = "rockchip,saradc",
> @@ -202,6 +219,9 @@ static const struct of_device_id rockchip_saradc_match[] = {
> }, {
> .compatible = "rockchip,rk3399-saradc",
> .data = &rk3399_saradc_data,
> + }, {
> + .compatible = "rockchip,rk3568-saradc",
> + .data = &rk3568_saradc_data,
> },
> {},
> };
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-07-03 16:57 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-02 2:14 [PATCH 1/2] dt-bindings: iio: adc: rockchip-saradc: add description for rk3568 Simon Xue
2021-07-02 2:15 ` [PATCH 2/2] iio: adc: rockchip_saradc: add support for rk3568 saradc Simon Xue
2021-07-03 16:59 ` Jonathan Cameron
2021-07-02 10:09 ` [PATCH 1/2] dt-bindings: iio: adc: rockchip-saradc: add description for rk3568 Johan Jonker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).