From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1BDEC433FE for ; Wed, 10 Nov 2021 07:45:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A0895611C9 for ; Wed, 10 Nov 2021 07:45:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229966AbhKJHsG (ORCPT ); Wed, 10 Nov 2021 02:48:06 -0500 Received: from smtp-relay-internal-0.canonical.com ([185.125.188.122]:58896 "EHLO smtp-relay-internal-0.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229721AbhKJHsF (ORCPT ); Wed, 10 Nov 2021 02:48:05 -0500 Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 4E0163F340 for ; Wed, 10 Nov 2021 07:45:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1636530317; bh=N83ESKUHB/kqrmHqZ+hpUE8Wq2iA/YnywAyf4v9xq00=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=wXXPSCVYjdbs+iToRmvDGzHd6Miv6O1tDdodDVe4wa8qGHVfeKUSS5PC78qkezXai amgLYBVeA1VtPSJRoi3Iby5rt1LjltMPAJ2QPejvVd5XqnN1eSX3W28kO/O2ff5Tfk YX0iWJ7NVO5aG2V7bc7gWhtjgU33bC24zKs+eLShPdqMgc1zrGhVniAWBNMM4Q34OE C4mCZXuIBu285I8qHAAXYIsWQOMVAObouAffw+24YxLxaoTXcjPtMZNyNM0ymDBKVR nYhnmPCgnYC3gyeK1FR5zujF3MPKuitajUivHrnHNPVU5RQTkcqvjTemCcAgGSzNFz q83sqxucguO/w== Received: by mail-lj1-f197.google.com with SMTP id d20-20020a05651c111400b00218c6372b7eso287604ljo.16 for ; Tue, 09 Nov 2021 23:45:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=N83ESKUHB/kqrmHqZ+hpUE8Wq2iA/YnywAyf4v9xq00=; b=4qRva2nhcjzE5H4VZb+X0J6c25DX2sIpoXLjtOdC0nrmVVKnKhDdVaYZC6r+YJeQS4 mDBvADZipk4q39rtbExuJY9gXVBfW/vDR/4aVWHGUTE5uPj9eKdG4evPKJ9r65bNShGv 3pnN7dhu31b0t/EuORFoWApNAno+CaV9cnSKEI1mIsLJaaha5MNOm46cKCI4i+fokz5L qZfUgLWZynNPQkvwbbEC6JctDNRyxhRTN69h6r4T54pKRtfjC9M5YQioDA4lI4CTDJWA 6GiS0le/Gb+l0acHSDIDpmtyS9vCJ9R+SMLaZKaPt4e1p4Is8wOG0xittxYW6Ae1FFlE 7kbg== X-Gm-Message-State: AOAM532hDyH2pmDTTKHwLiB1Ecw6Xj/a5CyJTEI0WMhPEJoKivjPhOkP ZlqzwiQgpDXSdPQnfO40DfnEDyFJshFNr5K+1RLYrCo9sYAMgsVTFxtB0143rLa8KbHoaMKqgXr jkaZkbJRtWrW8oWyM21KU4NXlQZKtj+q0OQzIu5Q= X-Received: by 2002:a05:651c:11cf:: with SMTP id z15mr13724623ljo.30.1636530316475; Tue, 09 Nov 2021 23:45:16 -0800 (PST) X-Google-Smtp-Source: ABdhPJxj/L+35JjL2smH5MiuFZkelZYQSjo3AZ/1hVDezSpzMKpDS3vieitpkj9D1r3Hbn/gkMU6Bw== X-Received: by 2002:a05:651c:11cf:: with SMTP id z15mr13724596ljo.30.1636530316282; Tue, 09 Nov 2021 23:45:16 -0800 (PST) Received: from [192.168.3.67] (89-77-68-124.dynamic.chello.pl. [89.77.68.124]) by smtp.gmail.com with ESMTPSA id b22sm2384886lfi.67.2021.11.09.23.45.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Nov 2021 23:45:15 -0800 (PST) Message-ID: <978563c0-95fd-1c76-42a2-5e0ab9cbc61d@canonical.com> Date: Wed, 10 Nov 2021 08:45:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Subject: Re: [PATCH 10/13] dt-bindings: spi: add bindings for microchip mpfs spi Content-Language: en-US To: Conor.Dooley@microchip.com, robh@kernel.org Cc: robh+dt@kernel.org, gregkh@linuxfoundation.org, linus.walleij@linaro.org, linux-riscv@lists.infradead.org, aou@eecs.berkeley.edu, paul.walmsley@sifive.com, linux-usb@vger.kernel.org, Daire.McNamara@microchip.com, linux-spi@vger.kernel.org, geert@linux-m68k.org, devicetree@vger.kernel.org, linux-rtc@vger.kernel.org, linux-gpio@vger.kernel.org, broonie@kernel.org, palmer@dabbelt.com, bgolaszewski@baylibre.com, jassisinghbrar@gmail.com, linux-crypto@vger.kernel.org, Ivan.Griffin@microchip.com, atish.patra@wdc.com, Lewis.Hanly@microchip.com, bin.meng@windriver.com, alexandre.belloni@bootlin.com, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, a.zummo@towertech.it References: <20211108150554.4457-1-conor.dooley@microchip.com> <20211108150554.4457-11-conor.dooley@microchip.com> <1636430789.935637.743042.nullmailer@robh.at.kernel.org> <96005893-8819-1d76-6dea-7d173655258f@microchip.com> <0d996393-20b9-4f16-cbd0-c9bff2b54112@canonical.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 09/11/2021 14:20, Conor.Dooley@microchip.com wrote: > On 09/11/2021 13:04, Krzysztof Kozlowski wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >> >> On 09/11/2021 13:58, Conor.Dooley@microchip.com wrote: >>> On 09/11/2021 12:53, Krzysztof Kozlowski wrote: >>>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >>>> >>>> On 09/11/2021 13:16, Conor.Dooley@microchip.com wrote: >>>>> On 09/11/2021 04:06, Rob Herring wrote: >>>>>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >>>>>> >>>>>> On Mon, 08 Nov 2021 15:05:51 +0000, conor.dooley@microchip.com wrote: >>>>>>> From: Conor Dooley >>>>>>> >>>>>>> Add device tree bindings for the {q,}spi controller on >>>>>>> the Microchip PolarFire SoC. >>>>>>> >>>>>>> Signed-off-by: Conor Dooley >>>>>>> --- >>>>>>> .../bindings/spi/microchip,mpfs-spi.yaml | 72 +++++++++++++++++++ >>>>>>> 1 file changed, 72 insertions(+) >>>>>>> create mode 100644 Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml >>>>>>> >>>>>> >>>>>> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' >>>>>> on your patch (DT_CHECKER_FLAGS is new in v5.13): >>>>>> >>>>>> yamllint warnings/errors: >>>>>> >>>>>> dtschema/dtc warnings/errors: >>>>>> Documentation/devicetree/bindings/spi/microchip,mpfs-spi.example.dts:19:18: fatal error: dt-bindings/clock/microchip,mpfs-clock.h: No such file or directory >>>>>> 19 | #include "dt-bindings/clock/microchip,mpfs-clock.h" >>>>> Rob, >>>>> Should I drop the header from the example or is there a way for me >>>>> specify the dependent patch to pass this check? >>>> >>>> The error has to be fixed, although not necessarily by dropping the >>>> header, but by posting it. How this can pass on your system? There is no >>>> such file added in this patchset. >>> I linked the patch adding the clock as a dependency in the cover letter >>> [1], which is why I was wondering if there was a better way to do so >>> that would get picked up by the checker bot. >> >> It's not only about the bot, but dependency when applied. If you did not >> warn clk maintainer that clock bindings should go via Rob's tree or >> should be provided as a tag, the patches here cannot be applied in this >> cycle. > It was not my (our) intention to send the clock patches via rob's tree. > And since this is my first time trying to upstream wholescale changes to > a device tree I honestly didn't expect this series to get accepted in > this cycle anyway. OK :) Assuming your new bindings pass db_binding_check with DT_CHECKER_FLAGS=-m (on top of clock patch), I propose to keep the header here. Another idea would be to submit without the header and use raw IDs (numbers) and convert it later. I prefer the first- base on clock patches. Best regards, Krzysztof