From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Dan Murphy <dmurphy@ti.com>,
robh+dt@kernel.org, mark.rutland@arm.com, rpurdie@rpsys.net,
pavel@ucw.cz, sakari.ailus@iki.fi,
laurent.pinchart@ideasonboard.com
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-leds@vger.kernel.org
Subject: Re: [PATCH] leds: as3645a: Fix checkpatch warnings
Date: Wed, 13 Dec 2017 21:43:16 +0100 [thread overview]
Message-ID: <98df06ef-9ee4-02b1-6d6b-f10b911a8d71@gmail.com> (raw)
In-Reply-To: <bf955d16-9af0-7776-354a-dc2a71b525f1@ti.com>
Dan,
On 12/13/2017 09:41 PM, Dan Murphy wrote:
> Jacek
>
> On 12/13/2017 02:29 PM, Jacek Anaszewski wrote:
>> Hi Dan,
>>
>> checkpatch.pl doesn't want to be mentioned in the patch subject :-)
>>
>
> Ack
>
>> "WARNING: A patch subject line should describe the change not the tool
>> that found it"
>>
>> Preferably I'd see two separate patches.
>>
>
> So you want me to split them up? I have no issue with that.
Yeah, it will be easier to come up with concise but meaningful
subjects.
>> Also, line length limit for the commit description is 75 characters.
>> Please use whole available space.
>>
>
>
--
Best regards,
Jacek Anaszewski
next prev parent reply other threads:[~2017-12-13 20:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 21:50 [PATCH] leds: as3645a: Fix checkpatch warnings Dan Murphy
[not found] ` <20171212215011.30066-1-dmurphy-l0cyMroinI0@public.gmane.org>
2017-12-12 23:35 ` Laurent Pinchart
2017-12-13 12:56 ` Pavel Machek
2017-12-13 20:29 ` Jacek Anaszewski
2017-12-13 20:41 ` Dan Murphy
2017-12-13 20:43 ` Jacek Anaszewski [this message]
2017-12-13 20:49 ` Dan Murphy
2017-12-13 21:32 ` Laurent Pinchart
[not found] ` <799ae164-701a-87ce-fadf-8278f01c10d6-l0cyMroinI0@public.gmane.org>
2017-12-14 22:50 ` Pavel Machek
2017-12-14 22:49 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98df06ef-9ee4-02b1-6d6b-f10b911a8d71@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=rpurdie@rpsys.net \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).