From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Martin Povišer" <povik+lin@cutebit.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>
Cc: alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Mark Kettenis <kettenis@openbsd.org>,
Hector Martin <marcan@marcan.st>, Sven Peter <sven@svenpeter.dev>
Subject: Re: [RFC PATCH 1/5] dt-bindings: sound: Add Apple Macs sound system
Date: Thu, 31 Mar 2022 08:43:58 +0200 [thread overview]
Message-ID: <9e3ba11c-d179-c229-fb7c-bf5611a15b1b@linaro.org> (raw)
In-Reply-To: <20220331000449.41062-2-povik+lin@cutebit.org>
On 31/03/2022 02:04, Martin Povišer wrote:
> Add binding for Apple Silicon Macs' machine-level sound system.
>
> Signed-off-by: Martin Povišer <povik+lin@cutebit.org>
> ---
> .../bindings/sound/apple,macaudio.yaml | 103 ++++++++++++++++++
> 1 file changed, 103 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/sound/apple,macaudio.yaml
>
Commit title does not match subsystem.
> diff --git a/Documentation/devicetree/bindings/sound/apple,macaudio.yaml b/Documentation/devicetree/bindings/sound/apple,macaudio.yaml
> new file mode 100644
> index 000000000000..a6380e4bdd1a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/apple,macaudio.yaml
> @@ -0,0 +1,103 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/apple,macaudio.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Apple Silicon Macs integrated sound system
> +
> +maintainers:
> + - Martin Povišer <povik+lin@cutebit.org>
> +
Add description.
> +definitions:
This does not make code more readable.
> + dai:
> + type: object
> + properties:
> + sound-dai: true
> + required:
> + - sound-dai
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - apple,j274-macaudio
> + - apple,j293-macaudio
> + - apple,j314-macaudio
> + - const: apple,macaudio
Open example-schema.yaml and look at formatting plus general coding
style. You miss line breaks making it unreadable.
> + "#address-cells":
> + const: 1
> + "#size-cells":
> + const: 0
> + model:
> + description: |
> + Model name to use when the sound system is presented to users as a sound card.
> + $ref: /schemas/types.yaml#/definitions/string
> +
> +patternProperties:
> + "^dai-link(@[0-9a-f]+)?$":
> + description: |
> + A DAI link comprising of CPU and CODEC DAI specifiers and supplemental properties.
> + type: object
> + properties:
> + reg:
> + maxItems: 1
> + mclk-fs:
> + description: |
> + Forced MCLK/samplerate factor (optional).
Optional is obvious from !required.
Description is different than existing field in simple card. Is this the
same field or not?
> + $ref: /schemas/types.yaml#/definitions/uint32
> + link-name:
> + description: Name for the DAI link to present to users.
> + $ref: /schemas/types.yaml#/definitions/string
> + cpu:
> + $ref: "#/definitions/dai"
> + codec:
> + $ref: "#/definitions/dai"
missing maxItems for DAI phandles.
> + required:
> + - reg
> + - cpu
> + - codec
> + additionalProperties: false
This entire block is unreadable.
> +
> +required:
> + - compatible
> + - model
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + sound {
> + compatible = "apple,j293-macaudio", "apple,macaudio";
> + model = "MacBook Pro J293 integrated audio";
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + dai-link@0 {
> + reg = <0>;
> + link-name = "Speakers";
> + mclk-fs = <64>;
> +
> + cpu {
> + sound-dai = <&mca 0>, <&mca 1>;
> + };
> + codec {
> + sound-dai = <&speaker_left_front>, <&speaker_right_front>,
> + <&speaker_left_rear>, <&speaker_right_rear>;
Align the line.
> + };
> + };
> +
> + dai-link@1 {
> + reg = <1>;
> + link-name = "Headphones Jack";
> + mclk-fs = <64>;
> +
> + cpu {
> + sound-dai = <&mca 2>;
> + };
> + codec {
> + sound-dai = <&jack_codec>;
> + };
> + };
> + };
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-03-31 6:44 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 0:04 [RFC PATCH 0/5] Apple Macs machine-level ASoC driver Martin Povišer
2022-03-31 0:04 ` [RFC PATCH 1/5] dt-bindings: sound: Add Apple Macs sound system Martin Povišer
2022-03-31 6:43 ` Krzysztof Kozlowski [this message]
2022-03-31 6:57 ` Martin Povišer
2022-03-31 8:17 ` Krzysztof Kozlowski
2022-03-31 8:23 ` Martin Povišer
2022-03-31 8:26 ` Krzysztof Kozlowski
2022-03-31 0:04 ` [RFC PATCH 2/5] HACK: ASoC: Add card->filter_controls hook Martin Povišer
2022-03-31 11:34 ` Mark Brown
2022-03-31 0:04 ` [RFC PATCH 3/5] HACK: ASoC: Tolerate N-cpus-to-M-codecs links Martin Povišer
2022-04-04 12:28 ` Mark Brown
2022-04-22 14:06 ` Martin Povišer
2022-04-25 12:25 ` Mark Brown
2022-04-25 12:34 ` Martin Povišer
2022-04-25 12:55 ` Mark Brown
2022-04-25 13:11 ` Martin Povišer
2022-04-25 13:46 ` Mark Brown
2022-04-25 13:55 ` Martin Povišer
2022-03-31 0:04 ` [RFC PATCH 4/5] ASoC: Introduce snd_soc_of_get_dai_link_cpus Martin Povišer
2022-03-31 0:04 ` [RFC PATCH 5/5] ASoC: Add macaudio machine driver Martin Povišer
2022-03-31 11:59 ` Mark Brown
2022-03-31 12:08 ` Martin Povišer
2022-03-31 12:16 ` Martin Povišer
2022-03-31 12:56 ` Mark Brown
2022-03-31 12:34 ` [RFC PATCH 0/5] Apple Macs machine-level ASoC driver Mark Brown
2022-03-31 13:28 ` Martin Povišer
2022-03-31 14:18 ` Mark Brown
2022-03-31 15:04 ` Martin Povišer
2022-03-31 15:36 ` Mark Brown
2022-04-22 10:43 ` Martin Povišer
2022-04-22 11:19 ` Mark Brown
2022-04-22 11:28 ` Martin Povišer
2022-04-22 11:33 ` Mark Brown
2022-04-22 11:44 ` Martin Povišer
2022-04-22 12:22 ` Mark Brown
2022-04-22 12:36 ` Martin Povišer
2022-04-22 12:44 ` Mark Brown
2022-04-22 12:53 ` Martin Povišer
2022-04-22 13:06 ` Mark Brown
2022-04-22 13:59 ` Martin Povišer
2022-03-31 13:28 ` Hector Martin
2022-03-31 14:33 ` Mark Brown
2022-04-05 9:31 ` (subset) " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e3ba11c-d179-c229-fb7c-bf5611a15b1b@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kettenis@openbsd.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=perex@perex.cz \
--cc=povik+lin@cutebit.org \
--cc=robh+dt@kernel.org \
--cc=sven@svenpeter.dev \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).