From: Peng Fan <peng.fan@nxp.com>
To: Sudeep Holla <sudeep.holla@arm.com>, Marc Zyngier <maz@kernel.org>
Cc: Marc Zyngier <maz@kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"viresh.kumar@linaro.org" <viresh.kumar@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>,
"andre.przywara@arm.com" <andre.przywara@arm.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH 1/2] dt-bindings: arm: arm,scmi: add smc/hvc transports
Date: Fri, 7 Feb 2020 11:19:22 +0000 [thread overview]
Message-ID: <AM0PR04MB4481B84BF243926462EAF74B881C0@AM0PR04MB4481.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20200207110602.GE36345@bogus>
> Subject: Re: [PATCH 1/2] dt-bindings: arm: arm,scmi: add smc/hvc transports
>
> On Fri, Feb 07, 2020 at 10:55:44AM +0000, Peng Fan wrote:
> > > Subject: Re: [PATCH 1/2] dt-bindings: arm: arm,scmi: add smc/hvc
> > > transports
> > >
> > > On Fri, Feb 07, 2020 at 10:08:36AM +0000, Marc Zyngier wrote:
> > > > On 2020-02-06 13:01, peng.fan@nxp.com wrote:
> > > > > From: Peng Fan <peng.fan@nxp.com>
> > > > >
> > > > > SCMI could use SMC/HVC as tranports, so add into devicetree
> > > > > binding doc.
> > > > >
> > > > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > > > > ---
> > > > > Documentation/devicetree/bindings/arm/arm,scmi.txt | 4 +++-
> > > > > 1 file changed, 3 insertions(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/Documentation/devicetree/bindings/arm/arm,scmi.txt
> > > > > b/Documentation/devicetree/bindings/arm/arm,scmi.txt
> > > > > index f493d69e6194..03cff8b55a93 100644
> > > > > --- a/Documentation/devicetree/bindings/arm/arm,scmi.txt
> > > > > +++ b/Documentation/devicetree/bindings/arm/arm,scmi.txt
> > > > > @@ -14,7 +14,7 @@ Required properties:
> > > > >
> > > > > The scmi node with the following properties shall be under the
> > > > > /firmware/ node.
> > > > >
> > > > > -- compatible : shall be "arm,scmi"
> > > > > +- compatible : shall be "arm,scmi" or "arm,scmi-smc"
> > > > > - mboxes: List of phandle and mailbox channel specifiers. It
> > > > > should contain
> > > > > exactly one or two mailboxes, one for transmitting messages("tx")
> > > > > and another optional for receiving the notifications("rx")
> > > > > if @@
> > > > > -25,6 +25,8 @@ The scmi node with the following properties shall
> > > > > be under the /firmware/ node.
> > > > > protocol identifier for a given sub-node.
> > > > > - #size-cells : should be '0' as 'reg' property doesn't have any size
> > > > > associated with it.
> > > > > +- arm,smc-id : SMC id required when using smc transports
> > > > > +- arm,hvc-id : HVC id required when using hvc transports
> > > > >
> > > > > Optional properties:
> > > >
> > > > Not directly related to DT: Why do we need to distinguish between
> > > > SMC and HVC?
> > >
> > > IIUC you want just one property to get the function ID ? Does that
> > > align with what you are saying ? I wanted to ask the same question
> > > and I see no need for
> > > 2 different properties.
> >
> > The multiple protocols might use SMC or HVC. Saying
> >
> > Protocol@x {
> > method="smc";
> > arm,func-id=<0x....>
> > };
> > Protocol@y {
> > method="hvc";
> > arm,func-id=<0x....>
> > };
> >
>
> Wow, stop there. Please don't do that. You either use SMC or HVC
> consistently.
> Not both at the same time. Any particular reasons for trying such crazy things.
>
> > With my propose:
> >
> > Protocol@x {
> > arm,smc-id=<0x....>
> > };
> > Protocol@y {
> > arm,hvc-id=<0x....>
> > };
> >
> > No need an extra method property to indicate it is smc or hvc.
> > The driver use take arm,smc-id as SMC, arm,hvc-id as HVC.
> >
>
> NACK, just have one function ID, I am not very particular on the name 'smc-id'
> is just fine for me. But only one function ID for any conduit used and that is
> chosen by PSCI/SMCCC.
>
> If you need multiple channels(unique per protocol) then I suggest go for an
> channel ID or you can even manage just with shmem associated with it (I
> prefer latter but again I am fine either way)
Ok. Just follow Marc suggested
Parse the conduit from PSCI context. Then only add 'smc-id' property in scmi
node, and take protocol reg as arg1. Is this ok for you?
Thanks,
Peng.
>
> --
> Regards,
> Sudeep
next prev parent reply other threads:[~2020-02-07 11:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-06 13:01 [PATCH 0/2] firmware: arm_scmi: add smc/hvc transports support peng.fan
2020-02-06 13:01 ` [PATCH 1/2] dt-bindings: arm: arm,scmi: add smc/hvc transports peng.fan
2020-02-06 21:59 ` Rob Herring
2020-02-07 8:10 ` Peng Fan
2020-02-07 10:56 ` Sudeep Holla
2020-02-07 10:08 ` Marc Zyngier
2020-02-07 10:47 ` Sudeep Holla
2020-02-07 10:55 ` Marc Zyngier
2020-02-07 11:00 ` Peng Fan
2020-02-07 11:09 ` Marc Zyngier
2020-02-07 11:32 ` Sudeep Holla
2020-02-07 11:46 ` Peng Fan
2020-02-07 10:55 ` Peng Fan
2020-02-07 11:01 ` Marc Zyngier
2020-02-07 11:06 ` Sudeep Holla
2020-02-07 11:19 ` Peng Fan [this message]
2020-02-10 0:59 ` Peng Fan
2020-02-11 12:02 ` Sudeep Holla
2020-02-06 13:01 ` [PATCH 2/2] firmware: arm_scmi: " peng.fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR04MB4481B84BF243926462EAF74B881C0@AM0PR04MB4481.eurprd04.prod.outlook.com \
--to=peng.fan@nxp.com \
--cc=andre.przywara@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).